| Message ID | 20200415135734.14660-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 79f7ab3a64fd92b86ebc992b333815400942a3b7 |
| Headers | show |
| Series | i2c: drivers: Omit superfluous error message in efm32_i2c_probe() | expand |
Hello, On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > In the function efm32_i2c_probe(),when get irq failed,the function > platform_get_irq() logs an error message,so remove redundant message > here. adding a space after each comma seems usual style. > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com> Usually the Sign-off of the sender comes last. How is Shengju Zhang involved with this patch? > diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c > index a8c6323e7..4de31fae7 100644 > --- a/drivers/i2c/busses/i2c-efm32.c > +++ b/drivers/i2c/busses/i2c-efm32.c > @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev) > > ret = platform_get_irq(pdev, 0); > if (ret <= 0) { > - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret); The change looks fine. Best regards Uwe
Hi Uwe: On 2020/4/15 22:22, Uwe Kleine-König wrote: > Hello, > > On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: >> In the function efm32_i2c_probe(),when get irq failed,the function >> platform_get_irq() logs an error message,so remove redundant message >> here. > adding a space after each comma seems usual style. Got it, I will notice. Whether should I submit v2 for this problems? Thanks. > >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com> > Usually the Sign-off of the sender comes last. How is Shengju Zhang > involved with this patch? Got it, I will notice next time. Thanks. >> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c >> index a8c6323e7..4de31fae7 100644 >> --- a/drivers/i2c/busses/i2c-efm32.c >> +++ b/drivers/i2c/busses/i2c-efm32.c >> @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev) >> >> ret = platform_get_irq(pdev, 0); >> if (ret <= 0) { >> - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret); > The change looks fine. Thanks, Tang Bin >
On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > In the function efm32_i2c_probe(),when get irq failed,the function > platform_get_irq() logs an error message,so remove redundant message > here. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com> Applied to for-next, thanks! Please fix the issues Uwe mentioned next time.
On Fri, May 22, 2020 at 05:04:18PM +0200, Wolfram Sang wrote: > On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > > In the function efm32_i2c_probe(),when get irq failed,the function > > platform_get_irq() logs an error message,so remove redundant message > > here. > > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com> > > Applied to for-next, thanks! Please fix the issues Uwe mentioned next > time. And try to match the subject line for the subsystem, i.e. for I2C: "i2c: <drivername>: <topic>"
diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c index a8c6323e7..4de31fae7 100644 --- a/drivers/i2c/busses/i2c-efm32.c +++ b/drivers/i2c/busses/i2c-efm32.c @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret <= 0) { - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret); if (!ret) ret = -EINVAL; return ret;