Message ID | 20200522035029.3022405-8-david@fromorbit.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | xfs: rework inode flushing to make inode reclaim fully asynchronous | expand |
On Fri, May 22, 2020 at 01:50:12PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@redhat.com> > > When we've emptied the buffer log item list, it does a list_del_init > on itself to reset it's pointers to itself. This is unnecessary as > the list is already empty at this point. I'm guessing this was a > bandaid for a iodone item leak or list corruption at some point in > the past, and we've carried it ever since. Get rid of it. It's not even a bandaid, it's merely an unnecessary wart from the conversion to list_head... that I RVBd. Sigh. Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > Signed-off-by: Dave Chinner <dchinner@redhat.com> > --- > fs/xfs/xfs_buf_item.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c > index c2e7d14e35c66..b7ffb117e141e 100644 > --- a/fs/xfs/xfs_buf_item.c > +++ b/fs/xfs/xfs_buf_item.c > @@ -459,7 +459,6 @@ xfs_buf_item_unpin( > if (bip->bli_flags & XFS_BLI_STALE_INODE) { > xfs_buf_do_callbacks(bp); > bp->b_log_item = NULL; > - list_del_init(&bp->b_li_list); > } else { > xfs_trans_ail_delete(lip, SHUTDOWN_LOG_IO_ERROR); > xfs_buf_item_relse(bp); > @@ -1165,7 +1164,6 @@ xfs_buf_run_callbacks( > > xfs_buf_do_callbacks(bp); > bp->b_log_item = NULL; > - list_del_init(&bp->b_li_list); > } > > /* > -- > 2.26.2.761.g0e0b3e54be >
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c index c2e7d14e35c66..b7ffb117e141e 100644 --- a/fs/xfs/xfs_buf_item.c +++ b/fs/xfs/xfs_buf_item.c @@ -459,7 +459,6 @@ xfs_buf_item_unpin( if (bip->bli_flags & XFS_BLI_STALE_INODE) { xfs_buf_do_callbacks(bp); bp->b_log_item = NULL; - list_del_init(&bp->b_li_list); } else { xfs_trans_ail_delete(lip, SHUTDOWN_LOG_IO_ERROR); xfs_buf_item_relse(bp); @@ -1165,7 +1164,6 @@ xfs_buf_run_callbacks( xfs_buf_do_callbacks(bp); bp->b_log_item = NULL; - list_del_init(&bp->b_li_list); } /*