| Message ID | 20200526224902.63975-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] block: blk-crypto-fallback: remove redundant initialization of variable err | expand |
On Tue, May 26, 2020 at 11:49:02PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > block/blk-crypto-fallback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c > index 74ab137ae3ba..6e49688a2d80 100644 > --- a/block/blk-crypto-fallback.c > +++ b/block/blk-crypto-fallback.c > @@ -529,7 +529,7 @@ static bool blk_crypto_fallback_inited; > static int blk_crypto_fallback_init(void) > { > int i; > - int err = -ENOMEM; > + int err; > > if (blk_crypto_fallback_inited) > return 0; Looks good, you can add: Reviewed-by: Eric Biggers <ebiggers@google.com> - Eric
On Tue, May 26, 2020 at 11:49:02PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > block/blk-crypto-fallback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c > index 74ab137ae3ba..6e49688a2d80 100644 > --- a/block/blk-crypto-fallback.c > +++ b/block/blk-crypto-fallback.c > @@ -529,7 +529,7 @@ static bool blk_crypto_fallback_inited; > static int blk_crypto_fallback_init(void) > { > int i; > - int err = -ENOMEM; > + int err; > > if (blk_crypto_fallback_inited) > return 0; > -- Looks good to me - you can add: Reviewed-by: Satya Tangirala <satyat@google.com> Thanks! > 2.25.1 >
On 5/26/20 4:49 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied, thanks.
diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index 74ab137ae3ba..6e49688a2d80 100644 --- a/block/blk-crypto-fallback.c +++ b/block/blk-crypto-fallback.c @@ -529,7 +529,7 @@ static bool blk_crypto_fallback_inited; static int blk_crypto_fallback_init(void) { int i; - int err = -ENOMEM; + int err; if (blk_crypto_fallback_inited) return 0;