| Message ID | 20200526210223.1672-3-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers/iio: Constify structs | expand |
On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > [External] > > ad5380_ext_info is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 12060 3280 192 15532 3cac drivers/iio/dac/ad5380.o > > After: > text data bss dec hex filename > 12252 3088 192 15532 3cac drivers/iio/dac/ad5380.o > Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/iio/dac/ad5380.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c > index b37e5675f716..04c74cc1a4ec 100644 > --- a/drivers/iio/dac/ad5380.c > +++ b/drivers/iio/dac/ad5380.c > @@ -240,7 +240,7 @@ static const struct iio_info ad5380_info = { > .write_raw = ad5380_write_raw, > }; > > -static struct iio_chan_spec_ext_info ad5380_ext_info[] = { > +static const struct iio_chan_spec_ext_info ad5380_ext_info[] = { > { > .name = "powerdown", > .read = ad5380_read_dac_powerdown,
On Wed, 27 May 2020 04:22:30 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > > [External] > > > > ad5380_ext_info is not modified and can be made const to allow the > > compiler to put it in read-only memory. > > > > Before: > > text data bss dec hex filename > > 12060 3280 192 15532 3cac drivers/iio/dac/ad5380.o > > > > After: > > text data bss dec hex filename > > 12252 3088 192 15532 3cac drivers/iio/dac/ad5380.o > > > > Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Applied. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > > --- > > drivers/iio/dac/ad5380.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c > > index b37e5675f716..04c74cc1a4ec 100644 > > --- a/drivers/iio/dac/ad5380.c > > +++ b/drivers/iio/dac/ad5380.c > > @@ -240,7 +240,7 @@ static const struct iio_info ad5380_info = { > > .write_raw = ad5380_write_raw, > > }; > > > > -static struct iio_chan_spec_ext_info ad5380_ext_info[] = { > > +static const struct iio_chan_spec_ext_info ad5380_ext_info[] = { > > { > > .name = "powerdown", > > .read = ad5380_read_dac_powerdown,
diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c index b37e5675f716..04c74cc1a4ec 100644 --- a/drivers/iio/dac/ad5380.c +++ b/drivers/iio/dac/ad5380.c @@ -240,7 +240,7 @@ static const struct iio_info ad5380_info = { .write_raw = ad5380_write_raw, }; -static struct iio_chan_spec_ext_info ad5380_ext_info[] = { +static const struct iio_chan_spec_ext_info ad5380_ext_info[] = { { .name = "powerdown", .read = ad5380_read_dac_powerdown,
ad5380_ext_info is not modified and can be made const to allow the compiler to put it in read-only memory. Before: text data bss dec hex filename 12060 3280 192 15532 3cac drivers/iio/dac/ad5380.o After: text data bss dec hex filename 12252 3088 192 15532 3cac drivers/iio/dac/ad5380.o Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/iio/dac/ad5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)