| Message ID | 1589555337-5498-17-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | RZ/G1H describe I2C, IIC, MMC0, SATA, AVB, RWDT and APMU nodes | expand |
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt b/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt > index 79b3c62..e42fd30 100644 > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt > @@ -5,6 +5,7 @@ Required properties: > fallback compatible string when compatible with the generic > version. > Examples with soctypes are: > + - "renesas,r8a7742-wdt" (RZ/G1H) > - "renesas,r8a7743-wdt" (RZ/G1M) > - "renesas,r8a7744-wdt" (RZ/G1N) > - "renesas,r8a7745-wdt" (RZ/G1E)
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > --- > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > 1 file changed, 1 insertion(+) Meanwhile in the DT tree, converting this schema landed. Can you prepare a version based on the schema. Rob
Hi Rob, On Wed, May 27, 2020 at 2:31 AM Rob Herring <robh@kernel.org> wrote: > > On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > > therefore add relevant documentation. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > > 1 file changed, 1 insertion(+) > > Meanwhile in the DT tree, converting this schema landed. Can you prepare > a version based on the schema. > This was kindly taken care by Stephen during merge in linux-next [1]. [1] https://lkml.org/lkml/2020/5/26/32 Cheers, --Prabhakar > Rob
On Wed, May 27, 2020 at 5:23 AM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > > Hi Rob, > > On Wed, May 27, 2020 at 2:31 AM Rob Herring <robh@kernel.org> wrote: > > > > On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > > > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > > > therefore add relevant documentation. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > Meanwhile in the DT tree, converting this schema landed. Can you prepare > > a version based on the schema. > > > This was kindly taken care by Stephen during merge in linux-next [1]. Yes, I'm aware of that. I was hoping for a better commit message which stands on its own (essentially the one here). Rob
Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 27 May 2020 15:38 > To: Lad, Prabhakar <prabhakar.csengg@gmail.com> > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Geert Uytterhoeven <geert+renesas@glider.be>; Jens Axboe > <axboe@kernel.dk>; Wolfram Sang <wsa+renesas@sang-engineering.com>; Ulf Hansson <ulf.hansson@linaro.org>; Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com>; David S. Miller <davem@davemloft.net>; Wim Van Sebroeck <wim@linux-watchdog.org>; > Guenter Roeck <linux@roeck-us.net>; open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers) <linux-ide@vger.kernel.org>; open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; Linux > I2C <linux-i2c@vger.kernel.org>; Linux MMC List <linux-mmc@vger.kernel.org>; netdev <netdev@vger.kernel.org>; Linux-Renesas <linux- > renesas-soc@vger.kernel.org>; Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org> > Subject: Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support > > On Wed, May 27, 2020 at 5:23 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > > > Hi Rob, > > > > On Wed, May 27, 2020 at 2:31 AM Rob Herring <robh@kernel.org> wrote: > > > > > > On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > > > > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > > > > therefore add relevant documentation. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > --- > > > > Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Meanwhile in the DT tree, converting this schema landed. Can you prepare > > > a version based on the schema. > > > > > This was kindly taken care by Stephen during merge in linux-next [1]. > > Yes, I'm aware of that. I was hoping for a better commit message which > stands on its own (essentially the one here). > As requested I have posted a patch [1]. [1] https://lore.kernel.org/patchwork/patch/1248597/ Cheers, --Prabhakar Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt b/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt index 79b3c62..e42fd30 100644 --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt @@ -5,6 +5,7 @@ Required properties: fallback compatible string when compatible with the generic version. Examples with soctypes are: + - "renesas,r8a7742-wdt" (RZ/G1H) - "renesas,r8a7743-wdt" (RZ/G1M) - "renesas,r8a7744-wdt" (RZ/G1N) - "renesas,r8a7745-wdt" (RZ/G1E)