| Message ID | 20200527153046.6172-7-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: designeware: Add Baikal-T1 System I2C support | expand |
On Wed, May 27, 2020 at 06:30:41PM +0300, Serge Semin wrote: > Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C > platform driver. It's a bit confusing to see it's config in the menu at > some separated place with no reference to the platform code. Let's move the > config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark > it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the > config menu will display the feature right below the DW I2C platform > driver item and will indent it to the right so signifying its belonging. Same comment as per previous version. > config I2C_DESIGNWARE_BAYTRAIL > bool "Intel Baytrail I2C semaphore support" > depends on ACPI > + depends on I2C_DESIGNWARE_PLATFORM > depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ > (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y) i.e. this change is not needed.
On Wed, May 27, 2020 at 06:55:33PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 06:30:41PM +0300, Serge Semin wrote: > > Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C > > platform driver. It's a bit confusing to see it's config in the menu at > > some separated place with no reference to the platform code. Let's move the > > config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark > > it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the > > config menu will display the feature right below the DW I2C platform > > driver item and will indent it to the right so signifying its belonging. > > Same comment as per previous version. > > > config I2C_DESIGNWARE_BAYTRAIL > > bool "Intel Baytrail I2C semaphore support" > > depends on ACPI > > + depends on I2C_DESIGNWARE_PLATFORM > > depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ > > (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y) > > i.e. this change is not needed. See my response to you in the previous version. -Sergey > > -- > With Best Regards, > Andy Shevchenko > >
On Wed, May 27, 2020 at 06:30:41PM +0300, Serge Semin wrote: > Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C > platform driver. It's a bit confusing to see it's config in the menu at > some separated place with no reference to the platform code. Let's move the > config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark > it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the > config menu will display the feature right below the DW I2C platform > driver item and will indent it to the right so signifying its belonging. After clarification Serge gave, it makes sense. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > > --- > > Changelog v3: > - Replace if-endif clause around the I2C_DESIGNWARE_BAYTRAIL config > with "depends on" operator. > --- > drivers/i2c/busses/Kconfig | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 7f92f6a96042..7cd279c36898 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -549,20 +549,10 @@ config I2C_DESIGNWARE_PLATFORM > This driver can also be built as a module. If so, the module > will be called i2c-designware-platform. > > -config I2C_DESIGNWARE_PCI > - tristate "Synopsys DesignWare PCI" > - depends on PCI > - select I2C_DESIGNWARE_CORE > - help > - If you say yes to this option, support will be included for the > - Synopsys DesignWare I2C adapter. Only master mode is supported. > - > - This driver can also be built as a module. If so, the module > - will be called i2c-designware-pci. > - > config I2C_DESIGNWARE_BAYTRAIL > bool "Intel Baytrail I2C semaphore support" > depends on ACPI > + depends on I2C_DESIGNWARE_PLATFORM > depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ > (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y) > help > @@ -572,6 +562,17 @@ config I2C_DESIGNWARE_BAYTRAIL > the platform firmware controlling it. You should say Y if running on > a BayTrail system using the AXP288. > > +config I2C_DESIGNWARE_PCI > + tristate "Synopsys DesignWare PCI" > + depends on PCI > + select I2C_DESIGNWARE_CORE > + help > + If you say yes to this option, support will be included for the > + Synopsys DesignWare I2C adapter. Only master mode is supported. > + > + This driver can also be built as a module. If so, the module > + will be called i2c-designware-pci. > + > config I2C_DIGICOLOR > tristate "Conexant Digicolor I2C driver" > depends on ARCH_DIGICOLOR || COMPILE_TEST > -- > 2.26.2 >
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 7f92f6a96042..7cd279c36898 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -549,20 +549,10 @@ config I2C_DESIGNWARE_PLATFORM This driver can also be built as a module. If so, the module will be called i2c-designware-platform. -config I2C_DESIGNWARE_PCI - tristate "Synopsys DesignWare PCI" - depends on PCI - select I2C_DESIGNWARE_CORE - help - If you say yes to this option, support will be included for the - Synopsys DesignWare I2C adapter. Only master mode is supported. - - This driver can also be built as a module. If so, the module - will be called i2c-designware-pci. - config I2C_DESIGNWARE_BAYTRAIL bool "Intel Baytrail I2C semaphore support" depends on ACPI + depends on I2C_DESIGNWARE_PLATFORM depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y) help @@ -572,6 +562,17 @@ config I2C_DESIGNWARE_BAYTRAIL the platform firmware controlling it. You should say Y if running on a BayTrail system using the AXP288. +config I2C_DESIGNWARE_PCI + tristate "Synopsys DesignWare PCI" + depends on PCI + select I2C_DESIGNWARE_CORE + help + If you say yes to this option, support will be included for the + Synopsys DesignWare I2C adapter. Only master mode is supported. + + This driver can also be built as a module. If so, the module + will be called i2c-designware-pci. + config I2C_DIGICOLOR tristate "Conexant Digicolor I2C driver" depends on ARCH_DIGICOLOR || COMPILE_TEST
Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some separated place with no reference to the platform code. Let's move the config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the config menu will display the feature right below the DW I2C platform driver item and will indent it to the right so signifying its belonging. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: linux-mips@vger.kernel.org Cc: devicetree@vger.kernel.org --- Changelog v3: - Replace if-endif clause around the I2C_DESIGNWARE_BAYTRAIL config with "depends on" operator. --- drivers/i2c/busses/Kconfig | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-)