Message ID | 20200527113700.3579-1-ardb@kernel.org (mailing list archive) |
---|---|
State | Mainlined, archived |
Headers | show |
Series | ACPI: GED: use correct trigger type field in _Exx / _Lxx handling | expand |
On Wed, May 27, 2020 at 1:37 PM Ard Biesheuvel <ardb@kernel.org> wrote: > > Commit ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler > methods") added a reference to the 'triggering' field of either the > normal or the extended ACPI IRQ resource struct, but inadvertently used > the wrong pointer in the latter case. Note that both pointers refer to the > same union, and the 'triggering' field appears at the same offset in both > struct types, so it currently happens to work by accident. But let's fix > it nonetheless > > Fixes: ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/acpi/evged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c > index 6d7a522952bf..ccd900690b6f 100644 > --- a/drivers/acpi/evged.c > +++ b/drivers/acpi/evged.c > @@ -94,7 +94,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares, > trigger = p->triggering; > } else { > gsi = pext->interrupts[0]; > - trigger = p->triggering; > + trigger = pext->triggering; > } > > irq = r.start; > -- Applied, thanks!
diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c index 6d7a522952bf..ccd900690b6f 100644 --- a/drivers/acpi/evged.c +++ b/drivers/acpi/evged.c @@ -94,7 +94,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares, trigger = p->triggering; } else { gsi = pext->interrupts[0]; - trigger = p->triggering; + trigger = pext->triggering; } irq = r.start;
Commit ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") added a reference to the 'triggering' field of either the normal or the extended ACPI IRQ resource struct, but inadvertently used the wrong pointer in the latter case. Note that both pointers refer to the same union, and the 'triggering' field appears at the same offset in both struct types, so it currently happens to work by accident. But let's fix it nonetheless Fixes: ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- drivers/acpi/evged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)