| Message ID | 20200528124742.28953-1-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests] access: disable phys-bits=36 for now | expand |
Paolo Bonzini <pbonzini@redhat.com> writes: > Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet, > it should not be enabled. Otherwise, all the pde.36 and pte.36 > fail and the test takes so long that it times out. > > Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > x86/unittests.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > index bf0d02e..d658bc8 100644 > --- a/x86/unittests.cfg > +++ b/x86/unittests.cfg > @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed > [access] > file = access.flat > arch = x86_64 > -extra_params = -cpu host,phys-bits=36 > +extra_params = -cpu host > > [smap] > file = smap.flat Works both VMX and SVM, thanks! Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote: > Paolo Bonzini <pbonzini@redhat.com> writes: > > > Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet, > > it should not be enabled. Otherwise, all the pde.36 and pte.36 > > fail and the test takes so long that it times out. > > > > Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > --- > > x86/unittests.cfg | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > > index bf0d02e..d658bc8 100644 > > --- a/x86/unittests.cfg > > +++ b/x86/unittests.cfg > > @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed > > [access] > > file = access.flat > > arch = x86_64 > > -extra_params = -cpu host,phys-bits=36 > > +extra_params = -cpu host > > > > [smap] > > file = smap.flat > > Works both VMX and SVM, thanks! What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work? I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken on CPUs with 52 bit PAs. Is it worth sending a patch to temporarily disable those tests if MAXPHYADDR=52?
On 28/05/20 23:45, Sean Christopherson wrote: > On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote: >> Paolo Bonzini <pbonzini@redhat.com> writes: >> >>> Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet, >>> it should not be enabled. Otherwise, all the pde.36 and pte.36 >>> fail and the test takes so long that it times out. >>> >>> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >>> --- >>> x86/unittests.cfg | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg >>> index bf0d02e..d658bc8 100644 >>> --- a/x86/unittests.cfg >>> +++ b/x86/unittests.cfg >>> @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed >>> [access] >>> file = access.flat >>> arch = x86_64 >>> -extra_params = -cpu host,phys-bits=36 >>> +extra_params = -cpu host >>> >>> [smap] >>> file = smap.flat >> >> Works both VMX and SVM, thanks! > > What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work? Mohammed was working on it, we should have it in 5.9. > I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken > on CPUs with 52 bit PAs. Is it worth sending a patch to temporarily > disable those tests if MAXPHYADDR=52? It's a QEMU bug that it does not enable host_phys_bits=on by default for "-cpu host". For now I'll tweak this patch to add it manually. Paolo
On Fri, 2020-05-29 at 10:48 +0200, Paolo Bonzini wrote: > On 28/05/20 23:45, Sean Christopherson wrote: > > On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote: > > > Paolo Bonzini <pbonzini@redhat.com> writes: > > > > > > > Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream > > > > yet, > > > > it should not be enabled. Otherwise, all the pde.36 and pte.36 > > > > fail and the test takes so long that it times out. > > > > > > > > Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> > > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > > > --- > > > > x86/unittests.cfg | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > > > > index bf0d02e..d658bc8 100644 > > > > --- a/x86/unittests.cfg > > > > +++ b/x86/unittests.cfg > > > > @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc- > > > > deadline -append tscdeadline_immed > > > > [access] > > > > file = access.flat > > > > arch = x86_64 > > > > -extra_params = -cpu host,phys-bits=36 > > > > +extra_params = -cpu host > > > > > > > > [smap] > > > > file = smap.flat > > > > > > Works both VMX and SVM, thanks! > > > > What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work? > > Mohammed was working on it, we should have it in 5.9. > > > I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken > > on CPUs with 52 bit PAs. Is it worth sending a patch to > > temporarily > > disable those tests if MAXPHYADDR=52? > It's a QEMU bug that it does not enable host_phys_bits=on by default > for > "-cpu host". For now I'll tweak this patch to add it manually. > > Paolo > I actually did send a fix earlier https://www.spinics.net/lists/kvm/msg215716.html
diff --git a/x86/unittests.cfg b/x86/unittests.cfg index bf0d02e..d658bc8 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed [access] file = access.flat arch = x86_64 -extra_params = -cpu host,phys-bits=36 +extra_params = -cpu host [smap] file = smap.flat
Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet, it should not be enabled. Otherwise, all the pde.36 and pte.36 fail and the test takes so long that it times out. Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- x86/unittests.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)