| Message ID | 20200526195123.29053-10-axboe@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for async buffered reads | expand |
On Tue, May 26, 2020 at 01:51:20PM -0600, Jens Axboe wrote: > XFS uses generic_file_read_iter(), which already supports this. > > Signed-off-by: Jens Axboe <axboe@kernel.dk> Er... I guess that looks ok? Assuming you've done enough qa on io_uring to be able to tell if this breaks anything, since touching the mm always feels murky to me: Acked-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 4b8bdecc3863..97f44fbf17f2 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1080,7 +1080,7 @@ xfs_file_open( > return -EFBIG; > if (XFS_FORCED_SHUTDOWN(XFS_M(inode->i_sb))) > return -EIO; > - file->f_mode |= FMODE_NOWAIT; > + file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC; > return 0; > } > > -- > 2.26.2 >
On 5/28/20 11:53 AM, Darrick J. Wong wrote: > On Tue, May 26, 2020 at 01:51:20PM -0600, Jens Axboe wrote: >> XFS uses generic_file_read_iter(), which already supports this. >> >> Signed-off-by: Jens Axboe <axboe@kernel.dk> > > Er... I guess that looks ok? Assuming you've done enough qa on > io_uring to be able to tell if this breaks anything, since touching the > mm always feels murky to me: > The mm bits should be fine, haven't seen anything odd in testing. And it's not like the mm changes are super complicated, I think they turned out pretty clean and straight forward. > Acked-by: Darrick J. Wong <darrick.wong@oracle.com> Thanks!
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 4b8bdecc3863..97f44fbf17f2 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1080,7 +1080,7 @@ xfs_file_open( return -EFBIG; if (XFS_FORCED_SHUTDOWN(XFS_M(inode->i_sb))) return -EIO; - file->f_mode |= FMODE_NOWAIT; + file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC; return 0; }
XFS uses generic_file_read_iter(), which already supports this. Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/xfs/xfs_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)