drm/i915/dsi: Dont forget to clean up the connector on error

Commit Message

Kasireddy, Vivek May 7, 2020, 1:01 a.m. UTC

During the DSI initialization setup, after instantiating the relevant
drm connector and encoder objects, the connector also needs to be
cleaned up along with the encoder if an error is encountered. The error
can happen due to a missing mode in the VBT or for other reasons.

Signed-off-by: Vivek Kasireddy <[e-mail]>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Souza, Jose June 2, 2020, 3:35 p.m. UTC | #1

On Tue, 2020-06-02 at 11:22 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/dsi: Dont forget to clean up the connector on error (rev3)
> URL   : https://patchwork.freedesktop.org/series/77011/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8568_full -> Patchwork_17838_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_17838_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_17838_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_17838_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_reloc@basic-cpu-read:
>     - shard-skl:          [PASS][1] -> [TIMEOUT][2] +2 similar issues
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl5/igt@[e-mail]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl9/igt@[e-mail]
> 
>   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
>     - shard-iclb:         [PASS][3] -> [FAIL][4]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-iclb6/igt@[e-mail]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-iclb1/igt@[e-mail]
> 
> 

Not related to this changes.
Pushed to dinq, thanks for the patch.

>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_17838_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>     - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +3 similar issues
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl7/igt@[e-mail]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl4/igt@[e-mail]
>     - shard-skl:          [PASS][7] -> [INCOMPLETE][8] ([i915#648] / [i915#69])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl9/igt@[e-mail]
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl6/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#108145] / [i915#265]) +1 similar issue
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl5/igt@[e-mail]
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl4/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_cursor_render:
>     - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109441]) +1 similar issue
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
> 
>   * igt@kms_vblank@pipe-c-wait-idle-hang:
>     - shard-apl:          [PASS][13] -> [TIMEOUT][14] ([i915#1635]) +2 similar issues
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl8/igt@[e-mail]
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl6/igt@[e-mail]
> 
>   
> #### Possible fixes ####
> 
>   * {igt@gem_exec_schedule@implicit-write-read@rcs0}:
>     - shard-snb:          [INCOMPLETE][15] ([i915#82]) -> [PASS][16]
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-snb6/igt@gem_exec_schedule@[e-mail]
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-snb5/igt@gem_exec_schedule@[e-mail]
> 
>   * igt@gem_workarounds@suspend-resume-fd:
>     - shard-apl:          [INCOMPLETE][17] -> [PASS][18]
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl8/igt@[e-mail]
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl6/igt@[e-mail]
> 
>   * {igt@kms_flip@flip-vs-suspend@a-dp1}:
>     - shard-apl:          [DMESG-WARN][19] ([i915#180]) -> [PASS][20] +3 similar issues
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl1/igt@kms_flip@[e-mail]
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl7/igt@kms_flip@[e-mail]
> 
>   * {igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1}:
>     - shard-skl:          [FAIL][21] ([i915#1928]) -> [PASS][22]
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl5/igt@kms_flip@[e-mail]
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl9/igt@kms_flip@[e-mail]
> 
>   * igt@kms_hdr@bpc-switch-dpms:
>     - shard-skl:          [FAIL][23] ([i915#1188]) -> [PASS][24] +1 similar issue
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl7/igt@[e-mail]
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl2/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          [FAIL][25] ([fdo#108145] / [i915#265]) -> [PASS][26]
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl3/igt@[e-mail]
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl3/igt@[e-mail]
> 
>   * igt@kms_psr@no_drrs:
>     - shard-iclb:         [FAIL][27] ([i915#173]) -> [PASS][28]
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-iclb1/igt@kms_psr@no_drrs.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-iclb8/igt@kms_psr@no_drrs.html
> 
>   * igt@kms_psr@psr2_primary_mmap_cpu:
>     - shard-iclb:         [SKIP][29] ([fdo#109441]) -> [PASS][30] +2 similar issues
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
> 
>   * igt@kms_vblank@pipe-a-ts-continuation-suspend:
>     - shard-kbl:          [DMESG-WARN][31] ([i915#180]) -> [PASS][32] +1 similar issue
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-kbl1/igt@[e-mail]
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-kbl4/igt@[e-mail]
>     - shard-skl:          [INCOMPLETE][33] ([i915#69]) -> [PASS][34] +1 similar issue
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-skl3/igt@[e-mail]
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-skl10/igt@[e-mail]
> 
>   
> #### Warnings ####
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-tglb:         [SKIP][35] ([i915#468]) -> [FAIL][36] ([i915#1899])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-tglb2/igt@[e-mail]
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-tglb3/igt@[e-mail]
> 
>   * igt@kms_content_protection@atomic-dpms:
>     - shard-apl:          [TIMEOUT][37] ([i915#1319] / [i915#1635]) -> [TIMEOUT][38] ([i915#1319])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl8/igt@[e-mail]
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl6/igt@[e-mail]
> 
>   * igt@kms_content_protection@srm:
>     - shard-apl:          [FAIL][39] ([fdo#110321]) -> [TIMEOUT][40] ([i915#1319] / [i915#1635])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl4/igt@[e-mail]
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl1/igt@[e-mail]
> 
>   * igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
>     - shard-glk:          [DMESG-WARN][41] ([i915#1926]) -> [DMESG-FAIL][42] ([i915#1925] / [i915#1926])
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-glk4/igt@[e-mail]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-glk4/igt@[e-mail]
> 
>   * igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
>     - shard-glk:          [DMESG-WARN][43] ([i915#1926]) -> [DMESG-WARN][44] ([i915#1927])
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-glk9/igt@[e-mail]
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-glk9/igt@[e-mail]
> 
>   * igt@kms_fbcon_fbt@fbc:
>     - shard-apl:          [FAIL][45] ([i915#1525] / [i915#95]) -> [FAIL][46] ([i915#1525])
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8568/shard-apl6/igt@[e-mail]
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/shard-apl8/igt@[e-mail]
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
>   [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
>   [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
>   [i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
>   [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
>   [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899
>   [i915#1925]: https://gitlab.freedesktop.org/drm/intel/issues/1925
>   [i915#1926]: https://gitlab.freedesktop.org/drm/intel/issues/1926
>   [i915#1927]: https://gitlab.freedesktop.org/drm/intel/issues/1927
>   [i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
>   [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
>   [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
>   [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
>   [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
>   [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
>   [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> 
> 
> Participating hosts (11 -> 11)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_8568 -> Patchwork_17838
> 
>   CI-20190529: 20190529
>   CI_DRM_8568: 124bafc80c3ce62fc61b8eabb2657c87424b999b @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5690: bea881189520a9cccbb1c1cb454ac5b6fdaea40e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_17838: a30b3a0e479eb9f2f48cf8a737656c9bbb64c15a @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17838/index.html
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 4fec5bd64920..f93f72463df5 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1954,6 +1954,7 @@  void icl_dsi_init(struct drm_i915_private *dev_priv)
 	return;
 
 err:
+	drm_connector_cleanup(connector);
 	drm_encoder_cleanup(&encoder->base);
 	kfree(intel_dsi);
 	kfree(intel_connector);