[v2,00/12] ASoC: soc-component: collect component functions

Message

Kuninori Morimoto June 4, 2020, 8:05 a.m. UTC

Hi Mark

We have soc-component.c now, but still many component related
functions are implemented many place.
This patch-set collect these into soc-component.c.

v1 -> v2
	- remove soc-compress.c exchange
	  (But I have plan to repost it)
	- fixup loop break issue on some functions
	- direct return on some functions

Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (12):
  ASoC: soc-component: add soc_component_pin() and share code
  ASoC: soc-component: move snd_soc_component_xxx_regmap() to soc-component
  ASoC: soc-component: move snd_soc_component_initialize() to soc-component.c
  ASoC: soc-component: add soc_component_err()
  ASoC: soc-component: add snd_soc_pcm_component_prepare()
  ASoC: soc-component: add snd_soc_pcm_component_hw_params()
  ASoC: soc-component: add snd_soc_pcm_component_hw_free()
  ASoC: soc-component: add snd_soc_pcm_component_trigger()
  ASoC: soc-component: add snd_soc_component_init()
  ASoC: soc-component: merge soc-io.c into soc-component.c
  ASoC: soc-component: merge soc_pcm_trigger_start/stop()
  ASoC: soc-component: tidyup Copyright

 include/sound/soc-component.h |  29 +-
 sound/soc/Makefile            |   2 +-
 sound/soc/soc-component.c     | 666 ++++++++++++++++++++++++----------
 sound/soc/soc-core.c          | 102 +-----
 sound/soc/soc-io.c            | 202 -----------
 sound/soc/soc-pcm.c           | 114 ++----
 6 files changed, 531 insertions(+), 584 deletions(-)
 delete mode 100644 sound/soc/soc-io.c

Comments

Ranjani Sridharan June 4, 2020, 8:29 p.m. UTC | #1

On Thu, 2020-06-04 at 17:05 +0900, Kuninori Morimoto wrote:
> Hi Mark
> 
> We have soc-component.c now, but still many component related
> functions are implemented many place.
> This patch-set collect these into soc-component.c.
> 
> v1 -> v2
> 	- remove soc-compress.c exchange
> 	  (But I have plan to repost it)
> 	- fixup loop break issue on some functions
> 	- direct return on some functions
> 
> Link: 
> https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (12):
>   ASoC: soc-component: add soc_component_pin() and share code
>   ASoC: soc-component: move snd_soc_component_xxx_regmap() to soc-
> component
>   ASoC: soc-component: move snd_soc_component_initialize() to soc-
> component.c
>   ASoC: soc-component: add soc_component_err()
>   ASoC: soc-component: add snd_soc_pcm_component_prepare()
>   ASoC: soc-component: add snd_soc_pcm_component_hw_params()
>   ASoC: soc-component: add snd_soc_pcm_component_hw_free()
>   ASoC: soc-component: add snd_soc_pcm_component_trigger()
>   ASoC: soc-component: add snd_soc_component_init()
>   ASoC: soc-component: merge soc-io.c into soc-component.c
>   ASoC: soc-component: merge soc_pcm_trigger_start/stop()
>   ASoC: soc-component: tidyup Copyright
LGTM, Morimoto-san.

Reviewed-by: Ranjani Sridharan <[e-mail]>

Mark Brown June 15, 2020, 11:39 p.m. UTC | #2

On 04 Jun 2020 17:05:39 +0900, Kuninori Morimoto wrote:
> We have soc-component.c now, but still many component related
> functions are implemented many place.
> This patch-set collect these into soc-component.c.
> 
> v1 -> v2
> 	- remove soc-compress.c exchange
> 	  (But I have plan to repost it)
> 	- fixup loop break issue on some functions
> 	- direct return on some functions
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/12] ASoC: soc-component: add soc_component_pin() and share code
        commit: 4ca8701ee3106943c84d011c86a7ae41aff72e17
[02/12] ASoC: soc-component: move snd_soc_component_xxx_regmap() to soc-component
        commit: c7d75b5938e38a48e5fdac44f88fc5882f1f7bed
[03/12] ASoC: soc-component: move snd_soc_component_initialize() to soc-component.c
        commit: 536aba1dd4939bf647f5d182d4f101ae548e6505
[04/12] ASoC: soc-component: add soc_component_err()
        commit: e2329eeba45fdad5eeb2bec5c61f8cefbee69cb8
[05/12] ASoC: soc-component: add snd_soc_pcm_component_prepare()
        commit: 4f39514f36980a4b20a754a5d51486a5999c8380
[06/12] ASoC: soc-component: add snd_soc_pcm_component_hw_params()
        commit: e1bafa828e3a0622ac24d238e00937f3059ed585
[07/12] ASoC: soc-component: add snd_soc_pcm_component_hw_free()
        commit: 047511198639649bdaacb1a34d9691429ccc5698
[08/12] ASoC: soc-component: add snd_soc_pcm_component_trigger()
        commit: 32fd120475c1b8a83d28bfedc2b95ec981fbb809
[09/12] ASoC: soc-component: add snd_soc_component_init()
        commit: 257c4dac8b7877c865e734533b5f62769c64afb6
[10/12] ASoC: soc-component: merge soc-io.c into soc-component.c
        commit: 460b42d162e3cf634586999e6a84e74ca52e626d
[11/12] ASoC: soc-component: merge soc_pcm_trigger_start/stop()
        commit: 836367be289d5b130769fd7c46172557e614a148
[12/12] ASoC: soc-component: tidyup Copyright
        commit: 45108214dbfdba4a07061d2a4db6dc12475049f2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark