| Message ID | 20200603175759.19948-8-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduction of the generic ECC framework | expand |
On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote: > Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. > The former is here to force software correction, the latter prevents > any correction to happen. > > These properties (along with nand-ecc-engine) are supposed to be more > accurate than the current nand-ecc-modes wich is very misleading and > very often people think it is mandatory while the core should be > relied upon to decide which correction to handle. > > nand-ecc-mode was already inacurate, but it becomes totally > problematic with setups where there are several hardware engines. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index 0969d2e6720b..a3750978ebb8 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -68,6 +68,12 @@ patternProperties: > 3/ The ECC engine is external, in this case the phandle should > reference the specific ECC engine node. > > + nand-use-soft-ecc-engine: true > + description: Use a software ECC engine. Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't be both a boolean and a map (aka schema, aka dict). nand-use-soft-ecc-engine: type: boolean description: ... > + > + nand-no-ecc-engine: true > + description: Do not use any ECC correction. > + > nand-ecc-placement: > allOf: > - $ref: /schemas/types.yaml#/definitions/string > -- > 2.20.1 >
Hi Rob, Rob Herring <robh@kernel.org> wrote on Thu, 4 Jun 2020 17:08:04 -0600: > On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote: > > Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. > > The former is here to force software correction, the latter prevents > > any correction to happen. > > > > These properties (along with nand-ecc-engine) are supposed to be more > > accurate than the current nand-ecc-modes wich is very misleading and > > very often people think it is mandatory while the core should be > > relied upon to decide which correction to handle. > > > > nand-ecc-mode was already inacurate, but it becomes totally > > problematic with setups where there are several hardware engines. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > index 0969d2e6720b..a3750978ebb8 100644 > > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > @@ -68,6 +68,12 @@ patternProperties: > > 3/ The ECC engine is external, in this case the phandle should > > reference the specific ECC engine node. > > > > + nand-use-soft-ecc-engine: true > > + description: Use a software ECC engine. > > Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't > be both a boolean and a map (aka schema, aka dict). > > nand-use-soft-ecc-engine: > type: boolean > description: ... > Ok, I might have been inspired from this line in example-schema.yaml: interrupt-controller: true # The core checks this is a boolean, so just have to list it here to be # valid for this binding. Thanks for the review, I'll correct it. Cheers, Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 0969d2e6720b..a3750978ebb8 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -68,6 +68,12 @@ patternProperties: 3/ The ECC engine is external, in this case the phandle should reference the specific ECC engine node. + nand-use-soft-ecc-engine: true + description: Use a software ECC engine. + + nand-no-ecc-engine: true + description: Do not use any ECC correction. + nand-ecc-placement: allOf: - $ref: /schemas/types.yaml#/definitions/string
Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. The former is here to force software correction, the latter prevents any correction to happen. These properties (along with nand-ecc-engine) are supposed to be more accurate than the current nand-ecc-modes wich is very misleading and very often people think it is mandatory while the core should be relied upon to decide which correction to handle. nand-ecc-mode was already inacurate, but it becomes totally problematic with setups where there are several hardware engines. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+)