iio: make iio_device_get_drvdata take a const struct iio_dev *.

Commit Message

Jonathan Cameron May 21, 2020, 5:53 p.m. UTC

From: Jonathan Cameron <[e-mail]>

As this just calls dev_get_drvdata underneath which is happy with
a const struct device * we should change and avoid potentially
casting away a const in order to then put it back again.

Signed-off-by: Jonathan Cameron <[e-mail]>
Cc: Jean-Baptiste Maneyrol <[e-mail]>
---
 include/linux/iio/iio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron June 6, 2020, 2:24 p.m. UTC | #1

On Tue, 2 Jun 2020 07:39:52 +0000
Jean-Baptiste Maneyrol <[e-mail]> wrote:

> Hi Jonathan,
> 
> simple and perfect.
> 
> Thanks,
> JB
> 
> Reviewed-by: Jean-Baptiste Maneyrol <[e-mail]>

Applied.


Thanks,

Jonathan

> 
> ________________________________
> From: [e-mail] <[e-mail]>
> Sent: Thursday, May 21, 2020 19:53
> To: [e-mail] <[e-mail]>
> Cc: Jonathan Cameron <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> Subject: [PATCH] iio: make iio_device_get_drvdata take a const struct iio_dev *.
> 
>  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> From: Jonathan Cameron <[e-mail]>
> 
> As this just calls dev_get_drvdata underneath which is happy with
> a const struct device * we should change and avoid potentially
> casting away a const in order to then put it back again.
> 
> Signed-off-by: Jonathan Cameron <[e-mail]>
> Cc: Jean-Baptiste Maneyrol <[e-mail]>
> ---
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index a1be82e74c93..e846a0a7001e 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -669,7 +669,7 @@ static inline void iio_device_set_drvdata(struct iio_dev *indio_dev, void *data)
>   *
>   * Returns the data previously set with iio_device_set_drvdata()
>   */
> -static inline void *iio_device_get_drvdata(struct iio_dev *indio_dev)
> +static inline void *iio_device_get_drvdata(const struct iio_dev *indio_dev)
>  {
>          return dev_get_drvdata(&indio_dev->dev);
>  }
> --
> 2.26.2
>

Jean-Baptiste Maneyrol June 8, 2020, 9:43 a.m. UTC | #2

Hello Jonathan,

thanks a lot, but I'm currently not able to find this patch in iio git repository, neither in testing or fixes-togreg branches.

Is there something I am missing or I just have to wait more ?

Thanks,
JB


From: [e-mail] <[e-mail]> on behalf of Jonathan Cameron <[e-mail]>
Sent: Saturday, June 6, 2020 16:24
To: Jean-Baptiste Maneyrol <[e-mail]>
Cc: [e-mail] <[e-mail]>; Jonathan Cameron <[e-mail]>
Subject: Re: [PATCH] iio: make iio_device_get_drvdata take a const struct iio_dev *. 
 
 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.

On Tue, 2 Jun 2020 07:39:52 +0000
Jean-Baptiste Maneyrol <[e-mail]> wrote:

> Hi Jonathan,
> 
> simple and perfect.
> 
> Thanks,
> JB
> 
> Reviewed-by: Jean-Baptiste Maneyrol <[e-mail]>

Applied.


Thanks,

Jonathan

> 
> ________________________________
> From: [e-mail] <[e-mail]>
> Sent: Thursday, May 21, 2020 19:53
> To: [e-mail] <[e-mail]>
> Cc: Jonathan Cameron <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> Subject: [PATCH] iio: make iio_device_get_drvdata take a const struct iio_dev *.
> 
>  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> From: Jonathan Cameron <[e-mail]>
> 
> As this just calls dev_get_drvdata underneath which is happy with
> a const struct device * we should change and avoid potentially
> casting away a const in order to then put it back again.
> 
> Signed-off-by: Jonathan Cameron <[e-mail]>
> Cc: Jean-Baptiste Maneyrol <[e-mail]>
> ---
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index a1be82e74c93..e846a0a7001e 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -669,7 +669,7 @@ static inline void iio_device_set_drvdata(struct iio_dev *indio_dev, void *data)
>   *
>   * Returns the data previously set with iio_device_set_drvdata()
>   */
> -static inline void *iio_device_get_drvdata(struct iio_dev *indio_dev)
> +static inline void *iio_device_get_drvdata(const struct iio_dev *indio_dev)
>  {
>          return dev_get_drvdata(&indio_dev->dev);
>  }
> --
> 2.26.2
>

Jonathan Cameron June 14, 2020, 11:33 a.m. UTC | #3

On Mon, 8 Jun 2020 09:43:26 +0000
Jean-Baptiste Maneyrol <[e-mail]> wrote:

> Hello Jonathan,
> 
> thanks a lot, but I'm currently not able to find this patch in iio git repository, neither in testing or fixes-togreg branches.
> 
> Is there something I am missing or I just have to wait more ?

I forgot to push out.  Did so mid week after I saw another
email saying things weren't there that should have been.

Given I've just rebased testing, I won't push out a togreg
branch until at least mid week to let the build reports come
in.

Thanks,

Jonathan

> 
> Thanks,
> JB
> 
> 
> From: [e-mail] <[e-mail]> on behalf of Jonathan Cameron <[e-mail]>
> Sent: Saturday, June 6, 2020 16:24
> To: Jean-Baptiste Maneyrol <[e-mail]>
> Cc: [e-mail] <[e-mail]>; Jonathan Cameron <[e-mail]>
> Subject: Re: [PATCH] iio: make iio_device_get_drvdata take a const struct iio_dev *. 
>  
>  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> On Tue, 2 Jun 2020 07:39:52 +0000
> Jean-Baptiste Maneyrol <[e-mail]> wrote:
> 
> > Hi Jonathan,
> > 
> > simple and perfect.
> > 
> > Thanks,
> > JB
> > 
> > Reviewed-by: Jean-Baptiste Maneyrol <[e-mail]>  
> 
> Applied.
> 
> 
> Thanks,
> 
> Jonathan
> 
> > 
> > ________________________________
> > From: [e-mail] <[e-mail]>
> > Sent: Thursday, May 21, 2020 19:53
> > To: [e-mail] <[e-mail]>
> > Cc: Jonathan Cameron <[e-mail]>; Jean-Baptiste Maneyrol <[e-mail]>
> > Subject: [PATCH] iio: make iio_device_get_drvdata take a const struct iio_dev *.
> > 
> >  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
> > 
> > From: Jonathan Cameron <[e-mail]>
> > 
> > As this just calls dev_get_drvdata underneath which is happy with
> > a const struct device * we should change and avoid potentially
> > casting away a const in order to then put it back again.
> > 
> > Signed-off-by: Jonathan Cameron <[e-mail]>
> > Cc: Jean-Baptiste Maneyrol <[e-mail]>
> > ---
> >  include/linux/iio/iio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index a1be82e74c93..e846a0a7001e 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -669,7 +669,7 @@ static inline void iio_device_set_drvdata(struct iio_dev *indio_dev, void *data)
> >   *
> >   * Returns the data previously set with iio_device_set_drvdata()
> >   */
> > -static inline void *iio_device_get_drvdata(struct iio_dev *indio_dev)
> > +static inline void *iio_device_get_drvdata(const struct iio_dev *indio_dev)
> >  {
> >          return dev_get_drvdata(&indio_dev->dev);
> >  }
> > --
> > 2.26.2
> >

Patch

diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index a1be82e74c93..e846a0a7001e 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -669,7 +669,7 @@  static inline void iio_device_set_drvdata(struct iio_dev *indio_dev, void *data)
  *
  * Returns the data previously set with iio_device_set_drvdata()
  */
-static inline void *iio_device_get_drvdata(struct iio_dev *indio_dev)
+static inline void *iio_device_get_drvdata(const struct iio_dev *indio_dev)
 {
 	return dev_get_drvdata(&indio_dev->dev);
 }