| Message ID | 20200604143902.56021-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 2ef5612391f0a7a631c42a8afc867095b49a1992 |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [next] RDMA/mlx5: remove duplicated assignment to resp.response_length | expand |
On Thu, Jun 04, 2020 at 03:39:02PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The assignment to resp.response_length is never read since it is being > updated again on the next statement. The assignment is redundant so > removed it. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 2 -- > 1 file changed, 2 deletions(-) > Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, Jun 04, 2020 at 03:39:02PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The assignment to resp.response_length is never read since it is being > updated again on the next statement. The assignment is redundant so > removed it. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Leon Romanovsky <leonro@mellanox.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 2 -- > 1 file changed, 2 deletions(-) Applied to for-rc, with a fixes line Thanks, Jason
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 81bf6b975e0e..d61ca85033de 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -4162,8 +4162,6 @@ static int mlx5_ib_modify_dct(struct ib_qp *ibqp, struct ib_qp_attr *attr, if (udata->outlen < min_resp_len) return -EINVAL; - resp.response_length = min_resp_len; - /* * If we don't have enough space for the ECE options, * simply indicate it with resp.response_length.