| Message ID | 20200609162700.953260-12-adrian.ratiu@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Genericize DW MIPI DSI bridge and add i.MX 6 driver | expand |
On Tue, Jun 9, 2020 at 6:25 PM Adrian Ratiu <adrian.ratiu@collabora.com> wrote: > > This documents the longer-term plan to cleanup the dw-mipi-dsi bridge > based drivers after the regmap refactor and i.MX6 driver have landed. > > The goal is to get the entire bridge logic in one place and continue > the refactorings under the drm/bridge tree. > > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Boris Brezillon <boris.brezillon@collabora.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> This cc's the world, but not dri-devel. Can you pls resubmit with that added? Thanks, Daniel > --- > Documentation/gpu/todo.rst | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 658b52f7ffc6c..2b142980a4b16 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -548,6 +548,31 @@ See drivers/gpu/drm/amd/display/TODO for tasks. > > Contact: Harry Wentland, Alex Deucher > > +Reorganize dw-mipi-dsi bridge-based host-controller drivers > +----------------------------------------------------------- > + > +The Synopsys DW MIPI DSI bridge is used by a number of SoC platform drivers > +(STM, Rockchip, i.MX) which don't cleanly encapsulate their bridge logic which > +gets split between the Synopsys bridge (drm/bridge/synopsys/dw-mipi-dsi.c) and > +platform drivers like drm/imx/dw_mipi_dsi-imx6.c by passing around the bridge > +configuration regmap, creating new bridges / daisy chaining in platform drivers, > +duplicating encoder creation, having too much encoder logic instead of using the > +simple encoder interface and so on. > + > +The goal of this rework is to make the dw-mipi-dsi driver a better encapsulated > +bridge by moving all bridge-related logic under drm/bridge, including the SoC > +bindings which chain to the core Synopsys code under drm/bridge/dw-mipi-dsi/ > +from which they can be further consolidated and cleaned up. > + > +If this goal proves to be impossible then drm_bridge might not be the correct > +abstraction for these host controllers and unifying their logic into a helper > +library encapsulating a drm_encoder might be more desirable, in other words to > +move away from drm_bridge entirely. > + > +Contact: Adrian Ratiu, Daniel Vetter, Laurent Pinchart > + > +Level: Intermediate > + > Bootsplash > ========== > > -- > 2.27.0 >
On Tue, 09 Jun 2020, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > On Tue, Jun 9, 2020 at 6:25 PM Adrian Ratiu > <adrian.ratiu@collabora.com> wrote: >> >> This documents the longer-term plan to cleanup the dw-mipi-dsi >> bridge based drivers after the regmap refactor and i.MX6 driver >> have landed. >> >> The goal is to get the entire bridge logic in one place and >> continue the refactorings under the drm/bridge tree. >> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: >> Boris Brezillon <boris.brezillon@collabora.com> Cc: Sam >> Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter >> <daniel.vetter@ffwll.ch> Signed-off-by: Adrian Ratiu >> <adrian.ratiu@collabora.com> > > This cc's the world, but not dri-devel. Can you pls resubmit > with that added? Yes, sorry about omitting dri-devel, it was unintentional. Will resubmit the same version. Adrian > > Thanks, Daniel > >> --- >> Documentation/gpu/todo.rst | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst >> index 658b52f7ffc6c..2b142980a4b16 100644 >> --- a/Documentation/gpu/todo.rst >> +++ b/Documentation/gpu/todo.rst >> @@ -548,6 +548,31 @@ See drivers/gpu/drm/amd/display/TODO for tasks. >> >> Contact: Harry Wentland, Alex Deucher >> >> +Reorganize dw-mipi-dsi bridge-based host-controller drivers >> +----------------------------------------------------------- >> + >> +The Synopsys DW MIPI DSI bridge is used by a number of SoC platform drivers >> +(STM, Rockchip, i.MX) which don't cleanly encapsulate their bridge logic which >> +gets split between the Synopsys bridge (drm/bridge/synopsys/dw-mipi-dsi.c) and >> +platform drivers like drm/imx/dw_mipi_dsi-imx6.c by passing around the bridge >> +configuration regmap, creating new bridges / daisy chaining in platform drivers, >> +duplicating encoder creation, having too much encoder logic instead of using the >> +simple encoder interface and so on. >> + >> +The goal of this rework is to make the dw-mipi-dsi driver a better encapsulated >> +bridge by moving all bridge-related logic under drm/bridge, including the SoC >> +bindings which chain to the core Synopsys code under drm/bridge/dw-mipi-dsi/ >> +from which they can be further consolidated and cleaned up. >> + >> +If this goal proves to be impossible then drm_bridge might not be the correct >> +abstraction for these host controllers and unifying their logic into a helper >> +library encapsulating a drm_encoder might be more desirable, in other words to >> +move away from drm_bridge entirely. >> + >> +Contact: Adrian Ratiu, Daniel Vetter, Laurent Pinchart >> + >> +Level: Intermediate >> + >> Bootsplash >> ========== >> >> -- >> 2.27.0 >> > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 658b52f7ffc6c..2b142980a4b16 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -548,6 +548,31 @@ See drivers/gpu/drm/amd/display/TODO for tasks. Contact: Harry Wentland, Alex Deucher +Reorganize dw-mipi-dsi bridge-based host-controller drivers +----------------------------------------------------------- + +The Synopsys DW MIPI DSI bridge is used by a number of SoC platform drivers +(STM, Rockchip, i.MX) which don't cleanly encapsulate their bridge logic which +gets split between the Synopsys bridge (drm/bridge/synopsys/dw-mipi-dsi.c) and +platform drivers like drm/imx/dw_mipi_dsi-imx6.c by passing around the bridge +configuration regmap, creating new bridges / daisy chaining in platform drivers, +duplicating encoder creation, having too much encoder logic instead of using the +simple encoder interface and so on. + +The goal of this rework is to make the dw-mipi-dsi driver a better encapsulated +bridge by moving all bridge-related logic under drm/bridge, including the SoC +bindings which chain to the core Synopsys code under drm/bridge/dw-mipi-dsi/ +from which they can be further consolidated and cleaned up. + +If this goal proves to be impossible then drm_bridge might not be the correct +abstraction for these host controllers and unifying their logic into a helper +library encapsulating a drm_encoder might be more desirable, in other words to +move away from drm_bridge entirely. + +Contact: Adrian Ratiu, Daniel Vetter, Laurent Pinchart + +Level: Intermediate + Bootsplash ==========
This documents the longer-term plan to cleanup the dw-mipi-dsi bridge based drivers after the regmap refactor and i.MX6 driver have landed. The goal is to get the entire bridge logic in one place and continue the refactorings under the drm/bridge tree. Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Boris Brezillon <boris.brezillon@collabora.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> --- Documentation/gpu/todo.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)