| Message ID | 20200604064219.436242-1-david@gibson.dropbear.id.au (mailing list archive) |
|---|---|
| Headers | show |
| Series | AMD SEV: Cleanup state handling | expand |
On 04/06/20 08:42, David Gibson wrote: > This series has an assortment of cleanups to the AMD SEV memory > encryption code. Amongst other things it: > * Removes the confusion between struct SEVState and enum SevState > * Reduces use of global variables > * Unifies some ad-hoc structures with an existing QOM object > > I made these changes along the way to building a framework for common > handling of mechanisms for protecting guests from compromised hosts > (such as AMD SEV, IBM's PEF and others). However, I think the changes > make sense on their own, so I'm sending them for inclusion now, while > finishing the polish on the rest of those patches. > > Please apply. > > David Gibson (9): > target/i386: sev: Remove unused QSevGuestInfoClass > target/i386: sev: Move local structure definitions into .c file > target/i386: sev: Rename QSevGuestInfo > target/i386: sev: Embed SEVState in SevGuestState > target/i386: sev: Partial cleanup to sev_state global > target/i386: sev: Remove redundant cbitpos and reduced_phys_bits > fields > target/i386: sev: Remove redundant policy field > target/i386: sev: Remove redundant handle field > target/i386: sev: Unify SEVState and SevGuestState > > target/i386/sev.c | 257 +++++++++++++++++++++++------------------ > target/i386/sev_i386.h | 49 -------- > 2 files changed, 143 insertions(+), 163 deletions(-) > Queued, thanks. Paolo
On Thu, Jun 04, 2020 at 08:37:47PM +0200, Paolo Bonzini wrote: > On 04/06/20 08:42, David Gibson wrote: > > This series has an assortment of cleanups to the AMD SEV memory > > encryption code. Amongst other things it: > > * Removes the confusion between struct SEVState and enum SevState > > * Reduces use of global variables > > * Unifies some ad-hoc structures with an existing QOM object > > > > I made these changes along the way to building a framework for common > > handling of mechanisms for protecting guests from compromised hosts > > (such as AMD SEV, IBM's PEF and others). However, I think the changes > > make sense on their own, so I'm sending them for inclusion now, while > > finishing the polish on the rest of those patches. > > > > Please apply. > > > > David Gibson (9): > > target/i386: sev: Remove unused QSevGuestInfoClass > > target/i386: sev: Move local structure definitions into .c file > > target/i386: sev: Rename QSevGuestInfo > > target/i386: sev: Embed SEVState in SevGuestState > > target/i386: sev: Partial cleanup to sev_state global > > target/i386: sev: Remove redundant cbitpos and reduced_phys_bits > > fields > > target/i386: sev: Remove redundant policy field > > target/i386: sev: Remove redundant handle field > > target/i386: sev: Unify SEVState and SevGuestState > > > > target/i386/sev.c | 257 +++++++++++++++++++++++------------------ > > target/i386/sev_i386.h | 49 -------- > > 2 files changed, 143 insertions(+), 163 deletions(-) > > Queued, thanks. Do you have a best guess at when these might merge? I have another series based on this one I'd like to move forward with.
On 10/06/20 07:04, David Gibson wrote: >>> target/i386/sev.c | 257 +++++++++++++++++++++++------------------ >>> target/i386/sev_i386.h | 49 -------- >>> 2 files changed, 143 insertions(+), 163 deletions(-) >> Queued, thanks. > Do you have a best guess at when these might merge? I have another > series based on this one I'd like to move forward with. Sorry, I am seeing a hang with my pull request that I have had issues bisecting. Paolo
This series has an assortment of cleanups to the AMD SEV memory encryption code. Amongst other things it: * Removes the confusion between struct SEVState and enum SevState * Reduces use of global variables * Unifies some ad-hoc structures with an existing QOM object I made these changes along the way to building a framework for common handling of mechanisms for protecting guests from compromised hosts (such as AMD SEV, IBM's PEF and others). However, I think the changes make sense on their own, so I'm sending them for inclusion now, while finishing the polish on the rest of those patches. Please apply. David Gibson (9): target/i386: sev: Remove unused QSevGuestInfoClass target/i386: sev: Move local structure definitions into .c file target/i386: sev: Rename QSevGuestInfo target/i386: sev: Embed SEVState in SevGuestState target/i386: sev: Partial cleanup to sev_state global target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields target/i386: sev: Remove redundant policy field target/i386: sev: Remove redundant handle field target/i386: sev: Unify SEVState and SevGuestState target/i386/sev.c | 257 +++++++++++++++++++++++------------------ target/i386/sev_i386.h | 49 -------- 2 files changed, 143 insertions(+), 163 deletions(-)