| Message ID | 20200609072828.9088-1-lars.povlsen@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: Adding support for Microchip Sparx5 SoC | expand |
On 6/9/20 12:28 AM, Lars Povlsen wrote: > This is an add-on series to the main SoC Sparx5 series > (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>) > > Changes in v2: > - Changes in driver as per review comments > And you expect the reviewers/maintainers to remember what those were ? > Lars Povlsen (3): > dt-bindings: hwmon: Add Sparx5 temperature sensor > arm64: dts: sparx5: Add hwmon temperature sensor > hwmon: sparx5: Add Sparx5 SoC temperature driver > > .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++ > arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 + > drivers/hwmon/Kconfig | 10 ++ > drivers/hwmon/Makefile | 2 +- > drivers/hwmon/sparx5-temp.c | 152 ++++++++++++++++++ > 5 files changed, 208 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml > create mode 100644 drivers/hwmon/sparx5-temp.c > > -- > 2.27.0 >
Guenter Roeck writes: > On 6/9/20 12:28 AM, Lars Povlsen wrote: >> This is an add-on series to the main SoC Sparx5 series >> (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>) >> >> Changes in v2: >> - Changes in driver as per review comments >> > > And you expect the reviewers/maintainers to remember what those were ? > Well, I can see that this might not be the case. I'll be a little more specific next time. Sorry about that. For the record, it was: - Removed unnecessary #includes - Statement reordering in s5_read() - Replaced EINVAL with EIO - Add 'break' in default: case statement. - Removed extra () - Removed superfluous initialization I got some more comments from Jonathan Cameron <Jonathan.Cameron@huawei.com>, so there will be another round. Thanks, ---Lars >> Lars Povlsen (3): >> dt-bindings: hwmon: Add Sparx5 temperature sensor >> arm64: dts: sparx5: Add hwmon temperature sensor >> hwmon: sparx5: Add Sparx5 SoC temperature driver >> >> .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++ >> arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 + >> drivers/hwmon/Kconfig | 10 ++ >> drivers/hwmon/Makefile | 2 +- >> drivers/hwmon/sparx5-temp.c | 152 ++++++++++++++++++ >> 5 files changed, 208 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml >> create mode 100644 drivers/hwmon/sparx5-temp.c >> >> -- >> 2.27.0 >>