| Message ID | 20200609174959.955926-6-adrian.ratiu@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Genericize DW MIPI DSI bridge and add i.MX 6 driver | expand |
On Tue, Jun 09, 2020 at 08:49:53PM +0300, Adrian Ratiu wrote: > This provides an example DT binding for the MIPI DSI host controller It's not an example. It defines the exact binding for this peripheral. > present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. > > Cc: Rob Herring <robh@kernel.org> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: devicetree@vger.kernel.org > Tested-by: Adrian Pop <pop.adrian61@gmail.com> > Tested-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.com> > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> > --- > Changes since v8: > - Fixed small compatible string typo caught by checkpatch > - Added custom select for 'fsl,imx6-mipi-dsi' (Rob) > - Replaced additionalProperties -> unevaluatedProperties (Rob) > - Dropped all nodes not adding any new constraints apart from > the recently upstreamed snps,dw-mipi-dsi.yaml (Rob) > > Changes since v7: > - Clarified port@0,1 descriptions, marked them as required and > added missing port@0 in example (Laurent) > > Changes since v6: > - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent) > - Moved *-cells properties outside patternProperties (Laurent) > - Removed the panel port documentation (Laurent) > - Wrapped lines at 80 chars, typo fixes, sort includes (Laurent) > > Changes since v5: > - Fixed missing reg warning (Fabio) > - Updated dt-schema and fixed warnings (Rob) > > Changes since v4: > - Fixed yaml binding to pass `make dt_binding_check dtbs_check` > and addressed received binding feedback (Rob) > > Changes since v3: > - Added commit message (Neil) > - Converted to yaml format (Neil) > - Minor dt node + driver fixes (Rob) > - Added small panel example to the host controller binding > > Changes since v2: > - Fixed commit tags (Emil) > --- > .../display/imx/fsl,mipi-dsi-imx6.yaml | 112 ++++++++++++++++++ > 1 file changed, 112 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > new file mode 100644 > index 0000000000000..86093729fd5f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DW MIPI DSI Host Controller > + > +maintainers: > + - Adrian Ratiu <adrian.ratiu@collabora.com> > + > +description: | > + The i.MX6 DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 > + IP block with a companion PHY IP. > + > + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in > + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with > + the following device-specific properties. > + > +allOf: > + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# > + > +# Need a custom select here or 'snps,dw-mipi-dsi' will match lots of nodes > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6-mipi-dsi > + required: > + - compatible > + > +properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 These 2 are covered by dsi-controller.yaml, so you can drop them. Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml new file mode 100644 index 0000000000000..86093729fd5f9 --- /dev/null +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml @@ -0,0 +1,112 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX6 DW MIPI DSI Host Controller + +maintainers: + - Adrian Ratiu <adrian.ratiu@collabora.com> + +description: | + The i.MX6 DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 + IP block with a companion PHY IP. + + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with + the following device-specific properties. + +allOf: + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# + +# Need a custom select here or 'snps,dw-mipi-dsi' will match lots of nodes +select: + properties: + compatible: + contains: + enum: + - fsl,imx6-mipi-dsi + required: + - compatible + +properties: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + compatible: + items: + - const: fsl,imx6-mipi-dsi + - const: snps,dw-mipi-dsi + + interrupts: + maxItems: 1 + + fsl,gpr: + description: + Phandle to the iomuxc-gpr region containing the multiplexer ctrl register. + $ref: /schemas/types.yaml#/definitions/phandle + +unevaluatedProperties: false + +required: + - "#address-cells" + - "#size-cells" + - compatible + - interrupts + +examples: + - |+ + #include <dt-bindings/clock/imx6qdl-clock.h> + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + dsi: dsi@21e0000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,imx6-mipi-dsi", "snps,dw-mipi-dsi"; + reg = <0x021e0000 0x4000>; + interrupts = <0 102 IRQ_TYPE_LEVEL_HIGH>; + fsl,gpr = <&gpr>; + clocks = <&clks IMX6QDL_CLK_MIPI_CORE_CFG>, + <&clks IMX6QDL_CLK_MIPI_IPG>; + clock-names = "ref", "pclk"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + mipi_mux_0: endpoint { + remote-endpoint = <&ipu1_di0_mipi>; + }; + }; + port@1 { + reg = <1>; + dsi_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + + panel@0 { + compatible = "sharp,ls032b3sx01"; + reg = <0>; + reset-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + }; + }; + +...