Message ID | 20200505104849.13602-2-alban.gruin@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | stash: drop usage of a second index | expand |
On Tue, May 5, 2020 at 12:56 PM Alban Gruin <alban.gruin@gmail.com> wrote: > > As reset_tree() does not change the value pointed by `i_tree', and that > it will be provided with `the_hash_algo->empty_tree' which is a > constant, it is changed to be a pointer to a constant. [...] > -static int reset_tree(struct object_id *i_tree, int update, int reset) > +static int reset_tree(const struct object_id *i_tree, int update, int reset) Yeah, in rest_tree() it is only used like this: tree = parse_tree_indirect(i_tree); and parse_tree_indirect() takes a 'const struct object_id *'. > -- > 2.26.2 >
diff --git a/builtin/stash.c b/builtin/stash.c index 0c52a3b849..9baa8b379e 100644 --- a/builtin/stash.c +++ b/builtin/stash.c @@ -228,7 +228,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix) return do_clear_stash(); } -static int reset_tree(struct object_id *i_tree, int update, int reset) +static int reset_tree(const struct object_id *i_tree, int update, int reset) { int nr_trees = 1; struct unpack_trees_options opts;
As reset_tree() does not change the value pointed by `i_tree', and that it will be provided with `the_hash_algo->empty_tree' which is a constant, it is changed to be a pointer to a constant. Signed-off-by: Alban Gruin <alban.gruin@gmail.com> --- builtin/stash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)