| Message ID | 1591691846-7578-2-git-send-email-ppvk@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SDHC interconnect bandwidth scaling | expand |
On Tue, Jun 09, 2020 at 02:07:25PM +0530, Pradeep P V K wrote: > Interconnect bandwidth scaling support is now added as a > part of OPP. So, make sure interconnect driver is ready > before handling interconnect scaling. > > Signed-off-by: Pradeep P V K <ppvk@codeaurora.org> > Reviewed-by: Sibi Sankar <sibis@codeaurora.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Do you plan to send also patches that add the necessary DT entries? I'm particularly interested in SC7180.
On Tue, 9 Jun 2020 at 10:38, Pradeep P V K <ppvk@codeaurora.org> wrote: > > Interconnect bandwidth scaling support is now added as a > part of OPP. So, make sure interconnect driver is ready > before handling interconnect scaling. > > Signed-off-by: Pradeep P V K <ppvk@codeaurora.org> > Reviewed-by: Sibi Sankar <sibis@codeaurora.org> Applied for next, thanks! Kind regards Uffe > --- > > This change is based on > [1] [Patch v8] Introduce OPP bandwidth bindings > (https://lkml.org/lkml/2020/5/12/493) > > [2] [Patch v3] mmc: sdhci-msm: Fix error handling > for dev_pm_opp_of_add_table() > (https://lkml.org/lkml/2020/5/5/491) > > drivers/mmc/host/sdhci-msm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index b277dd7..15c42b0 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -14,6 +14,7 @@ > #include <linux/slab.h> > #include <linux/iopoll.h> > #include <linux/regulator/consumer.h> > +#include <linux/interconnect.h> > > #include "sdhci-pltfm.h" > #include "cqhci.h" > @@ -2070,6 +2071,11 @@ static int sdhci_msm_probe(struct platform_device *pdev) > } > msm_host->bulk_clks[0].clk = clk; > > + /* Check for optional interconnect paths */ > + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); > + if (ret) > + goto bus_clk_disable; > + > msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core"); > if (IS_ERR(msm_host->opp_table)) { > ret = PTR_ERR(msm_host->opp_table); > -- > 1.9.1 >
Hi Matthias, Thanks! On 2020-06-16 04:42, Matthias Kaehlcke wrote: > On Tue, Jun 09, 2020 at 02:07:25PM +0530, Pradeep P V K wrote: >> Interconnect bandwidth scaling support is now added as a >> part of OPP. So, make sure interconnect driver is ready >> before handling interconnect scaling. >> >> Signed-off-by: Pradeep P V K <ppvk@codeaurora.org> >> Reviewed-by: Sibi Sankar <sibis@codeaurora.org> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > > Do you plan to send also patches that add the necessary DT entries? > I'm particularly interested in SC7180. Yes, we will send the DT entries soon.
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index b277dd7..15c42b0 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/iopoll.h> #include <linux/regulator/consumer.h> +#include <linux/interconnect.h> #include "sdhci-pltfm.h" #include "cqhci.h" @@ -2070,6 +2071,11 @@ static int sdhci_msm_probe(struct platform_device *pdev) } msm_host->bulk_clks[0].clk = clk; + /* Check for optional interconnect paths */ + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); + if (ret) + goto bus_clk_disable; + msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core"); if (IS_ERR(msm_host->opp_table)) { ret = PTR_ERR(msm_host->opp_table);