| Message ID | 20200615212806.BlueZ.v1.1.I8328c620402620c9aadc149614bb279e42a9db4f@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning. Test Result: checkgitlint Failed Outputs: 1: T1 Title exceeds max length (74>72): "lib: Correct the name of Add Advertisement Patterns Monitor Command opcode" --- Regards, Linux Bluetooth
Hi Miao, On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@chromium.org> wrote: > > lib/mgmt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/mgmt.h b/lib/mgmt.h > index f44f2465d..bb31156ab 100644 > --- a/lib/mgmt.h > +++ b/lib/mgmt.h > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern { > uint8_t value[31]; > } __packed; > > -#define MGMT_OP_ADD_ADV_MONITOR 0x0052 > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052 > struct mgmt_cp_add_adv_monitor { > uint8_t pattern_count; > struct mgmt_adv_pattern patterns[0]; > -- > 2.26.2 The name already contains PATTERNS: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499
On Mon, Jun 15, 2020 at 11:18 PM Von Dentz, Luiz <luiz.von.dentz@intel.com> wrote: > > Hi Miao, > > On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@chromium.org> wrote: > > > > lib/mgmt.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/mgmt.h b/lib/mgmt.h > > index f44f2465d..bb31156ab 100644 > > --- a/lib/mgmt.h > > +++ b/lib/mgmt.h > > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern { > > uint8_t value[31]; > > } __packed; > > > > -#define MGMT_OP_ADD_ADV_MONITOR 0x0052 > > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052 > > struct mgmt_cp_add_adv_monitor { > > uint8_t pattern_count; > > struct mgmt_adv_pattern patterns[0]; > > -- > > 2.26.2 > > > The name already contains PATTERNS: > > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499 Nevermind this is actually the command name rather than its definition which is what you are fixing.
Hi Miao, On Mon, Jun 15, 2020 at 9:32 PM Miao-chen Chou <mcchou@chromium.org> wrote: > > lib/mgmt.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/mgmt.h b/lib/mgmt.h > index f44f2465d..bb31156ab 100644 > --- a/lib/mgmt.h > +++ b/lib/mgmt.h > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern { > uint8_t value[31]; > } __packed; > > -#define MGMT_OP_ADD_ADV_MONITOR 0x0052 > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052 > struct mgmt_cp_add_adv_monitor { > uint8_t pattern_count; > struct mgmt_adv_pattern patterns[0]; > -- > 2.26.2 > Applied, thanks.
diff --git a/lib/mgmt.h b/lib/mgmt.h index f44f2465d..bb31156ab 100644 --- a/lib/mgmt.h +++ b/lib/mgmt.h @@ -673,7 +673,7 @@ struct mgmt_adv_pattern { uint8_t value[31]; } __packed; -#define MGMT_OP_ADD_ADV_MONITOR 0x0052 +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052 struct mgmt_cp_add_adv_monitor { uint8_t pattern_count; struct mgmt_adv_pattern patterns[0];