| Message ID | cover.1592225557.git.christophe.leroy@csgroup.eu (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix build failure with v5.8-rc1 | expand |
[+Arnd in case he's interested in this series] On Mon, Jun 15, 2020 at 12:57:55PM +0000, Christophe Leroy wrote: > Commit 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for > {READ,WRITE}_ONCE() memory accesses") leads to following build > failure on powerpc 8xx. > > To fix it, this small series introduces a new helper named ptep_get() > to replace the direct access with READ_ONCE(). This new helper > can be overriden by architectures. Thanks for doing this, and sorry for the breakage. For the series: Acked-by: Will Deacon <will@kernel.org> Hopefully we can introduce accessors for the other page-table levels too, but that can obviously happen incrementally. Will > Christophe Leroy (3): > mm/gup: Use huge_ptep_get() in gup_hugepte() > mm: Allow arches to provide ptep_get() > powerpc/8xx: Provide ptep_get() with 16k pages > > arch/powerpc/include/asm/nohash/32/pgtable.h | 10 ++++++++++ > include/asm-generic/hugetlb.h | 2 +- > include/linux/pgtable.h | 7 +++++++ > mm/gup.c | 4 ++-- > 4 files changed, 20 insertions(+), 3 deletions(-) > > -- > 2.25.0 >
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Commit 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for > {READ,WRITE}_ONCE() memory accesses") leads to following build > failure on powerpc 8xx. I've put this in my fixes branch. cheers
On Mon, 15 Jun 2020 12:57:55 +0000 (UTC), Christophe Leroy wrote: > Commit 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for > {READ,WRITE}_ONCE() memory accesses") leads to following build > failure on powerpc 8xx. > > To fix it, this small series introduces a new helper named ptep_get() > to replace the direct access with READ_ONCE(). This new helper > can be overriden by architectures. > > [...] Applied to powerpc/fixes. [1/3] mm/gup: Use huge_ptep_get() in gup_hugepte() https://git.kernel.org/powerpc/c/01a80ec6495f9e43f61b3231f3b283ca050a800e [2/3] mm: Allow arches to provide ptep_get() https://git.kernel.org/powerpc/c/f7583fd6bdcc4d0b43f68fb81ebfae9669ee9338 [3/3] powerpc/8xx: Provide ptep_get() with 16k pages https://git.kernel.org/powerpc/c/b55129f97aeefd265314e12d98935330e011a14a cheers
Commit 2ab3a0a02905 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses") leads to following build failure on powerpc 8xx. To fix it, this small series introduces a new helper named ptep_get() to replace the direct access with READ_ONCE(). This new helper can be overriden by architectures. CC mm/gup.o In file included from ./include/linux/kernel.h:11:0, from mm/gup.c:2: In function 'gup_hugepte.constprop', inlined from 'gup_huge_pd.isra.79' at mm/gup.c:2465:8: ./include/linux/compiler.h:392:38: error: call to '__compiletime_assert_222' declared with attribute error: Unsupported access size for {READ,WRITE}_ONCE(). _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler.h:373:4: note: in definition of macro '__compiletime_assert' prefix ## suffix(); \ ^ ./include/linux/compiler.h:392:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler.h:405:2: note: in expansion of macro 'compiletime_assert' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler.h:291:2: note: in expansion of macro 'compiletime_assert_rwonce_type' compiletime_assert_rwonce_type(x); \ ^ mm/gup.c:2428:8: note: in expansion of macro 'READ_ONCE' pte = READ_ONCE(*ptep); ^ In function 'gup_get_pte', inlined from 'gup_pte_range' at mm/gup.c:2228:9, inlined from 'gup_pmd_range' at mm/gup.c:2613:15, inlined from 'gup_pud_range' at mm/gup.c:2641:15, inlined from 'gup_p4d_range' at mm/gup.c:2666:15, inlined from 'gup_pgd_range' at mm/gup.c:2694:15, inlined from 'internal_get_user_pages_fast' at mm/gup.c:2795:3: ./include/linux/compiler.h:392:38: error: call to '__compiletime_assert_219' declared with attribute error: Unsupported access size for {READ,WRITE}_ONCE(). _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler.h:373:4: note: in definition of macro '__compiletime_assert' prefix ## suffix(); \ ^ ./include/linux/compiler.h:392:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ./include/linux/compiler.h:405:2: note: in expansion of macro 'compiletime_assert' compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ ^ ./include/linux/compiler.h:291:2: note: in expansion of macro 'compiletime_assert_rwonce_type' compiletime_assert_rwonce_type(x); \ ^ mm/gup.c:2199:9: note: in expansion of macro 'READ_ONCE' return READ_ONCE(*ptep); ^ make[2]: *** [mm/gup.o] Error 1 Christophe Leroy (3): mm/gup: Use huge_ptep_get() in gup_hugepte() mm: Allow arches to provide ptep_get() powerpc/8xx: Provide ptep_get() with 16k pages arch/powerpc/include/asm/nohash/32/pgtable.h | 10 ++++++++++ include/asm-generic/hugetlb.h | 2 +- include/linux/pgtable.h | 7 +++++++ mm/gup.c | 4 ++-- 4 files changed, 20 insertions(+), 3 deletions(-)