| Message ID | 20200619202320.4619-1-randall.s.becker@rogers.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Replace strbuf_write_fd with write_in_full | expand |
randall.s.becker@rogers.com writes: > From: "Randall S. Becker" <randall.becker@nexbridge.ca> > > The strbuf_write_fd method does not check whether the buffer exceeds > MAX_IO_SIZE on the target platform. This fix replaces the use of that > method with write_in_full, which does. Since this is the only use of > strbuf_write_fd, and since the method was unsafe, it has been removed > from strbuf.c and strbuf.h. Excellent. Thanks. Will queue.
From: "Randall S. Becker" <randall.becker@nexbridge.ca> The strbuf_write_fd method does not check whether the buffer exceeds MAX_IO_SIZE on the target platform. This fix replaces the use of that method with write_in_full, which does. Since this is the only use of strbuf_write_fd, and since the method was unsafe, it has been removed from strbuf.c and strbuf.h. Randall S. Becker (2): bugreport.c: replace strbuf_write_fd with write_in_full strbuf: remove unreferenced strbuf_write_fd method. bugreport.c | 4 +++- strbuf.c | 5 ----- strbuf.h | 1 - 3 files changed, 3 insertions(+), 7 deletions(-)