| Message ID | 20200619213347.27826-5-horia.geanta@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | hwrng: add support for i.MX6 rngb | expand |
On Fri, Jun 19, 2020 at 6:34 PM Horia Geantă <horia.geanta@nxp.com> wrote: > > i.MX6 SL, SLL, ULL, ULZ SoCs have an RNGB block. > > Since imx-rngc driver supports also rngb, > let's enable it for these SoCs too. > > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > --- > drivers/char/hw_random/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig > index 0ad17efc96df..53f6a7e4392f 100644 > --- a/drivers/char/hw_random/Kconfig > +++ b/drivers/char/hw_random/Kconfig > @@ -245,7 +245,7 @@ config HW_RANDOM_MXC_RNGA > config HW_RANDOM_IMX_RNGC > tristate "Freescale i.MX RNGC Random Number Generator" > depends on HAS_IOMEM && HAVE_CLK > - depends on SOC_IMX25 || COMPILE_TEST > + depends on SOC_IMX25 || SOC_IMX6SL || SOC_IMX6SLL || SOC_IMX6UL || COMPILE_TEST If in the future more SoCs will use this IP, then we will need to keep extending this list over and over again. Maybe you could use: depends on MACH_IMX || COMPILE_TEST > default HW_RANDOM > help > This driver provides kernel-side support for the Random Number > -- > 2.17.1 >
On Fri, Jun 19, 2020 at 6:46 PM Fabio Estevam <festevam@gmail.com> wrote: > If in the future more SoCs will use this IP, then we will need to keep > extending this list over and over again. > > Maybe you could use: > > depends on MACH_IMX || COMPILE_TEST MACH_MXC is what I meant ;-)
On 6/20/2020 12:49 AM, Fabio Estevam wrote: > On Fri, Jun 19, 2020 at 6:46 PM Fabio Estevam <festevam@gmail.com> wrote: > >> If in the future more SoCs will use this IP, then we will need to keep >> extending this list over and over again. >> >> Maybe you could use: >> >> depends on MACH_IMX || COMPILE_TEST > > MACH_MXC is what I meant ;-) > Probably ARCH_MXC. ARCH_MXC was originally the dependency for this driver, until it was changed to a more specific one by commit fcdba3c33a4d ("hwrng: imx-rngc - improve dependencies") I don't think we'll see too many RNGB deployments in the future, thus the list of SoCs shouldn't change that often. Horia
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig index 0ad17efc96df..53f6a7e4392f 100644 --- a/drivers/char/hw_random/Kconfig +++ b/drivers/char/hw_random/Kconfig @@ -245,7 +245,7 @@ config HW_RANDOM_MXC_RNGA config HW_RANDOM_IMX_RNGC tristate "Freescale i.MX RNGC Random Number Generator" depends on HAS_IOMEM && HAVE_CLK - depends on SOC_IMX25 || COMPILE_TEST + depends on SOC_IMX25 || SOC_IMX6SL || SOC_IMX6SLL || SOC_IMX6UL || COMPILE_TEST default HW_RANDOM help This driver provides kernel-side support for the Random Number
i.MX6 SL, SLL, ULL, ULZ SoCs have an RNGB block. Since imx-rngc driver supports also rngb, let's enable it for these SoCs too. Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- drivers/char/hw_random/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)