| Message ID | 20200622112914.30454-13-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | audio: deprecate -soundhw | expand |
On Mon, Jun 22, 2020 at 01:29:07PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > docs/system/deprecated.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index 3a255591c341..7ddd9e400745 100644 > --- a/docs/system/deprecated.rst > +++ b/docs/system/deprecated.rst > @@ -82,6 +82,15 @@ should specify an ``audiodev=`` property. Additionally, when using > vnc, you should specify an ``audiodev=`` propery if you plan to > transmit audio through the VNC protocol. > > +Creating sound card devices using ``-soundhw`` (since 5.1) > +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > + > +Sound card devices should be created using ``-device`` instead. The > +names are the same for most devices. The exceptions are ``hda`` which > +needs two devices (``-device intel-hda --device hda-duplex``) and > +``pcspk`` which can be activated using ``-global > +pcspk.audiodev=<name>``. The previous "-soundhw pcspk" didn't include any audiodev specification, so I presume it activated some kind of default ? What would be the equivalent audiodev to specify for the new arg to match the old default ? Regards, Daniel
On Mon, Jun 22, 2020 at 12:42:54PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 22, 2020 at 01:29:07PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > --- > > docs/system/deprecated.rst | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > > index 3a255591c341..7ddd9e400745 100644 > > --- a/docs/system/deprecated.rst > > +++ b/docs/system/deprecated.rst > > @@ -82,6 +82,15 @@ should specify an ``audiodev=`` property. Additionally, when using > > vnc, you should specify an ``audiodev=`` propery if you plan to > > transmit audio through the VNC protocol. > > > > +Creating sound card devices using ``-soundhw`` (since 5.1) > > +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > + > > +Sound card devices should be created using ``-device`` instead. The > > +names are the same for most devices. The exceptions are ``hda`` which > > +needs two devices (``-device intel-hda --device hda-duplex``) and > > +``pcspk`` which can be activated using ``-global > > +pcspk.audiodev=<name>``. > > The previous "-soundhw pcspk" didn't include any audiodev specification, > so I presume it activated some kind of default ? Yes. First audiodev it finds. Before -audiodev arrived you could not have multiple backends in the first place, so this covers backward compatibility with existing configurations. > What would be the equivalent audiodev to specify for the new arg to > match the old default ? Doesn't exist. You have to explicitly create an audiodev backend. See also patch 19/19 which adds "-machine pcspk-audidev=<name>", that'll probably more useful for libvirt because (a) -global should be avoided anyway and (b) you can see the new machine property in qapi introspection and pick pcspk init code path based on that. take care, Gerd
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 3a255591c341..7ddd9e400745 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -82,6 +82,15 @@ should specify an ``audiodev=`` property. Additionally, when using vnc, you should specify an ``audiodev=`` propery if you plan to transmit audio through the VNC protocol. +Creating sound card devices using ``-soundhw`` (since 5.1) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Sound card devices should be created using ``-device`` instead. The +names are the same for most devices. The exceptions are ``hda`` which +needs two devices (``-device intel-hda --device hda-duplex``) and +``pcspk`` which can be activated using ``-global +pcspk.audiodev=<name>``. + ``-mon ...,control=readline,pretty=on|off`` (since 4.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- docs/system/deprecated.rst | 9 +++++++++ 1 file changed, 9 insertions(+)