[00/14] SHA-256 CVS and SVN patches

Message

brian m. carlson June 19, 2020, 10:39 p.m. UTC

I recently sent out part 2/3 of the SHA-256 work and then I realized
that I hadn't built with the CVS and SVN adapters.  So this is part
2.5/3 (or, to be pedantic, 3/4).

The patches are ordered roughly with test-only fixes, then SVN, and then
CVS.  There are no additional tests here because everything fails with
SHA-256 before and passes afterwards.

brian m. carlson (14):
  t9109: make test hash independent
  t9168: make test hash independent
  t9108: make test hash independent
  t9100: make test work with SHA-256
  t9104: make hash size independent
  t9101: make hash independent
  t/lib-git-svn: make hash size independent
  perl: create and switch variables for hash constants
  perl: make Git::IndexInfo work with SHA-256
  perl: make SVN code hash independent
  git-svn: set the OID length based on hash algorithm
  git-cvsserver: port to SHA-256
  git-cvsimport: port to SHA-256
  git-cvsexportcommit: port to SHA-256

 git-cvsexportcommit.perl                   | 14 ++--
 git-cvsimport.perl                         |  8 +--
 git-cvsserver.perl                         | 37 +++++-----
 git-svn.perl                               | 25 ++++---
 perl/Git/IndexInfo.pm                      |  6 +-
 perl/Git/SVN.pm                            | 83 +++++++++++-----------
 perl/Git/SVN/Editor.pm                     |  8 +--
 perl/Git/SVN/Fetcher.pm                    |  6 +-
 perl/Git/SVN/Log.pm                        |  2 +-
 perl/Git/SVN/Ra.pm                         |  4 +-
 t/lib-git-svn.sh                           | 25 +++----
 t/t9100-git-svn-basic.sh                   | 19 ++++-
 t/t9101-git-svn-props.sh                   | 12 ++--
 t/t9104-git-svn-follow-parent.sh           |  3 +-
 t/t9108-git-svn-glob.sh                    |  4 +-
 t/t9109-git-svn-multi-glob.sh              |  6 +-
 t/t9168-git-svn-partially-globbed-names.sh |  8 +--
 17 files changed, 154 insertions(+), 116 deletions(-)

Comments

Eric Wong June 20, 2020, 12:21 a.m. UTC | #1

"brian m. carlson" <[e-mail]> wrote:
> The patches are ordered roughly with test-only fixes, then SVN, and then
> CVS.  There are no additional tests here because everything fails with
> SHA-256 before and passes afterwards.

Thanks brian.  I took a quick look at this series (including the
CVS stuff) and nothing objectionable jumped out(*).

Consider this series Acked-by: me

(*) except perhaps some of my original code :x
    which I hope to fix at some point this year

Junio C Hamano June 22, 2020, 4:50 p.m. UTC | #2

"brian m. carlson" <[e-mail]> writes:

> I recently sent out part 2/3 of the SHA-256 work and then I realized
> that I hadn't built with the CVS and SVN adapters.  So this is part
> 2.5/3 (or, to be pedantic, 3/4).

OK.  It seems that at least the early test-only parts depends only
on what is already in 'master' (there are uses of "test_oid algo"
and "test_oid rawsz"), but let's queue it on top of 3716d50d
(remote-testgit: adapt for object-format, 2020-06-19), and merge the
part 2 to 'next' soonish.

Thanks.

brian m. carlson June 22, 2020, 5:46 p.m. UTC | #3

On 2020-06-22 at 16:50:41, Junio C Hamano wrote:
> "brian m. carlson" <[e-mail]> writes:
> 
> > I recently sent out part 2/3 of the SHA-256 work and then I realized
> > that I hadn't built with the CVS and SVN adapters.  So this is part
> > 2.5/3 (or, to be pedantic, 3/4).
> 
> OK.  It seems that at least the early test-only parts depends only
> on what is already in 'master' (there are uses of "test_oid algo"
> and "test_oid rawsz"), but let's queue it on top of 3716d50d
> (remote-testgit: adapt for object-format, 2020-06-19), and merge the
> part 2 to 'next' soonish.

Sounds fine.  I'm about to send out a v2 with Andreas's suggestion (and
therefore a slightly smaller diff), but it should be a straightforward
replacement.

And yes, that it was based off master was intentional.  There are no
more test structure changes before the final series.