| Message ID | 1592937087-8885-1-git-send-email-tharvey@gateworks.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4237c625304b212a3f30adf787901082082511ec |
| Headers | show |
| Series | [RESEND,v2] ARM: dts: imx6qdl-gw551x: fix audio SSI | expand |
Hi Tim, On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <tharvey@gateworks.com> wrote: > > The audio codec on the GW551x routes to ssi1 > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Shouldn't this have a Fixes tag, so that it could be backported to older stable kernels?
On Tue, Jun 23, 2020 at 11:41 AM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Tim, > > On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <tharvey@gateworks.com> wrote: > > > > The audio codec on the GW551x routes to ssi1 > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Shouldn't this have a Fixes tag, so that it could be backported to > older stable kernels? Fabio, Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1. I didn't think it would apply cleanly to stable but it looks like it does. I cc'd stable@vger.kernel.org. Should I submit a new revision with the following? Cc: stable@vger.kernel.org Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x") Thanks, Tim
Hi Tim, On Tue, Jun 23, 2020 at 3:52 PM Tim Harvey <tharvey@gateworks.com> wrote: > Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1. > I didn't think it would apply cleanly to stable but it looks like it > does. > > I cc'd stable@vger.kernel.org. Should I submit a new revision with the > following? > > Cc: stable@vger.kernel.org > Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x") Yes, that would be better. Please note that the commit ID used in the Fixes tag should be 12-digit long.
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi index c38e86e..8c33510 100644 --- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi +++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi @@ -110,7 +110,7 @@ simple-audio-card,frame-master = <&sound_codec>; sound_cpu: simple-audio-card,cpu { - sound-dai = <&ssi2>; + sound-dai = <&ssi1>; }; sound_codec: simple-audio-card,codec {
The audio codec on the GW551x routes to ssi1 Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- v2: fix typo in commit short desc --- arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)