mbox series

[v7,00/17] wilc1000: move out of staging

Message ID 20200623110000.31559-1-ajay.kathat@microchip.com (mailing list archive)
Headers show
Series wilc1000: move out of staging | expand

Message

Ajay Singh June 23, 2020, 11 a.m. UTC
From: Ajay Singh <ajay.kathat@microchip.com>

This patch series is to review and move wilc1000 driver out of staging.
Most of the review comments received in [1] & [2] are addressed in the
latest code.
Please review and provide your inputs.

[1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
[2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/

Changes since v6:
 - added Reviewed-by tag received for DT binding document patch earlier.
   * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
 - merged latest driver and included --base commit as suggested.

Changes since v5:
 - handle DT binding review comments suggested in below link:
  * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus
 - merged latest driver from staging which contains few cleanup patches
   and changes to use crc7 from existing library instead of having
   private implementation.

Changes since v4:
  - merged wilc1000 SDIO and SPI DT binding into a single file.
  - handle DT binding review comments suggested in below links:
    * https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus
    * https://lore.kernel.org/linux-wireless/20200306144400.4269-2-ajay.kathat@microchip.com

Changes since v3:
  - handle few Smatch static checker reported issues.
  - use flexible-array member instead of zero-length array.

Changes since v2:
  - use 'struct' to extract FW info from received commands.
  - make use of C style comments instead of C++.
  - remove use of bool type for firmware struct.
  - deleted unused code related to interrupt handling.
  - make use of RCU list to maintain interfaces list.
  - remove 'wilc_' prefix from file name.
  - added 'WILC_' prefix for header guard macro.
  - remove use of infinite loops(i.e. while(1)).
  - move firmware related struct to a separate file.
  - refactor SPI command handling by using 'struct'.
  - use different functions to handle different SPI commands.
  - cleanup spi.c and sdio.c by removing unused code.
  - remove use of vendor specific IE for p2p handling.
  - refactor p2p related code to avoid use of buf pointer operation.
  - make use of FIELD_GET/PREP macro.
  - use #define instead of magic values.
  - use YAML schemes for DT binding documentation.
  - deleted unused code from spi.c and sdio.c.
  - added changes for few issues reported by smatch static code analyzer.

Changes since v1:
  - remove use of shadow buffer to keep scan result.
  - remove internal messaging flow to handle cfg80211_ops.
  - make use of cfg80211 provide API.
  - use 'struct' for packing firmware commands.
  - make use of kernel API's and Macro.
  - remove unnecessary log messages
  - supported dynamically add/remove interfaces.
  - cleanup and deleted around 3.3k lines of code.

Ajay Singh (17):
  wilc1000: add hif.h
  wilc1000: add hif.c
  wilc1000: add wlan_if.h
  wilc1000: add wlan_cfg.h
  wilc1000: add wlan_cfg.c
  wilc1000: add cfg80211.c
  wilc1000: add cfg80211.h
  wilc1000: add netdev.h
  wilc1000: add netdev.c
  wilc1000: add mon.c
  wilc1000: add spi.c
  wilc1000: add wlan.h
  wilc1000: add wlan.c
  wilc1000: add sdio.c
  wilc1000: add fw.h
  dt: bindings: net: add microchip,wilc1000.yaml
  wilc1000: add Makefile and Kconfig files for wilc1000 compilation

 .../net/wireless/microchip,wilc1000.yaml      |   71 +
 drivers/net/wireless/Kconfig                  |    1 +
 drivers/net/wireless/Makefile                 |    1 +
 drivers/net/wireless/microchip/Kconfig        |   15 +
 drivers/net/wireless/microchip/Makefile       |    2 +
 .../net/wireless/microchip/wilc1000/Kconfig   |   47 +
 .../net/wireless/microchip/wilc1000/Makefile  |   14 +
 .../wireless/microchip/wilc1000/cfg80211.c    | 1846 ++++++++++++++++
 .../wireless/microchip/wilc1000/cfg80211.h    |   30 +
 drivers/net/wireless/microchip/wilc1000/fw.h  |  119 +
 drivers/net/wireless/microchip/wilc1000/hif.c | 1961 +++++++++++++++++
 drivers/net/wireless/microchip/wilc1000/hif.h |  214 ++
 drivers/net/wireless/microchip/wilc1000/mon.c |  260 +++
 .../net/wireless/microchip/wilc1000/netdev.c  |  931 ++++++++
 .../net/wireless/microchip/wilc1000/netdev.h  |  287 +++
 .../net/wireless/microchip/wilc1000/sdio.c    | 1023 +++++++++
 drivers/net/wireless/microchip/wilc1000/spi.c |  945 ++++++++
 .../net/wireless/microchip/wilc1000/wlan.c    | 1238 +++++++++++
 .../net/wireless/microchip/wilc1000/wlan.h    |  397 ++++
 .../wireless/microchip/wilc1000/wlan_cfg.c    |  413 ++++
 .../wireless/microchip/wilc1000/wlan_cfg.h    |   54 +
 .../net/wireless/microchip/wilc1000/wlan_if.h |  803 +++++++
 drivers/staging/Kconfig                       |    2 -
 drivers/staging/Makefile                      |    1 -
 24 files changed, 10672 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
 create mode 100644 drivers/net/wireless/microchip/Kconfig
 create mode 100644 drivers/net/wireless/microchip/Makefile
 create mode 100644 drivers/net/wireless/microchip/wilc1000/Kconfig
 create mode 100644 drivers/net/wireless/microchip/wilc1000/Makefile
 create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/fw.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/mon.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/sdio.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/spi.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.c
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.h
 create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_if.h


base-commit: a15a20acc980342c97d804c5fae1cfc0cd7712a9

Comments

Kalle Valo June 24, 2020, 8:50 a.m. UTC | #1
<Ajay.Kathat@microchip.com> writes:

> From: Ajay Singh <ajay.kathat@microchip.com>
>
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code.
> Please review and provide your inputs.
>
> [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
> [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
>
> Changes since v6:
>  - added Reviewed-by tag received for DT binding document patch earlier.
>    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
>  - merged latest driver and included --base commit as suggested.

Greg, in preparation for moving the driver to drivers/net/wireless can I
ask you to not to take wilc1000 patches for the time being? I think that
way it would be easier to move the driver between trees if there are no
changes after v5.8-rc1. Or is there a better way handle the move?

I have not reviewed the latest version yet but I'm hoping it's ready
now. I would also appreciate comments from other people about the
readiness of this driver.
Greg KH June 24, 2020, 9:10 a.m. UTC | #2
On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
> <Ajay.Kathat@microchip.com> writes:
> 
> > From: Ajay Singh <ajay.kathat@microchip.com>
> >
> > This patch series is to review and move wilc1000 driver out of staging.
> > Most of the review comments received in [1] & [2] are addressed in the
> > latest code.
> > Please review and provide your inputs.
> >
> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
> >
> > Changes since v6:
> >  - added Reviewed-by tag received for DT binding document patch earlier.
> >    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
> >  - merged latest driver and included --base commit as suggested.
> 
> Greg, in preparation for moving the driver to drivers/net/wireless can I
> ask you to not to take wilc1000 patches for the time being? I think that
> way it would be easier to move the driver between trees if there are no
> changes after v5.8-rc1. Or is there a better way handle the move?

The best way is for there to be a series of patches that just adds the
driver to the "real" part of the tree, and when that is merged, let me
know and I will just delete the driver version in the staging tree.

Does that work for you?

thanks,

greg k-h
Kalle Valo June 24, 2020, 9:49 a.m. UTC | #3
Greg KH <gregkh@linuxfoundation.org> writes:

> On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> <Ajay.Kathat@microchip.com> writes:
>> 
>> > From: Ajay Singh <ajay.kathat@microchip.com>
>> >
>> > This patch series is to review and move wilc1000 driver out of staging.
>> > Most of the review comments received in [1] & [2] are addressed in the
>> > latest code.
>> > Please review and provide your inputs.
>> >
>> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
>> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
>> >
>> > Changes since v6:
>> >  - added Reviewed-by tag received for DT binding document patch earlier.
>> >    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
>> >  - merged latest driver and included --base commit as suggested.
>> 
>> Greg, in preparation for moving the driver to drivers/net/wireless can I
>> ask you to not to take wilc1000 patches for the time being? I think that
>> way it would be easier to move the driver between trees if there are no
>> changes after v5.8-rc1. Or is there a better way handle the move?
>
> The best way is for there to be a series of patches that just adds the
> driver to the "real" part of the tree, and when that is merged, let me
> know and I will just delete the driver version in the staging tree.
>
> Does that work for you?

It would be fine for me but won't that approach break the build (eg.
allyesconfig) due to two duplicate versions of the same driver in
wireless-drivers-next?

What I was thinking that Ajay would create a patch moving the driver
from drivers/staging/wilc1000 to
drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git
format-patch --find-renames' the patch should be really small, mostly
just renames and small changes to Kconfig, Makefile and MAINTAINERS
files. But this of course would require that there are no wilc1000
patches in your tree until you get the driver move commit during the
next merge window, otherwise we would see conflicts between staging-next
and wireless-drivers-next.

But I don't have any strong opinions, whatever is easiest for everyone :)

For reference wireless-drivers-next is merged like this:

wireless-drivers-next -> net-next -> linus

And naturally I would be aiming this for the v5.9 merge window.
Greg KH June 24, 2020, 2:52 p.m. UTC | #4
On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
> >> <Ajay.Kathat@microchip.com> writes:
> >> 
> >> > From: Ajay Singh <ajay.kathat@microchip.com>
> >> >
> >> > This patch series is to review and move wilc1000 driver out of staging.
> >> > Most of the review comments received in [1] & [2] are addressed in the
> >> > latest code.
> >> > Please review and provide your inputs.
> >> >
> >> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
> >> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
> >> >
> >> > Changes since v6:
> >> >  - added Reviewed-by tag received for DT binding document patch earlier.
> >> >    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
> >> >  - merged latest driver and included --base commit as suggested.
> >> 
> >> Greg, in preparation for moving the driver to drivers/net/wireless can I
> >> ask you to not to take wilc1000 patches for the time being? I think that
> >> way it would be easier to move the driver between trees if there are no
> >> changes after v5.8-rc1. Or is there a better way handle the move?
> >
> > The best way is for there to be a series of patches that just adds the
> > driver to the "real" part of the tree, and when that is merged, let me
> > know and I will just delete the driver version in the staging tree.
> >
> > Does that work for you?
> 
> It would be fine for me but won't that approach break the build (eg.
> allyesconfig) due to two duplicate versions of the same driver in
> wireless-drivers-next?

For maybe one day, yes, but that's all.

> What I was thinking that Ajay would create a patch moving the driver
> from drivers/staging/wilc1000 to
> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git
> format-patch --find-renames' the patch should be really small, mostly
> just renames and small changes to Kconfig, Makefile and MAINTAINERS
> files. But this of course would require that there are no wilc1000
> patches in your tree until you get the driver move commit during the
> next merge window, otherwise we would see conflicts between staging-next
> and wireless-drivers-next.
> 
> But I don't have any strong opinions, whatever is easiest for everyone :)

It's kind of hard to review patches that do moves, but if you all want
to do that, that's fine with me.

Note, I can't guarantee that I'll not take any wilc1000 patches, I'll
probably forget, but git mv will handle all of that just fine.

thanks,

greg k-h
Kalle Valo June 26, 2020, 5:34 a.m. UTC | #5
Greg KH <gregkh@linuxfoundation.org> writes:

> On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
>> Greg KH <gregkh@linuxfoundation.org> writes:
>> 
>> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> >> <Ajay.Kathat@microchip.com> writes:
>> >> 
>> >> > From: Ajay Singh <ajay.kathat@microchip.com>
>> >> >
>> >> > This patch series is to review and move wilc1000 driver out of staging.
>> >> > Most of the review comments received in [1] & [2] are addressed in the
>> >> > latest code.
>> >> > Please review and provide your inputs.
>> >> >
>> >> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
>> >> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
>> >> >
>> >> > Changes since v6:
>> >> >  - added Reviewed-by tag received for DT binding document patch earlier.
>> >> >    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
>> >> >  - merged latest driver and included --base commit as suggested.
>> >> 
>> >> Greg, in preparation for moving the driver to drivers/net/wireless can I
>> >> ask you to not to take wilc1000 patches for the time being? I think that
>> >> way it would be easier to move the driver between trees if there are no
>> >> changes after v5.8-rc1. Or is there a better way handle the move?
>> >
>> > The best way is for there to be a series of patches that just adds the
>> > driver to the "real" part of the tree, and when that is merged, let me
>> > know and I will just delete the driver version in the staging tree.
>> >
>> > Does that work for you?
>> 
>> It would be fine for me but won't that approach break the build (eg.
>> allyesconfig) due to two duplicate versions of the same driver in
>> wireless-drivers-next?
>
> For maybe one day, yes, but that's all.
>
>> What I was thinking that Ajay would create a patch moving the driver
>> from drivers/staging/wilc1000 to
>> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git
>> format-patch --find-renames' the patch should be really small, mostly
>> just renames and small changes to Kconfig, Makefile and MAINTAINERS
>> files. But this of course would require that there are no wilc1000
>> patches in your tree until you get the driver move commit during the
>> next merge window, otherwise we would see conflicts between staging-next
>> and wireless-drivers-next.
>> 
>> But I don't have any strong opinions, whatever is easiest for everyone :)
>
> It's kind of hard to review patches that do moves, but if you all want
> to do that, that's fine with me.

Actually we have been reviewing the driver with full diffs, one file per
patch style[1], so I think everyone are happy. At least I have not heard
any complaints.

And Ajay already submitted that the simple rename patch proposed, thanks
Ajay!

https://patchwork.kernel.org/patch/11625025/

And indeed the patch is simple as it can get. So Greg, if it's ok for
you I would like to apply that simple patch to wireless-drivers-next.

> Note, I can't guarantee that I'll not take any wilc1000 patches, I'll
> probably forget, but git mv will handle all of that just fine.

Good point. To be on the safe side one option is that if I create a
topic branch for this simple patch and use v5.8-rc1 as the baseline.
Then I would pull the topic branch to wireless-drivers-next and you
could pull it to staging-next. That way you would not have wilc1000 in
your tree anymore and no accidental submission or commits either :) What
do you think?

[1 ] https://patchwork.kernel.org/project/linux-wireless/list/?series=307223&state=*&order=date
Greg KH June 26, 2020, 1:46 p.m. UTC | #6
On Fri, Jun 26, 2020 at 08:34:48AM +0300, Kalle Valo wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
> >> Greg KH <gregkh@linuxfoundation.org> writes:
> >> 
> >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
> >> >> <Ajay.Kathat@microchip.com> writes:
> >> >> 
> >> >> > From: Ajay Singh <ajay.kathat@microchip.com>
> >> >> >
> >> >> > This patch series is to review and move wilc1000 driver out of staging.
> >> >> > Most of the review comments received in [1] & [2] are addressed in the
> >> >> > latest code.
> >> >> > Please review and provide your inputs.
> >> >> >
> >> >> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
> >> >> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
> >> >> >
> >> >> > Changes since v6:
> >> >> >  - added Reviewed-by tag received for DT binding document patch earlier.
> >> >> >    * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus
> >> >> >  - merged latest driver and included --base commit as suggested.
> >> >> 
> >> >> Greg, in preparation for moving the driver to drivers/net/wireless can I
> >> >> ask you to not to take wilc1000 patches for the time being? I think that
> >> >> way it would be easier to move the driver between trees if there are no
> >> >> changes after v5.8-rc1. Or is there a better way handle the move?
> >> >
> >> > The best way is for there to be a series of patches that just adds the
> >> > driver to the "real" part of the tree, and when that is merged, let me
> >> > know and I will just delete the driver version in the staging tree.
> >> >
> >> > Does that work for you?
> >> 
> >> It would be fine for me but won't that approach break the build (eg.
> >> allyesconfig) due to two duplicate versions of the same driver in
> >> wireless-drivers-next?
> >
> > For maybe one day, yes, but that's all.
> >
> >> What I was thinking that Ajay would create a patch moving the driver
> >> from drivers/staging/wilc1000 to
> >> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git
> >> format-patch --find-renames' the patch should be really small, mostly
> >> just renames and small changes to Kconfig, Makefile and MAINTAINERS
> >> files. But this of course would require that there are no wilc1000
> >> patches in your tree until you get the driver move commit during the
> >> next merge window, otherwise we would see conflicts between staging-next
> >> and wireless-drivers-next.
> >> 
> >> But I don't have any strong opinions, whatever is easiest for everyone :)
> >
> > It's kind of hard to review patches that do moves, but if you all want
> > to do that, that's fine with me.
> 
> Actually we have been reviewing the driver with full diffs, one file per
> patch style[1], so I think everyone are happy. At least I have not heard
> any complaints.
> 
> And Ajay already submitted that the simple rename patch proposed, thanks
> Ajay!
> 
> https://patchwork.kernel.org/patch/11625025/
> 
> And indeed the patch is simple as it can get. So Greg, if it's ok for
> you I would like to apply that simple patch to wireless-drivers-next.
> 
> > Note, I can't guarantee that I'll not take any wilc1000 patches, I'll
> > probably forget, but git mv will handle all of that just fine.
> 
> Good point. To be on the safe side one option is that if I create a
> topic branch for this simple patch and use v5.8-rc1 as the baseline.
> Then I would pull the topic branch to wireless-drivers-next and you
> could pull it to staging-next. That way you would not have wilc1000 in
> your tree anymore and no accidental submission or commits either :) What
> do you think?

That sounds great, I will be happy to pull such a branch.

thanks,

greg k-h
Pali Rohár June 29, 2020, 1:26 p.m. UTC | #7
On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code.
> Please review and provide your inputs.

Hello Ajay! Could you please move SDIO vendor/device ID definitions from
driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?

Similar cleanup was recently finished for all existing non-staging drivers:
https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/
Ajay Singh June 30, 2020, 3:17 a.m. UTC | #8
On 29/06/20 6:56 pm, Pali Rohár wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
>> This patch series is to review and move wilc1000 driver out of staging.
>> Most of the review comments received in [1] & [2] are addressed in the
>> latest code.
>> Please review and provide your inputs.
> 
> Hello Ajay! Could you please move SDIO vendor/device ID definitions from
> driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?
> 

Currently, the wilc1000 driver movement changes are present in topic
branch and yet to be merged to master branch. Would it be okay to submit
the new patch once driver is merged to 'wireless-driver-next' master and
branch is pulled into Greg's staging repo.

Regards,
Ajay

> Similar cleanup was recently finished for all existing non-staging drivers:
> https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/
>
Pali Rohár July 1, 2020, 7:55 a.m. UTC | #9
On Tuesday 30 June 2020 03:17:01 Ajay.Kathat@microchip.com wrote:
> On 29/06/20 6:56 pm, Pali Rohár wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
> >> This patch series is to review and move wilc1000 driver out of staging.
> >> Most of the review comments received in [1] & [2] are addressed in the
> >> latest code.
> >> Please review and provide your inputs.
> > 
> > Hello Ajay! Could you please move SDIO vendor/device ID definitions from
> > driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?
> > 
> 
> Currently, the wilc1000 driver movement changes are present in topic
> branch and yet to be merged to master branch. Would it be okay to submit
> the new patch once driver is merged to 'wireless-driver-next' master and
> branch is pulled into Greg's staging repo.

I think it should be OK. But maybe Ulf as maintainer of mmc subsystem
could have opinion or react on this.

> Regards,
> Ajay
> 
> > Similar cleanup was recently finished for all existing non-staging drivers:
> > https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/
> >
Pali Rohár July 1, 2020, 7:56 a.m. UTC | #10
(adding Ulf)

On Wednesday 01 July 2020 09:55:15 Pali Rohár wrote:
> On Tuesday 30 June 2020 03:17:01 Ajay.Kathat@microchip.com wrote:
> > On 29/06/20 6:56 pm, Pali Rohár wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > > 
> > > On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
> > >> This patch series is to review and move wilc1000 driver out of staging.
> > >> Most of the review comments received in [1] & [2] are addressed in the
> > >> latest code.
> > >> Please review and provide your inputs.
> > > 
> > > Hello Ajay! Could you please move SDIO vendor/device ID definitions from
> > > driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?
> > > 
> > 
> > Currently, the wilc1000 driver movement changes are present in topic
> > branch and yet to be merged to master branch. Would it be okay to submit
> > the new patch once driver is merged to 'wireless-driver-next' master and
> > branch is pulled into Greg's staging repo.
> 
> I think it should be OK. But maybe Ulf as maintainer of mmc subsystem
> could have opinion or react on this.
> 
> > Regards,
> > Ajay
> > 
> > > Similar cleanup was recently finished for all existing non-staging drivers:
> > > https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/
> > >
Kalle Valo July 2, 2020, 7:05 a.m. UTC | #11
Greg KH <gregkh@linuxfoundation.org> writes:

> On Fri, Jun 26, 2020 at 08:34:48AM +0300, Kalle Valo wrote:
>
>> And Ajay already submitted that the simple rename patch proposed, thanks
>> Ajay!
>> 
>> https://patchwork.kernel.org/patch/11625025/
>> 
>> And indeed the patch is simple as it can get. So Greg, if it's ok for
>> you I would like to apply that simple patch to wireless-drivers-next.
>> 
>> > Note, I can't guarantee that I'll not take any wilc1000 patches, I'll
>> > probably forget, but git mv will handle all of that just fine.
>> 
>> Good point. To be on the safe side one option is that if I create a
>> topic branch for this simple patch and use v5.8-rc1 as the baseline.
>> Then I would pull the topic branch to wireless-drivers-next and you
>> could pull it to staging-next. That way you would not have wilc1000 in
>> your tree anymore and no accidental submission or commits either :) What
>> do you think?
>
> That sounds great, I will be happy to pull such a branch.

Great! Sorry for taking so long, I'm on vacation right now, but here's
the immutable branch:

git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git wilc1000-move-out-of-staging

I have pulled it into wireless-drivers-next now.
Ulf Hansson July 6, 2020, 8:12 a.m. UTC | #12
On Wed, 1 Jul 2020 at 09:55, Pali Rohár <pali@kernel.org> wrote:
>
> On Tuesday 30 June 2020 03:17:01 Ajay.Kathat@microchip.com wrote:
> > On 29/06/20 6:56 pm, Pali Rohár wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
> > >> This patch series is to review and move wilc1000 driver out of staging.
> > >> Most of the review comments received in [1] & [2] are addressed in the
> > >> latest code.
> > >> Please review and provide your inputs.
> > >
> > > Hello Ajay! Could you please move SDIO vendor/device ID definitions from
> > > driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?
> > >
> >
> > Currently, the wilc1000 driver movement changes are present in topic
> > branch and yet to be merged to master branch. Would it be okay to submit
> > the new patch once driver is merged to 'wireless-driver-next' master and
> > branch is pulled into Greg's staging repo.
>
> I think it should be OK. But maybe Ulf as maintainer of mmc subsystem
> could have opinion or react on this.

That should be fine. Just keep me on cc so I can ack it. Potentially
we may get some mergeconflict between the trees, but let's resolve
that if/when that happens.

Kind regards
Uffe