| Message ID | 20200625163614.4001403-10-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix a bunch of W=1 warnings in Regulator | expand |
On Thu, Jun 25, 2020 at 05:36:13PM +0100, Lee Jones wrote:
> Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed
$ git show 9f75ce666199
fatal: ambiguous argument '9f75ce666199': unknown revision or path not in the working tree.
You should probably CC this to the authors of that commit - a similar
thing applies to several of the other patches here. You probably don't
want to CC everyone on everything but OTOH there isn't really any need
for things to be bundled up in a series anyway.
On Thu, 25 Jun 2020, Mark Brown wrote: > On Thu, Jun 25, 2020 at 05:36:13PM +0100, Lee Jones wrote: > > Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed > > $ git show 9f75ce666199 > fatal: ambiguous argument '9f75ce666199': unknown revision or path not in the working tree. > > You should probably CC this to the authors of that commit - a similar > thing applies to several of the other patches here. You probably don't > want to CC everyone on everything but OTOH there isn't really any need > for things to be bundled up in a series anyway. Sounds fair. Will Cc important people on individual patches.
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index e1d6c8f6d40bb..fe65b5acaf280 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = { }, { DA9063_LDO(DA9063, LDO9, 950, 50, 3600), - .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), }, { DA9063_LDO(DA9063, LDO11, 900, 50, 3600),
Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed to clean-up all of the existing .suspend variable initialisations. This has led to some 'initilized field overwritten' issues now present in W=1 builds. This patch squashes the following build warnings: In file included from drivers/regulator/da9063-regulator.c:17: include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init] 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’) 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/regulator/da9063-regulator.c | 1 - 1 file changed, 1 deletion(-)