| Message ID | 20200628123654.32830-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio:adc more of_match_ptr and similar removal | expand |
On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Continuation of slow process to try and remove use of of_match_ptr > to supress asignment of the of_device_id table when !CONFIG_OF. suppress assignment ? > Usual argument that it prevents ACPI being used with these drivers > via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the > number of places it can be cut and paste from into new drivers. > > This is just the low hanging fruit. I'm not yet sure if it makes > sense to expend the effort to use generic firmware properties etc > for some of the remaining drivers as it is unlikely they'll ever > be used with anything other than device tree. There are 4 current > ADC drivers in this more complex category. All of them make sense to me, but I did only a shallow review (I would look closer next week). Also, perhaps it makes sense to give people an example of what it looks like in the ACPI table. For example, in the cover letter (this message) mention a link to meta-acpi repository [1] which has a lot of examples [2]. [1]: https://github.com/westeri/meta-acpi [2]: https://github.com/westeri/meta-acpi/tree/master/recipes-bsp/acpi-tables/samples (Edison has most of the examples right now) > Jonathan Cameron (23): > iio:adc:lpc32xx: Drop of_match_ptr protection > iio:adc:axp20x: Convert from OF to generic fw / device properties > iio:adc:hi8435: Drop unused of_gpio.h header > iio:adc:hi8435: Drop of_match_ptr protection. > iio:adc:max1363: Drop of_match_ptr and use generic > device_get_match_data > iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections > iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h > iio:adc:cpcap-adc: Drop of_match_ptr protection and use > device_get_match_data > iio:adc:ltc2497 drop of_match_ptr protection > iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h > include > iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections > iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections > iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections > iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes > iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h > iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections > iio:adc:ti-adc084s021: drop of_match_ptr protection > iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections > iio:adc:ti-adc128s052: drop of_match_ptr protection > iio:adc:ti-adc161s626: Drop of_match_ptr protection. > iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections. > iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to > mod_devicetable.h > iio:adc:ingenic: drop of_match_ptr protection and include > mod_devicetable.h > > drivers/iio/adc/axp20x_adc.c | 10 +++++----- > drivers/iio/adc/bcm_iproc_adc.c | 4 ++-- > drivers/iio/adc/cpcap-adc.c | 22 ++++++---------------- > drivers/iio/adc/hi8435.c | 6 ++---- > drivers/iio/adc/ingenic-adc.c | 5 ++--- > drivers/iio/adc/lpc32xx_adc.c | 5 ++--- > drivers/iio/adc/ltc2496.c | 4 ++-- > drivers/iio/adc/ltc2497.c | 4 ++-- > drivers/iio/adc/max1027.c | 5 ++--- > drivers/iio/adc/max11100.c | 3 ++- > drivers/iio/adc/max1118.c | 7 ++----- > drivers/iio/adc/max1363.c | 11 ++++------- > drivers/iio/adc/mcp320x.c | 5 ++--- > drivers/iio/adc/mcp3422.c | 6 ++---- > drivers/iio/adc/sd_adc_modulator.c | 5 +++-- > drivers/iio/adc/ti-adc081c.c | 6 ++---- > drivers/iio/adc/ti-adc0832.c | 7 ++----- > drivers/iio/adc/ti-adc084s021.c | 3 ++- > drivers/iio/adc/ti-adc108s102.c | 5 ++--- > drivers/iio/adc/ti-adc128s052.c | 3 ++- > drivers/iio/adc/ti-adc161s626.c | 3 ++- > drivers/iio/adc/ti-tlc4541.c | 5 ++--- > 22 files changed, 54 insertions(+), 80 deletions(-) > > -- > 2.27.0 >
On Sun, 28 Jun 2020 20:53:09 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Continuation of slow process to try and remove use of of_match_ptr > > to supress asignment of the of_device_id table when !CONFIG_OF. > > suppress assignment ? Hohum. One day I'll remember to spell check my cover letters. > > > Usual argument that it prevents ACPI being used with these drivers > > via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the > > number of places it can be cut and paste from into new drivers. > > > > This is just the low hanging fruit. I'm not yet sure if it makes > > sense to expend the effort to use generic firmware properties etc > > for some of the remaining drivers as it is unlikely they'll ever > > be used with anything other than device tree. There are 4 current > > ADC drivers in this more complex category. > > All of them make sense to me, but I did only a shallow review (I would > look closer next week). > Also, perhaps it makes sense to give people an example of what it > looks like in the ACPI table. For example, in the cover letter (this > message) mention a link to meta-acpi repository [1] which has a lot of > examples [2]. > > [1]: https://github.com/westeri/meta-acpi > [2]: https://github.com/westeri/meta-acpi/tree/master/recipes-bsp/acpi-tables/samples > (Edison has most of the examples right now) > Nice reference. I'll tidy up any other issues and add that for v2, but probably not until next weekend as somewhat crazy week ahead. Great to have something less dry than the spec to illustrate it. Thanks, Jonathan > > > Jonathan Cameron (23): > > iio:adc:lpc32xx: Drop of_match_ptr protection > > iio:adc:axp20x: Convert from OF to generic fw / device properties > > iio:adc:hi8435: Drop unused of_gpio.h header > > iio:adc:hi8435: Drop of_match_ptr protection. > > iio:adc:max1363: Drop of_match_ptr and use generic > > device_get_match_data > > iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections > > iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h > > iio:adc:cpcap-adc: Drop of_match_ptr protection and use > > device_get_match_data > > iio:adc:ltc2497 drop of_match_ptr protection > > iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h > > include > > iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections > > iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections > > iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections > > iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes > > iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h > > iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections > > iio:adc:ti-adc084s021: drop of_match_ptr protection > > iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections > > iio:adc:ti-adc128s052: drop of_match_ptr protection > > iio:adc:ti-adc161s626: Drop of_match_ptr protection. > > iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections. > > iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to > > mod_devicetable.h > > iio:adc:ingenic: drop of_match_ptr protection and include > > mod_devicetable.h > > > > drivers/iio/adc/axp20x_adc.c | 10 +++++----- > > drivers/iio/adc/bcm_iproc_adc.c | 4 ++-- > > drivers/iio/adc/cpcap-adc.c | 22 ++++++---------------- > > drivers/iio/adc/hi8435.c | 6 ++---- > > drivers/iio/adc/ingenic-adc.c | 5 ++--- > > drivers/iio/adc/lpc32xx_adc.c | 5 ++--- > > drivers/iio/adc/ltc2496.c | 4 ++-- > > drivers/iio/adc/ltc2497.c | 4 ++-- > > drivers/iio/adc/max1027.c | 5 ++--- > > drivers/iio/adc/max11100.c | 3 ++- > > drivers/iio/adc/max1118.c | 7 ++----- > > drivers/iio/adc/max1363.c | 11 ++++------- > > drivers/iio/adc/mcp320x.c | 5 ++--- > > drivers/iio/adc/mcp3422.c | 6 ++---- > > drivers/iio/adc/sd_adc_modulator.c | 5 +++-- > > drivers/iio/adc/ti-adc081c.c | 6 ++---- > > drivers/iio/adc/ti-adc0832.c | 7 ++----- > > drivers/iio/adc/ti-adc084s021.c | 3 ++- > > drivers/iio/adc/ti-adc108s102.c | 5 ++--- > > drivers/iio/adc/ti-adc128s052.c | 3 ++- > > drivers/iio/adc/ti-adc161s626.c | 3 ++- > > drivers/iio/adc/ti-tlc4541.c | 5 ++--- > > 22 files changed, 54 insertions(+), 80 deletions(-) > > > > -- > > 2.27.0 > > > >
On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Continuation of slow process to try and remove use of of_match_ptr > to supress asignment of the of_device_id table when !CONFIG_OF. > > Usual argument that it prevents ACPI being used with these drivers > via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the > number of places it can be cut and paste from into new drivers. > > This is just the low hanging fruit. I'm not yet sure if it makes > sense to expend the effort to use generic firmware properties etc > for some of the remaining drivers as it is unlikely they'll ever > be used with anything other than device tree. There are 4 current > ADC drivers in this more complex category. For the non-commented, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Commented with LGTM also can have Rb tag. The rest, please consider to address. Thanks for a nice clean up! > > Jonathan Cameron (23): > iio:adc:lpc32xx: Drop of_match_ptr protection > iio:adc:axp20x: Convert from OF to generic fw / device properties > iio:adc:hi8435: Drop unused of_gpio.h header > iio:adc:hi8435: Drop of_match_ptr protection. > iio:adc:max1363: Drop of_match_ptr and use generic > device_get_match_data > iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections > iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h > iio:adc:cpcap-adc: Drop of_match_ptr protection and use > device_get_match_data > iio:adc:ltc2497 drop of_match_ptr protection > iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h > include > iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections > iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections > iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections > iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes > iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h > iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections > iio:adc:ti-adc084s021: drop of_match_ptr protection > iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections > iio:adc:ti-adc128s052: drop of_match_ptr protection > iio:adc:ti-adc161s626: Drop of_match_ptr protection. > iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections. > iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to > mod_devicetable.h > iio:adc:ingenic: drop of_match_ptr protection and include > mod_devicetable.h > > drivers/iio/adc/axp20x_adc.c | 10 +++++----- > drivers/iio/adc/bcm_iproc_adc.c | 4 ++-- > drivers/iio/adc/cpcap-adc.c | 22 ++++++---------------- > drivers/iio/adc/hi8435.c | 6 ++---- > drivers/iio/adc/ingenic-adc.c | 5 ++--- > drivers/iio/adc/lpc32xx_adc.c | 5 ++--- > drivers/iio/adc/ltc2496.c | 4 ++-- > drivers/iio/adc/ltc2497.c | 4 ++-- > drivers/iio/adc/max1027.c | 5 ++--- > drivers/iio/adc/max11100.c | 3 ++- > drivers/iio/adc/max1118.c | 7 ++----- > drivers/iio/adc/max1363.c | 11 ++++------- > drivers/iio/adc/mcp320x.c | 5 ++--- > drivers/iio/adc/mcp3422.c | 6 ++---- > drivers/iio/adc/sd_adc_modulator.c | 5 +++-- > drivers/iio/adc/ti-adc081c.c | 6 ++---- > drivers/iio/adc/ti-adc0832.c | 7 ++----- > drivers/iio/adc/ti-adc084s021.c | 3 ++- > drivers/iio/adc/ti-adc108s102.c | 5 ++--- > drivers/iio/adc/ti-adc128s052.c | 3 ++- > drivers/iio/adc/ti-adc161s626.c | 3 ++- > drivers/iio/adc/ti-tlc4541.c | 5 ++--- > 22 files changed, 54 insertions(+), 80 deletions(-) > > -- > 2.27.0 >
On Tue, 30 Jun 2020 10:27:49 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Continuation of slow process to try and remove use of of_match_ptr > > to supress asignment of the of_device_id table when !CONFIG_OF. > > > > Usual argument that it prevents ACPI being used with these drivers > > via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the > > number of places it can be cut and paste from into new drivers. > > > > This is just the low hanging fruit. I'm not yet sure if it makes > > sense to expend the effort to use generic firmware properties etc > > for some of the remaining drivers as it is unlikely they'll ever > > be used with anything other than device tree. There are 4 current > > ADC drivers in this more complex category. > > For the non-commented, > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Commented with LGTM also can have Rb tag. > The rest, please consider to address. > > Thanks for a nice clean up! Thanks for your hard work going through all these. I've applied all the good ones and will respin the others. Thanks, Jonathan > > > > > Jonathan Cameron (23): > > iio:adc:lpc32xx: Drop of_match_ptr protection > > iio:adc:axp20x: Convert from OF to generic fw / device properties > > iio:adc:hi8435: Drop unused of_gpio.h header > > iio:adc:hi8435: Drop of_match_ptr protection. > > iio:adc:max1363: Drop of_match_ptr and use generic > > device_get_match_data > > iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections > > iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h > > iio:adc:cpcap-adc: Drop of_match_ptr protection and use > > device_get_match_data > > iio:adc:ltc2497 drop of_match_ptr protection > > iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h > > include > > iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections > > iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections > > iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections > > iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes > > iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h > > iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections > > iio:adc:ti-adc084s021: drop of_match_ptr protection > > iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections > > iio:adc:ti-adc128s052: drop of_match_ptr protection > > iio:adc:ti-adc161s626: Drop of_match_ptr protection. > > iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections. > > iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to > > mod_devicetable.h > > iio:adc:ingenic: drop of_match_ptr protection and include > > mod_devicetable.h > > > > drivers/iio/adc/axp20x_adc.c | 10 +++++----- > > drivers/iio/adc/bcm_iproc_adc.c | 4 ++-- > > drivers/iio/adc/cpcap-adc.c | 22 ++++++---------------- > > drivers/iio/adc/hi8435.c | 6 ++---- > > drivers/iio/adc/ingenic-adc.c | 5 ++--- > > drivers/iio/adc/lpc32xx_adc.c | 5 ++--- > > drivers/iio/adc/ltc2496.c | 4 ++-- > > drivers/iio/adc/ltc2497.c | 4 ++-- > > drivers/iio/adc/max1027.c | 5 ++--- > > drivers/iio/adc/max11100.c | 3 ++- > > drivers/iio/adc/max1118.c | 7 ++----- > > drivers/iio/adc/max1363.c | 11 ++++------- > > drivers/iio/adc/mcp320x.c | 5 ++--- > > drivers/iio/adc/mcp3422.c | 6 ++---- > > drivers/iio/adc/sd_adc_modulator.c | 5 +++-- > > drivers/iio/adc/ti-adc081c.c | 6 ++---- > > drivers/iio/adc/ti-adc0832.c | 7 ++----- > > drivers/iio/adc/ti-adc084s021.c | 3 ++- > > drivers/iio/adc/ti-adc108s102.c | 5 ++--- > > drivers/iio/adc/ti-adc128s052.c | 3 ++- > > drivers/iio/adc/ti-adc161s626.c | 3 ++- > > drivers/iio/adc/ti-tlc4541.c | 5 ++--- > > 22 files changed, 54 insertions(+), 80 deletions(-) > > > > -- > > 2.27.0 > > > >
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> Continuation of slow process to try and remove use of of_match_ptr to supress asignment of the of_device_id table when !CONFIG_OF. Usual argument that it prevents ACPI being used with these drivers via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the number of places it can be cut and paste from into new drivers. This is just the low hanging fruit. I'm not yet sure if it makes sense to expend the effort to use generic firmware properties etc for some of the remaining drivers as it is unlikely they'll ever be used with anything other than device tree. There are 4 current ADC drivers in this more complex category. Jonathan Cameron (23): iio:adc:lpc32xx: Drop of_match_ptr protection iio:adc:axp20x: Convert from OF to generic fw / device properties iio:adc:hi8435: Drop unused of_gpio.h header iio:adc:hi8435: Drop of_match_ptr protection. iio:adc:max1363: Drop of_match_ptr and use generic device_get_match_data iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h iio:adc:cpcap-adc: Drop of_match_ptr protection and use device_get_match_data iio:adc:ltc2497 drop of_match_ptr protection iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h include iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections iio:adc:ti-adc084s021: drop of_match_ptr protection iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections iio:adc:ti-adc128s052: drop of_match_ptr protection iio:adc:ti-adc161s626: Drop of_match_ptr protection. iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections. iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to mod_devicetable.h iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h drivers/iio/adc/axp20x_adc.c | 10 +++++----- drivers/iio/adc/bcm_iproc_adc.c | 4 ++-- drivers/iio/adc/cpcap-adc.c | 22 ++++++---------------- drivers/iio/adc/hi8435.c | 6 ++---- drivers/iio/adc/ingenic-adc.c | 5 ++--- drivers/iio/adc/lpc32xx_adc.c | 5 ++--- drivers/iio/adc/ltc2496.c | 4 ++-- drivers/iio/adc/ltc2497.c | 4 ++-- drivers/iio/adc/max1027.c | 5 ++--- drivers/iio/adc/max11100.c | 3 ++- drivers/iio/adc/max1118.c | 7 ++----- drivers/iio/adc/max1363.c | 11 ++++------- drivers/iio/adc/mcp320x.c | 5 ++--- drivers/iio/adc/mcp3422.c | 6 ++---- drivers/iio/adc/sd_adc_modulator.c | 5 +++-- drivers/iio/adc/ti-adc081c.c | 6 ++---- drivers/iio/adc/ti-adc0832.c | 7 ++----- drivers/iio/adc/ti-adc084s021.c | 3 ++- drivers/iio/adc/ti-adc108s102.c | 5 ++--- drivers/iio/adc/ti-adc128s052.c | 3 ++- drivers/iio/adc/ti-adc161s626.c | 3 ++- drivers/iio/adc/ti-tlc4541.c | 5 ++--- 22 files changed, 54 insertions(+), 80 deletions(-)