| Message ID | 20200629140442.1043957-9-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix a bunch more W=1 warnings in Misc | expand |
On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@linaro.org> wrote: > > No attempt to check the return value of RREG32() has been made > since the call was introduced a year ago. > > Fixes W=1 kernel build warning: > > drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’: > drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] > 643 | u32 val; > | ^~~ > > Cc: Oded Gabbay <oded.gabbay@gmail.com> > Cc: Tomer Tayar <ttayar@habana.ai> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/misc/habanalabs/goya/goya_coresight.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/habanalabs/goya/goya_coresight.c b/drivers/misc/habanalabs/goya/goya_coresight.c > index 1258724ea5106..aa51fc71f0a1f 100644 > --- a/drivers/misc/habanalabs/goya/goya_coresight.c > +++ b/drivers/misc/habanalabs/goya/goya_coresight.c > @@ -640,7 +640,6 @@ static int goya_config_spmu(struct hl_device *hdev, > int goya_debug_coresight(struct hl_device *hdev, void *data) > { > struct hl_debug_params *params = data; > - u32 val; > int rc = 0; > > switch (params->op) { > @@ -672,7 +671,7 @@ int goya_debug_coresight(struct hl_device *hdev, void *data) > } > > /* Perform read from the device to flush all configuration */ > - val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); > + RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); > > return rc; > } > -- > 2.25.1 > This patch is: Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
diff --git a/drivers/misc/habanalabs/goya/goya_coresight.c b/drivers/misc/habanalabs/goya/goya_coresight.c index 1258724ea5106..aa51fc71f0a1f 100644 --- a/drivers/misc/habanalabs/goya/goya_coresight.c +++ b/drivers/misc/habanalabs/goya/goya_coresight.c @@ -640,7 +640,6 @@ static int goya_config_spmu(struct hl_device *hdev, int goya_debug_coresight(struct hl_device *hdev, void *data) { struct hl_debug_params *params = data; - u32 val; int rc = 0; switch (params->op) { @@ -672,7 +671,7 @@ int goya_debug_coresight(struct hl_device *hdev, void *data) } /* Perform read from the device to flush all configuration */ - val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); + RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); return rc; }
No attempt to check the return value of RREG32() has been made since the call was introduced a year ago. Fixes W=1 kernel build warning: drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’: drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] 643 | u32 val; | ^~~ Cc: Oded Gabbay <oded.gabbay@gmail.com> Cc: Tomer Tayar <ttayar@habana.ai> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/misc/habanalabs/goya/goya_coresight.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)