| Message ID | 20200629120346.4382-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: improve devres helpers | expand |
On Mon, 29 Jun 2020 14:03:36 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > So it seems like there's no support for relaxing certain networking devres > helpers to not require previously allocated structures to also be managed. > However the way mdio devres variants are implemented is still wrong and I > modified my series to address it while keeping the functions strict. > > First two patches modify the ixgbe driver to get rid of the last user of > devm_mdiobus_free(). > > Patches 3, 4, 5 and 6 are mostly cosmetic. > > Patch 7 fixes the way devm_mdiobus_register() is implemented. > > Patches 8 & 9 provide a managed variant of of_mdiobus_register() and > last patch uses it in mtk-star-emac driver. > > v1 -> v2: > - drop the patch relaxing devm_register_netdev() > - require struct mii_bus to be managed in devm_mdiobus_register() and > devm_of_mdiobus_register() but don't store that information in the > structure itself: use devres_find() instead Acked-by: Jakub Kicinski <kuba@kernel.org>
From: Bartosz Golaszewski <brgl@bgdev.pl> Date: Mon, 29 Jun 2020 14:03:36 +0200 > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > So it seems like there's no support for relaxing certain networking devres > helpers to not require previously allocated structures to also be managed. > However the way mdio devres variants are implemented is still wrong and I > modified my series to address it while keeping the functions strict. > > First two patches modify the ixgbe driver to get rid of the last user of > devm_mdiobus_free(). > > Patches 3, 4, 5 and 6 are mostly cosmetic. > > Patch 7 fixes the way devm_mdiobus_register() is implemented. > > Patches 8 & 9 provide a managed variant of of_mdiobus_register() and > last patch uses it in mtk-star-emac driver. > > v1 -> v2: > - drop the patch relaxing devm_register_netdev() > - require struct mii_bus to be managed in devm_mdiobus_register() and > devm_of_mdiobus_register() but don't store that information in the > structure itself: use devres_find() instead Series applied, thank you.
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> So it seems like there's no support for relaxing certain networking devres helpers to not require previously allocated structures to also be managed. However the way mdio devres variants are implemented is still wrong and I modified my series to address it while keeping the functions strict. First two patches modify the ixgbe driver to get rid of the last user of devm_mdiobus_free(). Patches 3, 4, 5 and 6 are mostly cosmetic. Patch 7 fixes the way devm_mdiobus_register() is implemented. Patches 8 & 9 provide a managed variant of of_mdiobus_register() and last patch uses it in mtk-star-emac driver. v1 -> v2: - drop the patch relaxing devm_register_netdev() - require struct mii_bus to be managed in devm_mdiobus_register() and devm_of_mdiobus_register() but don't store that information in the structure itself: use devres_find() instead Bartosz Golaszewski (10): net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init() net: ethernet: ixgbe: don't call devm_mdiobus_free() net: devres: rename the release callback of devm_register_netdev() Documentation: devres: add missing mdio helper phy: un-inline devm_mdiobus_register() phy: mdio: add kerneldoc for __devm_mdiobus_register() net: phy: don't abuse devres in devm_mdiobus_register() of: mdio: remove the 'extern' keyword from function declarations of: mdio: provide devm_of_mdiobus_register() net: ethernet: mtk-star-emac: use devm_of_mdiobus_register() .../driver-api/driver-model/devres.rst | 3 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +- drivers/net/ethernet/mediatek/mtk_star_emac.c | 13 +- drivers/net/ethernet/realtek/r8169_main.c | 2 +- drivers/net/phy/Makefile | 2 + drivers/net/phy/mdio_bus.c | 73 ---------- drivers/net/phy/mdio_devres.c | 133 ++++++++++++++++++ include/linux/of_mdio.h | 40 +++--- include/linux/phy.h | 21 +-- net/devres.c | 4 +- 11 files changed, 174 insertions(+), 137 deletions(-) create mode 100644 drivers/net/phy/mdio_devres.c