| Message ID | 1593115632-31417-1-git-send-email-fenghua.yu@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: hisilicon/qm: Change type of pasid to u32 | expand |
On 2020/6/26 4:07, Fenghua Yu wrote: > PASID is defined as "int" although it's a 20-bit value and shouldn't be > negative int. To be consistent with PASID type in iommu, define PASID > as "u32". > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> Hi Fenghua, Looks good to me, thanks for fixing this. Zhou > --- > PASID type will be changed consistently as u32: > https://lore.kernel.org/patchwork/patch/1257770/ > > drivers/crypto/hisilicon/qm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c > index 9bb263cec6c3..8697dacf926d 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -1741,7 +1741,7 @@ void hisi_qm_release_qp(struct hisi_qp *qp) > } > EXPORT_SYMBOL_GPL(hisi_qm_release_qp); > > -static int qm_qp_ctx_cfg(struct hisi_qp *qp, int qp_id, int pasid) > +static int qm_qp_ctx_cfg(struct hisi_qp *qp, int qp_id, u32 pasid) > { > struct hisi_qm *qm = qp->qm; > struct device *dev = &qm->pdev->dev; > @@ -1813,7 +1813,7 @@ static int qm_start_qp_nolock(struct hisi_qp *qp, unsigned long arg) > struct hisi_qm *qm = qp->qm; > struct device *dev = &qm->pdev->dev; > int qp_id = qp->qp_id; > - int pasid = arg; > + u32 pasid = arg; > int ret; > > if (!qm_qp_avail_state(qm, qp, QP_START)) >
Fenghua Yu <fenghua.yu@intel.com> wrote: > PASID is defined as "int" although it's a 20-bit value and shouldn't be > negative int. To be consistent with PASID type in iommu, define PASID > as "u32". > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > --- > PASID type will be changed consistently as u32: > https://lore.kernel.org/patchwork/patch/1257770/ > > drivers/crypto/hisilicon/qm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 9bb263cec6c3..8697dacf926d 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -1741,7 +1741,7 @@ void hisi_qm_release_qp(struct hisi_qp *qp) } EXPORT_SYMBOL_GPL(hisi_qm_release_qp); -static int qm_qp_ctx_cfg(struct hisi_qp *qp, int qp_id, int pasid) +static int qm_qp_ctx_cfg(struct hisi_qp *qp, int qp_id, u32 pasid) { struct hisi_qm *qm = qp->qm; struct device *dev = &qm->pdev->dev; @@ -1813,7 +1813,7 @@ static int qm_start_qp_nolock(struct hisi_qp *qp, unsigned long arg) struct hisi_qm *qm = qp->qm; struct device *dev = &qm->pdev->dev; int qp_id = qp->qp_id; - int pasid = arg; + u32 pasid = arg; int ret; if (!qm_qp_avail_state(qm, qp, QP_START))
PASID is defined as "int" although it's a 20-bit value and shouldn't be negative int. To be consistent with PASID type in iommu, define PASID as "u32". Suggested-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- PASID type will be changed consistently as u32: https://lore.kernel.org/patchwork/patch/1257770/ drivers/crypto/hisilicon/qm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)