| Message ID | 20200701141329.v2.1.I2cc415fa5793b3e55acfd521ba8f0a71e79aa5f1@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "serial: 8250: Fix max baud limit in generic 8250 port" | expand |
On Wed, Jul 01, 2020 at 02:13:37PM -0700, Daniel Winkler wrote: > This reverts commit 7b668c064ec33f3d687c3a413d05e355172e6c92. > I need a reason _why_ to revert this in the changelog text. Your 0/1 comments would be great to see in here, otherwise I have no idea what is going on when I look at the kernel changelog in the future. > Fixes: 7b668c064ec3 ("serial: 8250: Fix max baud limit in generic 8250 > port") Nit, in the future, this line does not need to be wrapped at all, just let it go the full length please. thanks, greg k-h
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index 1632f7d25acca..e057c65ac1580 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -2618,8 +2618,6 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port, struct ktermios *termios, struct ktermios *old) { - unsigned int tolerance = port->uartclk / 100; - /* * Ask the core to calculate the divisor for us. * Allow 1% tolerance at the upper limit so uart clks marginally @@ -2628,7 +2626,7 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port, */ return uart_get_baud_rate(port, termios, old, port->uartclk / 16 / UART_DIV_MAX, - (port->uartclk + tolerance) / 16); + port->uartclk); } void
This reverts commit 7b668c064ec33f3d687c3a413d05e355172e6c92. Fixes: 7b668c064ec3 ("serial: 8250: Fix max baud limit in generic 8250 port") Cc: stable@vger.kernel.org Signed-off-by: Daniel Winkler <danielwinkler@google.com> --- drivers/tty/serial/8250/8250_port.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)