| Message ID | 20200702152710.84602-1-laurent@vivier.eu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Le 02/07/2020 à 17:26, Laurent Vivier a écrit : > The following changes since commit e7651153a8801dad6805d450ea8bef9b46c1adf5: > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-gsoc-queue-jun-27-2020' into staging (2020-06-27 22:57:36 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-5.1-pull-request > > for you to fetch changes up to 89ddeec7f060a9f403aead414bb883a52f2b5024: > > MAINTAINERS: update linux-user maintainer (2020-07-02 16:55:16 +0200) > > ---------------------------------------------------------------- > linux-user pull request 2020-07-02 > > Update linux-user maintainer > Improve strace output for some syscalls > Display contents of ioctl() parameters > Fix sparc64 flushw operation > > ---------------------------------------------------------------- > > Chen Gang (1): > linux-user: syscall: ioctls: support DRM_IOCTL_VERSION > > Filip Bozuta (8): > linux-user: Extend strace support to enable argument printing after > syscall execution > linux-user: Add strace support for a group of syscalls > linux-user: Add strace support for printing argument of syscalls used > for extended attributes > linux-user: Add strace support for printing arguments of lseek() > linux-user: Add strace support for printing arguments of > chown()/lchown() > linux-user: Add strace support for printing arguments of fallocate() > linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS > linux-user: Add strace support for printing arguments of ioctl() > > Giuseppe Musacchio (2): > target/sparc: Translate flushw opcode > linux-user/sparc64: Fix the handling of window spill trap > > Riku Voipio (1): > MAINTAINERS: update linux-user maintainer > > MAINTAINERS | 3 +- > bsd-user/main.c | 6 +- > configure | 10 + > include/exec/user/thunk.h | 1 + > linux-user/ioctls.h | 17 +- > linux-user/qemu.h | 40 +++- > linux-user/sparc/cpu_loop.c | 6 +- > linux-user/strace.c | 435 +++++++++++++++++++++++++++++++----- > linux-user/strace.list | 40 ++-- > linux-user/syscall.c | 136 ++++++++--- > linux-user/syscall_defs.h | 15 ++ > linux-user/syscall_types.h | 33 +++ > target/sparc/translate.c | 2 + > thunk.c | 154 +++++++++++++ > 14 files changed, 782 insertions(+), 116 deletions(-) > It's not a v2: I forgot to reset my gitpublishprefix before sending my PR after my previous PR with a v2. Thanks, Laurent
Patchew URL: https://patchew.org/QEMU/20200702152710.84602-1-laurent@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL v2 00/12] Linux user for 5.1 patches
Type: series
Message-id: 20200702152710.84602-1-laurent@vivier.eu
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200702152710.84602-1-laurent@vivier.eu -> patchew/20200702152710.84602-1-laurent@vivier.eu
Switched to a new branch 'test'
b82a9f6 MAINTAINERS: update linux-user maintainer
c526dc1 linux-user: Add strace support for printing arguments of ioctl()
2435ebf linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS
52f0002 linux-user: Add strace support for printing arguments of fallocate()
e4871f7 linux-user: Add strace support for printing arguments of chown()/lchown()
ad82e1a linux-user: Add strace support for printing arguments of lseek()
8567ef8 linux-user: Add strace support for printing argument of syscalls used for extended attributes
d3d5da1 linux-user: Add strace support for a group of syscalls
8426f88 linux-user: Extend strace support to enable argument printing after syscall execution
c67a17b linux-user: syscall: ioctls: support DRM_IOCTL_VERSION
a6cfbc0 linux-user/sparc64: Fix the handling of window spill trap
e69906e target/sparc: Translate flushw opcode
=== OUTPUT BEGIN ===
1/12 Checking commit e69906e3f54d (target/sparc: Translate flushw opcode)
2/12 Checking commit a6cfbc0574a2 (linux-user/sparc64: Fix the handling of window spill trap)
3/12 Checking commit c67a17b068f8 (linux-user: syscall: ioctls: support DRM_IOCTL_VERSION)
4/12 Checking commit 8426f882ddc2 (linux-user: Extend strace support to enable argument printing after syscall execution)
5/12 Checking commit d3d5da1be53f (linux-user: Add strace support for a group of syscalls)
6/12 Checking commit 8567ef874043 (linux-user: Add strace support for printing argument of syscalls used for extended attributes)
7/12 Checking commit ad82e1a15420 (linux-user: Add strace support for printing arguments of lseek())
8/12 Checking commit e4871f7d436a (linux-user: Add strace support for printing arguments of chown()/lchown())
9/12 Checking commit 52f00022a735 (linux-user: Add strace support for printing arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#72: FILE: linux-user/strace.c:1138:
+UNUSED static struct flags falloc_flags[] = {
total: 1 errors, 0 warnings, 104 lines checked
Patch 9/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/12 Checking commit 2435ebff393e (linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS)
11/12 Checking commit c526dc1e8d40 (linux-user: Add strace support for printing arguments of ioctl())
12/12 Checking commit b82a9f6f7cfe (MAINTAINERS: update linux-user maintainer)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200702152710.84602-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200702152710.84602-1-laurent@vivier.eu/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === The full log is available at http://patchew.org/logs/20200702152710.84602-1-laurent@vivier.eu/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200702152710.84602-1-laurent@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL v2 00/12] Linux user for 5.1 patches
Type: series
Message-id: 20200702152710.84602-1-laurent@vivier.eu
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
d0c8b95..64f0ad8 master -> master
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200702152710.84602-1-laurent@vivier.eu -> patchew/20200702152710.84602-1-laurent@vivier.eu
Switched to a new branch 'test'
91036ff MAINTAINERS: update linux-user maintainer
12990b4 linux-user: Add strace support for printing arguments of ioctl()
f557b4b linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS
edb4cca linux-user: Add strace support for printing arguments of fallocate()
3662b47 linux-user: Add strace support for printing arguments of chown()/lchown()
c8941f9 linux-user: Add strace support for printing arguments of lseek()
7679394 linux-user: Add strace support for printing argument of syscalls used for extended attributes
f503df8 linux-user: Add strace support for a group of syscalls
6eade26 linux-user: Extend strace support to enable argument printing after syscall execution
4477034 linux-user: syscall: ioctls: support DRM_IOCTL_VERSION
60bb835 linux-user/sparc64: Fix the handling of window spill trap
98c30ba target/sparc: Translate flushw opcode
=== OUTPUT BEGIN ===
1/12 Checking commit 98c30baad825 (target/sparc: Translate flushw opcode)
2/12 Checking commit 60bb835dae23 (linux-user/sparc64: Fix the handling of window spill trap)
3/12 Checking commit 4477034ab57c (linux-user: syscall: ioctls: support DRM_IOCTL_VERSION)
4/12 Checking commit 6eade26a79c8 (linux-user: Extend strace support to enable argument printing after syscall execution)
5/12 Checking commit f503df82431b (linux-user: Add strace support for a group of syscalls)
6/12 Checking commit 76793949e17d (linux-user: Add strace support for printing argument of syscalls used for extended attributes)
7/12 Checking commit c8941f977cc1 (linux-user: Add strace support for printing arguments of lseek())
8/12 Checking commit 3662b47d1c39 (linux-user: Add strace support for printing arguments of chown()/lchown())
9/12 Checking commit edb4cca2c724 (linux-user: Add strace support for printing arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#72: FILE: linux-user/strace.c:1138:
+UNUSED static struct flags falloc_flags[] = {
total: 1 errors, 0 warnings, 104 lines checked
Patch 9/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/12 Checking commit f557b4bc52b8 (linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS)
11/12 Checking commit 12990b4cae13 (linux-user: Add strace support for printing arguments of ioctl())
12/12 Checking commit 91036ff93594 (MAINTAINERS: update linux-user maintainer)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200702152710.84602-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, 2 Jul 2020 at 16:31, Laurent Vivier <laurent@vivier.eu> wrote: > > The following changes since commit e7651153a8801dad6805d450ea8bef9b46c1adf5: > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-gsoc-queue-jun-27-2020' into staging (2020-06-27 22:57:36 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-5.1-pull-request > > for you to fetch changes up to 89ddeec7f060a9f403aead414bb883a52f2b5024: > > MAINTAINERS: update linux-user maintainer (2020-07-02 16:55:16 +0200) > > ---------------------------------------------------------------- > linux-user pull request 2020-07-02 > > Update linux-user maintainer > Improve strace output for some syscalls > Display contents of ioctl() parameters > Fix sparc64 flushw operation > Hi; I'm afraid this failed to build on 32-bit arm: /home/peter.maydell/qemu/thunk.c: In function 'thunk_print': /home/peter.maydell/qemu/thunk.c:304:51: error: expected expression before ')' token qemu_log("%" PRIu32, tswap32(*(uint32_t *))arg); ^ /home/peter.maydell/qemu/rules.mak:69: recipe for target 'thunk.o' failed Looks like a misplaced close-bracket in a section of code that's inside #if HOST_LONG_BITS == 32 && TARGET_ABI_BITS == 32. thanks -- PMM
Le 03/07/2020 à 16:23, Peter Maydell a écrit : > On Thu, 2 Jul 2020 at 16:31, Laurent Vivier <laurent@vivier.eu> wrote: >> >> The following changes since commit e7651153a8801dad6805d450ea8bef9b46c1adf5: >> >> Merge remote-tracking branch 'remotes/amarkovic/tags/mips-gsoc-queue-jun-27-2020' into staging (2020-06-27 22:57:36 +0100) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/linux-user-for-5.1-pull-request >> >> for you to fetch changes up to 89ddeec7f060a9f403aead414bb883a52f2b5024: >> >> MAINTAINERS: update linux-user maintainer (2020-07-02 16:55:16 +0200) >> >> ---------------------------------------------------------------- >> linux-user pull request 2020-07-02 >> >> Update linux-user maintainer >> Improve strace output for some syscalls >> Display contents of ioctl() parameters >> Fix sparc64 flushw operation >> > > Hi; I'm afraid this failed to build on 32-bit arm: > > /home/peter.maydell/qemu/thunk.c: In function 'thunk_print': > /home/peter.maydell/qemu/thunk.c:304:51: error: expected expression > before ')' token > qemu_log("%" PRIu32, tswap32(*(uint32_t *))arg); > ^ > /home/peter.maydell/qemu/rules.mak:69: recipe for target 'thunk.o' failed > > Looks like a misplaced close-bracket in a section of code > that's inside #if HOST_LONG_BITS == 32 && TARGET_ABI_BITS == 32. Thank you, I will fix that. Laurent
The following changes since commit e7651153a8801dad6805d450ea8bef9b46c1adf5: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-gsoc-queue-jun-27-2020' into staging (2020-06-27 22:57:36 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.1-pull-request for you to fetch changes up to 89ddeec7f060a9f403aead414bb883a52f2b5024: MAINTAINERS: update linux-user maintainer (2020-07-02 16:55:16 +0200) ---------------------------------------------------------------- linux-user pull request 2020-07-02 Update linux-user maintainer Improve strace output for some syscalls Display contents of ioctl() parameters Fix sparc64 flushw operation ---------------------------------------------------------------- Chen Gang (1): linux-user: syscall: ioctls: support DRM_IOCTL_VERSION Filip Bozuta (8): linux-user: Extend strace support to enable argument printing after syscall execution linux-user: Add strace support for a group of syscalls linux-user: Add strace support for printing argument of syscalls used for extended attributes linux-user: Add strace support for printing arguments of lseek() linux-user: Add strace support for printing arguments of chown()/lchown() linux-user: Add strace support for printing arguments of fallocate() linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS linux-user: Add strace support for printing arguments of ioctl() Giuseppe Musacchio (2): target/sparc: Translate flushw opcode linux-user/sparc64: Fix the handling of window spill trap Riku Voipio (1): MAINTAINERS: update linux-user maintainer MAINTAINERS | 3 +- bsd-user/main.c | 6 +- configure | 10 + include/exec/user/thunk.h | 1 + linux-user/ioctls.h | 17 +- linux-user/qemu.h | 40 +++- linux-user/sparc/cpu_loop.c | 6 +- linux-user/strace.c | 435 +++++++++++++++++++++++++++++++----- linux-user/strace.list | 40 ++-- linux-user/syscall.c | 136 ++++++++--- linux-user/syscall_defs.h | 15 ++ linux-user/syscall_types.h | 33 +++ target/sparc/translate.c | 2 + thunk.c | 154 +++++++++++++ 14 files changed, 782 insertions(+), 116 deletions(-)