[v2,0/6] phy: meson8b-usb2: small fixes and improvements

Message

Martin Blumenstingl May 12, 2020, 10:24 p.m. UTC

This is a batch of fixes and improvements for the phy-meson8b-usb2
driver:
- convert the existing dt-bindings to json-schema and add a fallback
  compatible string which is already in existing .dtsi files
- differentiate between Meson8 and Meson8m2 using a new compatible
  string for the latter
- simplify the code by using a MMIO regmap
- set / unset the IDDQ and ACA enable bits depending on the operating
  mode (and for the latter also the compatible string)

I suggest that all of these are applied to -next because we will need a
separate .dts patch (which I already have prepared) to use the new
Meson8m2 compatible string in meson8m2.dtsi. Otherwise we will be
changing behavior in patch #4, because meson8m2.dtsi currently inherits
the Meson8 compatible string.
The number of actual Meson8 users is very small (I only know one case),
so keeping Meson8m2 working is more important to me (because I know
several users with boards that have a Meson8m2 SoC).


Changes since v1 at [0]:
- added Thomas' Tested-bys (thank you!)
- also switched to the correct email address of Thomas for Reported-by
  in patch #4
- added two more spaces for the indentation of the compatible "enum",
  fixed the indentation (was three instead of two spaces) of the
  phy-supply property and added additionalProperties: false. All
  spotted in patch #1 by Rob - thank you!
- added Rob's Acked-by to patch #2 (thank you!), after fixing up the
  indentation to also use four spaces (same as in patch #1)


[0] https://patchwork.kernel.org/cover/11523811/


Martin Blumenstingl (6):
  dt-bindings: phy: meson8b-usb2: Convert to json-schema
  dt-bindings: phy: meson8b-usb2: Add compatible string for Meson8m2
  phy: amlogic: meson8b-usb2: Use a MMIO regmap
  phy: amlogic: meson8b-usb2: Don't set REG_ADP_BC_ACA_ENABLE on Meson8
  phy: amlogic: meson8b-usb2: unset the IDDQ bit during PHY power-on
  phy: amlogic: meson8b-usb2: Add a compatible string for Meson8m2

 .../phy/amlogic,meson8b-usb2-phy.yaml         |  64 ++++++++
 .../bindings/phy/meson8b-usb2-phy.txt         |  28 ----
 drivers/phy/amlogic/Kconfig                   |   3 +-
 drivers/phy/amlogic/phy-meson8b-usb2.c        | 149 ++++++++++++------
 4 files changed, 164 insertions(+), 80 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8b-usb2-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt

Comments

Vinod Koul May 15, 2020, 7:49 a.m. UTC | #1

On 13-05-20, 00:24, Martin Blumenstingl wrote:
> This is a batch of fixes and improvements for the phy-meson8b-usb2
> driver:
> - convert the existing dt-bindings to json-schema and add a fallback
>   compatible string which is already in existing .dtsi files
> - differentiate between Meson8 and Meson8m2 using a new compatible
>   string for the latter
> - simplify the code by using a MMIO regmap
> - set / unset the IDDQ and ACA enable bits depending on the operating
>   mode (and for the latter also the compatible string)
> 
> I suggest that all of these are applied to -next because we will need a
> separate .dts patch (which I already have prepared) to use the new
> Meson8m2 compatible string in meson8m2.dtsi. Otherwise we will be
> changing behavior in patch #4, because meson8m2.dtsi currently inherits
> the Meson8 compatible string.
> The number of actual Meson8 users is very small (I only know one case),
> so keeping Meson8m2 working is more important to me (because I know
> several users with boards that have a Meson8m2 SoC).

Applied all, thanks

[e-mail] July 7, 2020, 6:51 p.m. UTC | #2

Hello:

This series was applied to khilman/linux-amlogic.git (refs/heads/for-next).

On Wed, 13 May 2020 00:24:18 +0200 you wrote:
> This is a batch of fixes and improvements for the phy-meson8b-usb2
> driver:
> - convert the existing dt-bindings to json-schema and add a fallback
>   compatible string which is already in existing .dtsi files
> - differentiate between Meson8 and Meson8m2 using a new compatible
>   string for the latter
> - simplify the code by using a MMIO regmap
> - set / unset the IDDQ and ACA enable bits depending on the operating
>   mode (and for the latter also the compatible string)
> 
> [...]


Here is a summary with links:
  - [v2,1/6] dt-bindings: phy: meson8b-usb2: Convert to json-schema
    https://git.kernel.org/khilman/linux-amlogic/c/41e291904a10233a8f42364ec3f18116de026ab6
  - [v2,2/6] dt-bindings: phy: meson8b-usb2: Add compatible string for Meson8m2
    https://git.kernel.org/khilman/linux-amlogic/c/2c0dd8440312b77b42f8e27fd751015dc8f519ff
  - [v2,3/6] phy: amlogic: meson8b-usb2: Use a MMIO regmap
    https://git.kernel.org/khilman/linux-amlogic/c/de143a40fa7d0acae4295c3b312ec96cc8dd9cd0
  - [v2,4/6] phy: amlogic: meson8b-usb2: Don't set REG_ADP_BC_ACA_ENABLE on Meson8
    https://git.kernel.org/khilman/linux-amlogic/c/6b99262fd2f210284b4d17928fd03bee2f5a4fe1
  - [v2,5/6] phy: amlogic: meson8b-usb2: unset the IDDQ bit during PHY power-on
    https://git.kernel.org/khilman/linux-amlogic/c/7cafc01744067cfaac2d5c0342e6f5deb377100a
  - [v2,6/6] phy: amlogic: meson8b-usb2: Add a compatible string for Meson8m2
    https://git.kernel.org/khilman/linux-amlogic/c/f004be596c28f90fbcc50e1b0f4b29ebab56bfca

You are awesome, thank you!