| Message ID | 20200706234737.32378-1-jcmvbkbc@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | target/xtensa: implement double precision FPU | expand |
Max Filippov <jcmvbkbc@gmail.com> writes: > Hello, > > this series implements double precision floating point unit option for > target/xtensa, updates FPU tests and adds two new CPU cores, one with > FPU2000 option and one with DFPU option. > > Max Filippov (21): > softfloat: make NO_SIGNALING_NANS runtime property > softfloat: pass float_status pointer to pickNaN > softfloat: add xtensa specialization for pickNaNMulAdd I've only looked at the softfloat bits as I'm not familiar with xtensa at all. However you can have a vague: Tested-by: Alex Bennée <alex.bennee@linaro.org> for the series - congratulations you pass your own tests ;-)
On Tue, Jul 7, 2020 at 4:31 AM Alex Bennée <alex.bennee@linaro.org> wrote: > I've only looked at the softfloat bits as I'm not familiar with xtensa Thanks for taking a look! > at all. However you can have a vague: > > Tested-by: Alex Bennée <alex.bennee@linaro.org> > > for the series - congratulations you pass your own tests ;-) Unless you've built toolchains for the newly added cores and run the tests on these cores it only means that new tests are properly disabled for the cores without FPU/DFPU. I'll take it as an independent build test (: -- Thanks. -- Max
Max Filippov <jcmvbkbc@gmail.com> writes: > On Tue, Jul 7, 2020 at 4:31 AM Alex Bennée <alex.bennee@linaro.org> wrote: >> I've only looked at the softfloat bits as I'm not familiar with xtensa > > Thanks for taking a look! > >> at all. However you can have a vague: >> >> Tested-by: Alex Bennée <alex.bennee@linaro.org> >> >> for the series - congratulations you pass your own tests ;-) > > Unless you've built toolchains for the newly added cores and > run the tests on these cores it only means that new tests are > properly disabled for the cores without FPU/DFPU. I'll > take it as an independent build test (: Well it ran some xtensa tests thanks to the docker cross compiler support. Do you know what toolchains we need? Currently we have the following: ENV CPU_LIST csp dc232b dc233c ENV TOOLCHAIN_RELEASE 2018.02 RUN for cpu in $CPU_LIST; do \ curl -#SL http://github.com/foss-xtensa/toolchain/releases/download/$TOOLCHAIN_RELEASE/x86_64-$TOOLCHAIN_RELEASE-xtensa-$cpu-elf.tar.gz \ | tar -xzC /opt; \ done ENV PATH $PATH:/opt/$TOOLCHAIN_RELEASE/xtensa-dc232b-elf/bin:/opt/$TOOLCHAIN_RELEASE/xtensa-dc233c-elf/bin:/opt/$TOOLCHAIN_RELEASE/xtensa-csp-elf/bin
On Tue, Jul 7, 2020 at 12:21 PM Alex Bennée <alex.bennee@linaro.org> wrote: > Well it ran some xtensa tests thanks to the docker cross compiler > support. Do you know what toolchains we need? > > Currently we have the following: > > ENV CPU_LIST csp dc232b dc233c > ENV TOOLCHAIN_RELEASE 2018.02 > > RUN for cpu in $CPU_LIST; do \ > curl -#SL http://github.com/foss-xtensa/toolchain/releases/download/$TOOLCHAIN_RELEASE/x86_64-$TOOLCHAIN_RELEASE-xtensa-$cpu-elf.tar.gz \ Oh, that's a familiar URL. Let me do the new batch of toolchains and add FPU2000/DFPU configurations there. And this is tests/docker/dockerfiles/debian-xtensa-cross.docker, right? I can add new configurations there as well and add one more patch to this series.
Max Filippov <jcmvbkbc@gmail.com> writes: > On Tue, Jul 7, 2020 at 12:21 PM Alex Bennée <alex.bennee@linaro.org> wrote: >> Well it ran some xtensa tests thanks to the docker cross compiler >> support. Do you know what toolchains we need? >> >> Currently we have the following: >> >> ENV CPU_LIST csp dc232b dc233c >> ENV TOOLCHAIN_RELEASE 2018.02 >> >> RUN for cpu in $CPU_LIST; do \ >> curl -#SL http://github.com/foss-xtensa/toolchain/releases/download/$TOOLCHAIN_RELEASE/x86_64-$TOOLCHAIN_RELEASE-xtensa-$cpu-elf.tar.gz \ > > Oh, that's a familiar URL. Let me do the new batch of toolchains and > add FPU2000/DFPU configurations there. > And this is tests/docker/dockerfiles/debian-xtensa-cross.docker, > right? Yep - you could also tweak tests/tcg/configure.sh if you want to handle the presence of the toolchain in your local environment. We might want to expand the configurations emitted to tests/tcg/config-xtensa-softmmu.mak to handle the multiple binaries though unless a single binary can call the relevant toolchains with tweaks to CFLAGS? > I can add new configurations there as well and add one more patch > to this series. Cool ;-)