| Message ID | 20200607194611.24763-1-chen.zhang@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | migration/colo: Optimize COLO framework code | expand |
Hi Dave, Any comments for this series? Thanks Zhang Chen > -----Original Message----- > From: Zhang, Chen <chen.zhang@intel.com> > Sent: Monday, June 8, 2020 3:46 AM > To: Dr . David Alan Gilbert <dgilbert@redhat.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com>; Zhanghailiang > <zhang.zhanghailiang@huawei.com>; Zhang, Chen <chen.zhang@intel.com> > Subject: [PATCH V3 0/3] migration/colo: Optimize COLO framework code > > From: Zhang Chen <chen.zhang@intel.com> > > This series optimize some code of COLO, please review. > > Zhang Chen (3): > migration/colo: Optimize COLO boot code path > migration/colo: Update checkpoint time lately > migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in > migration_iteration_finish > > migration/colo.c | 7 ++----- > migration/migration.c | 12 +++++------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > -- > 2.17.1
* Zhang, Chen (chen.zhang@intel.com) wrote: > Hi Dave, > I think it's OK; I guess Zhanghailiang is going to do a pull for it? One thought about the change of use of MIGRATION_STATUS_ACTIVE; I think it's OK at the moment - but the migration states and the way they change becomes part of the API - changing which states we use can confuse management applications; since there's no libvirt support, I'll leave it to Zhanghailiang to know if that's OK. Dave > > Thanks > Zhang Chen > > > -----Original Message----- > > From: Zhang, Chen <chen.zhang@intel.com> > > Sent: Monday, June 8, 2020 3:46 AM > > To: Dr . David Alan Gilbert <dgilbert@redhat.com>; qemu-dev <qemu- > > devel@nongnu.org> > > Cc: Zhang Chen <zhangckid@gmail.com>; Zhanghailiang > > <zhang.zhanghailiang@huawei.com>; Zhang, Chen <chen.zhang@intel.com> > > Subject: [PATCH V3 0/3] migration/colo: Optimize COLO framework code > > > > From: Zhang Chen <chen.zhang@intel.com> > > > > This series optimize some code of COLO, please review. > > > > Zhang Chen (3): > > migration/colo: Optimize COLO boot code path > > migration/colo: Update checkpoint time lately > > migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in > > migration_iteration_finish > > > > migration/colo.c | 7 ++----- > > migration/migration.c | 12 +++++------- > > 2 files changed, 7 insertions(+), 12 deletions(-) > > > > -- > > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> -----Original Message----- > From: Dr. David Alan Gilbert <dgilbert@redhat.com> > Sent: Wednesday, June 17, 2020 8:26 PM > To: Zhang, Chen <chen.zhang@intel.com> > Cc: qemu-dev <qemu-devel@nongnu.org>; Zhang Chen > <zhangckid@gmail.com>; Zhanghailiang <zhang.zhanghailiang@huawei.com> > Subject: Re: [PATCH V3 0/3] migration/colo: Optimize COLO framework code > > * Zhang, Chen (chen.zhang@intel.com) wrote: > > Hi Dave, > > > > I think it's OK; I guess Zhanghailiang is going to do a pull for it? > One thought about the change of use of MIGRATION_STATUS_ACTIVE; I > think it's OK at the moment - but the migration states and the way they > change becomes part of the API - changing which states we use can confuse > management applications; since there's no libvirt support, I'll leave it to > Zhanghailiang to know if that's OK. Hi Hailiang/Dave, Current upstream libvirt can't support COLO, it looks no new issue for normal migration process. For the future, new COLO migration status is good for COLO enable work on libvirt and upper layer. Thanks Zhang Chen > > Dave > > > > > > Thanks > > Zhang Chen > > > > > -----Original Message----- > > > From: Zhang, Chen <chen.zhang@intel.com> > > > Sent: Monday, June 8, 2020 3:46 AM > > > To: Dr . David Alan Gilbert <dgilbert@redhat.com>; qemu-dev <qemu- > > > devel@nongnu.org> > > > Cc: Zhang Chen <zhangckid@gmail.com>; Zhanghailiang > > > <zhang.zhanghailiang@huawei.com>; Zhang, Chen > <chen.zhang@intel.com> > > > Subject: [PATCH V3 0/3] migration/colo: Optimize COLO framework code > > > > > > From: Zhang Chen <chen.zhang@intel.com> > > > > > > This series optimize some code of COLO, please review. > > > > > > Zhang Chen (3): > > > migration/colo: Optimize COLO boot code path > > > migration/colo: Update checkpoint time lately > > > migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in > > > migration_iteration_finish > > > > > > migration/colo.c | 7 ++----- > > > migration/migration.c | 12 +++++------- > > > 2 files changed, 7 insertions(+), 12 deletions(-) > > > > > > -- > > > 2.17.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Hi Hailiang/Dave, No news for a while, any comments? Thanks Zhang Chen > -----Original Message----- > From: Qemu-devel <qemu-devel- > bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Zhang, Chen > Sent: Monday, June 22, 2020 2:53 PM > To: Dr. David Alan Gilbert <dgilbert@redhat.com> > Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; qemu-dev <qemu- > devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com> > Subject: RE: [PATCH V3 0/3] migration/colo: Optimize COLO framework code > > > > > -----Original Message----- > > From: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Sent: Wednesday, June 17, 2020 8:26 PM > > To: Zhang, Chen <chen.zhang@intel.com> > > Cc: qemu-dev <qemu-devel@nongnu.org>; Zhang Chen > > <zhangckid@gmail.com>; Zhanghailiang > <zhang.zhanghailiang@huawei.com> > > Subject: Re: [PATCH V3 0/3] migration/colo: Optimize COLO framework > > code > > > > * Zhang, Chen (chen.zhang@intel.com) wrote: > > > Hi Dave, > > > > > > > I think it's OK; I guess Zhanghailiang is going to do a pull for it? > > One thought about the change of use of MIGRATION_STATUS_ACTIVE; I > > think it's OK at the moment - but the migration states and the way > > they change becomes part of the API - changing which states we use can > > confuse management applications; since there's no libvirt support, > > I'll leave it to Zhanghailiang to know if that's OK. > > Hi Hailiang/Dave, > > Current upstream libvirt can't support COLO, it looks no new issue for normal > migration process. > For the future, new COLO migration status is good for COLO enable work on > libvirt and upper layer. > > Thanks > Zhang Chen > > > > > Dave > > > > > > > > > > Thanks > > > Zhang Chen > > > > > > > -----Original Message----- > > > > From: Zhang, Chen <chen.zhang@intel.com> > > > > Sent: Monday, June 8, 2020 3:46 AM > > > > To: Dr . David Alan Gilbert <dgilbert@redhat.com>; qemu-dev <qemu- > > > > devel@nongnu.org> > > > > Cc: Zhang Chen <zhangckid@gmail.com>; Zhanghailiang > > > > <zhang.zhanghailiang@huawei.com>; Zhang, Chen > > <chen.zhang@intel.com> > > > > Subject: [PATCH V3 0/3] migration/colo: Optimize COLO framework > > > > code > > > > > > > > From: Zhang Chen <chen.zhang@intel.com> > > > > > > > > This series optimize some code of COLO, please review. > > > > > > > > Zhang Chen (3): > > > > migration/colo: Optimize COLO boot code path > > > > migration/colo: Update checkpoint time lately > > > > migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in > > > > migration_iteration_finish > > > > > > > > migration/colo.c | 7 ++----- > > > > migration/migration.c | 12 +++++------- > > > > 2 files changed, 7 insertions(+), 12 deletions(-) > > > > > > > > -- > > > > 2.17.1 > > > > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >
From: Zhang Chen <chen.zhang@intel.com> This series optimize some code of COLO, please review. Zhang Chen (3): migration/colo: Optimize COLO boot code path migration/colo: Update checkpoint time lately migration/migration.c: Remove MIGRATION_STATUS_ACTIVE in migration_iteration_finish migration/colo.c | 7 ++----- migration/migration.c | 12 +++++------- 2 files changed, 7 insertions(+), 12 deletions(-)