| Message ID | 20200707191615.98296-1-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: Clean-up W=1 build warnings��� - part2 | expand |
On Tue, 07 Jul 2020, Pierre-Louis Bossart wrote: > Both Lee Jones and I submitted separate series, this is the second > part of the merged result, for which no feedback was provided. > > I picked Lee's patches for rt5659 and ak4458 and added the pxa and > ux500 that I didn't fix. The rest is largely identical between our > respective series, with the exception of the sunxi which I documented > and Lee removed. I don't have any specific preference and will go with > the flow on this. > > Lee Jones (4): > ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header > ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and > 'reg_val_TSTDR' > ASoC: codecs: rt5659: Remove many unused const variables > ASoC: codecs: ak4458: Remove set but never checked variable 'ret' > > Pierre-Louis Bossart (6): > ASoC: qcom: q6asm: fix kernel-doc > ASoC: sunxi: sun4i-i2s: fix kernel-doc > ASoC: sunxi: sun4i-spdif: fix kernel-doc > ASoC: codecs: rt5631: fix kernel-doc > ASoC: codecs: tlv320aic26: fix kernel-doc warning Would you mind elaborating on "fix kernel-doc". Some tooling relies on the fact that subject lines are, at least for the most part, pretty unique, and if we have to fix another kerneldoc issue in the future with the same thirst for simpleness, I'm afraid there might be clashes. Take a look at my patches, if you require inspiration. > ASoC: sti: uniperif: fix 'defined by not used' warning > > sound/soc/codecs/ak4458.c | 6 +++--- > sound/soc/codecs/rt5631.c | 8 +++++-- > sound/soc/codecs/rt5659.c | 37 --------------------------------- > sound/soc/codecs/tlv320aic26.c | 2 +- > sound/soc/pxa/pxa-ssp.c | 2 +- > sound/soc/qcom/qdsp6/q6asm.c | 2 +- > sound/soc/sti/uniperif.h | 2 +- > sound/soc/sunxi/sun4i-i2s.c | 10 ++++++++- > sound/soc/sunxi/sun4i-spdif.c | 2 +- > sound/soc/ux500/ux500_msp_i2s.c | 8 +++---- > 10 files changed, 27 insertions(+), 52 deletions(-) >
On 7/8/20 1:39 AM, Lee Jones wrote: > On Tue, 07 Jul 2020, Pierre-Louis Bossart wrote: > >> Both Lee Jones and I submitted separate series, this is the second >> part of the merged result, for which no feedback was provided. >> >> I picked Lee's patches for rt5659 and ak4458 and added the pxa and >> ux500 that I didn't fix. The rest is largely identical between our >> respective series, with the exception of the sunxi which I documented >> and Lee removed. I don't have any specific preference and will go with >> the flow on this. >> >> Lee Jones (4): >> ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header >> ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and >> 'reg_val_TSTDR' >> ASoC: codecs: rt5659: Remove many unused const variables >> ASoC: codecs: ak4458: Remove set but never checked variable 'ret' >> >> Pierre-Louis Bossart (6): >> ASoC: qcom: q6asm: fix kernel-doc >> ASoC: sunxi: sun4i-i2s: fix kernel-doc >> ASoC: sunxi: sun4i-spdif: fix kernel-doc >> ASoC: codecs: rt5631: fix kernel-doc >> ASoC: codecs: tlv320aic26: fix kernel-doc warning > > Would you mind elaborating on "fix kernel-doc". Some tooling relies > on the fact that subject lines are, at least for the most part, pretty > unique, and if we have to fix another kerneldoc issue in the future > with the same thirst for simpleness, I'm afraid there might be > clashes. which tools? seems pretty bad to me to rely on string uniqueness, isn't uniqueness defined by SHA1s? > Take a look at my patches, if you require inspiration. I have a minimalist style for commit subjects but ok, will update them. >> ASoC: sti: uniperif: fix 'defined by not used' warning >> >> sound/soc/codecs/ak4458.c | 6 +++--- >> sound/soc/codecs/rt5631.c | 8 +++++-- >> sound/soc/codecs/rt5659.c | 37 --------------------------------- >> sound/soc/codecs/tlv320aic26.c | 2 +- >> sound/soc/pxa/pxa-ssp.c | 2 +- >> sound/soc/qcom/qdsp6/q6asm.c | 2 +- >> sound/soc/sti/uniperif.h | 2 +- >> sound/soc/sunxi/sun4i-i2s.c | 10 ++++++++- >> sound/soc/sunxi/sun4i-spdif.c | 2 +- >> sound/soc/ux500/ux500_msp_i2s.c | 8 +++---- >> 10 files changed, 27 insertions(+), 52 deletions(-) >> >
On Wed, 08 Jul 2020, Pierre-Louis Bossart wrote: > > > On 7/8/20 1:39 AM, Lee Jones wrote: > > On Tue, 07 Jul 2020, Pierre-Louis Bossart wrote: > > > > > Both Lee Jones and I submitted separate series, this is the second > > > part of the merged result, for which no feedback was provided. > > > > > > I picked Lee's patches for rt5659 and ak4458 and added the pxa and > > > ux500 that I didn't fix. The rest is largely identical between our > > > respective series, with the exception of the sunxi which I documented > > > and Lee removed. I don't have any specific preference and will go with > > > the flow on this. > > > > > > Lee Jones (4): > > > ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header > > > ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and > > > 'reg_val_TSTDR' > > > ASoC: codecs: rt5659: Remove many unused const variables > > > ASoC: codecs: ak4458: Remove set but never checked variable 'ret' > > > > > > Pierre-Louis Bossart (6): > > > ASoC: qcom: q6asm: fix kernel-doc > > > ASoC: sunxi: sun4i-i2s: fix kernel-doc > > > ASoC: sunxi: sun4i-spdif: fix kernel-doc > > > ASoC: codecs: rt5631: fix kernel-doc > > > ASoC: codecs: tlv320aic26: fix kernel-doc warning > > > > Would you mind elaborating on "fix kernel-doc". Some tooling relies > > on the fact that subject lines are, at least for the most part, pretty > > unique, and if we have to fix another kerneldoc issue in the future > > with the same thirst for simpleness, I'm afraid there might be > > clashes. > > which tools? seems pretty bad to me to rely on string uniqueness, isn't > uniqueness defined by SHA1s? SHAs don't work across rebases/cherry-picks. Sometimes subject lines are the most reliable way to 'match'. > > Take a look at my patches, if you require inspiration. > > I have a minimalist style for commit subjects but ok, will update them. I'd appreciated it. Thanks. > > > ASoC: sti: uniperif: fix 'defined by not used' warning > > > > > > sound/soc/codecs/ak4458.c | 6 +++--- > > > sound/soc/codecs/rt5631.c | 8 +++++-- > > > sound/soc/codecs/rt5659.c | 37 --------------------------------- > > > sound/soc/codecs/tlv320aic26.c | 2 +- > > > sound/soc/pxa/pxa-ssp.c | 2 +- > > > sound/soc/qcom/qdsp6/q6asm.c | 2 +- > > > sound/soc/sti/uniperif.h | 2 +- > > > sound/soc/sunxi/sun4i-i2s.c | 10 ++++++++- > > > sound/soc/sunxi/sun4i-spdif.c | 2 +- > > > sound/soc/ux500/ux500_msp_i2s.c | 8 +++---- > > > 10 files changed, 27 insertions(+), 52 deletions(-) > > > > >
On Wed, Jul 08, 2020 at 02:06:06PM +0100, Lee Jones wrote: > On Wed, 08 Jul 2020, Pierre-Louis Bossart wrote: > > > > ASoC: sunxi: sun4i-i2s: fix kernel-doc > > > > ASoC: sunxi: sun4i-spdif: fix kernel-doc > > > > ASoC: codecs: rt5631: fix kernel-doc > > which tools? seems pretty bad to me to rely on string uniqueness, isn't > > uniqueness defined by SHA1s? > SHAs don't work across rebases/cherry-picks. > Sometimes subject lines are the most reliable way to 'match'. Note that all these patches have unique subjects due to the prefixes saying what they're modifying, this is a common pattern for these sorts of repetitive serieses doing broad cleanups.
On Wed, 08 Jul 2020, Mark Brown wrote: > On Wed, Jul 08, 2020 at 02:06:06PM +0100, Lee Jones wrote: > > On Wed, 08 Jul 2020, Pierre-Louis Bossart wrote: > > > > > > ASoC: sunxi: sun4i-i2s: fix kernel-doc > > > > > ASoC: sunxi: sun4i-spdif: fix kernel-doc > > > > > ASoC: codecs: rt5631: fix kernel-doc > > > > which tools? seems pretty bad to me to rely on string uniqueness, isn't > > > uniqueness defined by SHA1s? > > > SHAs don't work across rebases/cherry-picks. > > > Sometimes subject lines are the most reliable way to 'match'. > > Note that all these patches have unique subjects due to the prefixes > saying what they're modifying, this is a common pattern for these sorts > of repetitive serieses doing broad cleanups. Yes, they're unique within *this* set. The fun starts when you conduct another pass a few months/years down the line and have the same lack of imagination. :)
On Wed, Jul 08, 2020 at 02:50:16PM +0100, Lee Jones wrote: > On Wed, 08 Jul 2020, Mark Brown wrote: > > Note that all these patches have unique subjects due to the prefixes > > saying what they're modifying, this is a common pattern for these sorts > > of repetitive serieses doing broad cleanups. > Yes, they're unique within *this* set. The fun starts when you > conduct another pass a few months/years down the line and have the > same lack of imagination. :) If you're doing that sort of tracking over any period of time, especially with this kind of shut up the warnings stuff, you're going to run into issues.
On Tue, 7 Jul 2020 14:16:05 -0500, Pierre-Louis Bossart wrote: > Both Lee Jones and I submitted separate series, this is the second > part of the merged result, for which no feedback was provided. > > I picked Lee's patches for rt5659 and ak4458 and added the pxa and > ux500 that I didn't fix. The rest is largely identical between our > respective series, with the exception of the sunxi which I documented > and Lee removed. I don't have any specific preference and will go with > the flow on this. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [01/10] ASoC: qcom: qdsp6: q6asm: Provide documentation for 'codec_profile' commit: d4633504213eff9913f722da7320e23eecd48b59 [02/10] ASoC: sunxi: sun4i-i2s: add missing clock and format arguments in kernel-doc commit: 643e305e9b2c42800fe73ac0e23bd02ba87fe202 [03/10] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' in kernel-doc commit: c7202a19cf838d2a999e554cffa552bf7f480fde [04/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header commit: 701f4727f7bb35e9dca7e2c65f44af0608ef3d6b [05/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' commit: 79b094c9dcd70123f51e4039ea9a29ebbd073edd [06/10] ASoC: sti: uniperif: fix 'defined by not used' warning commit: 97d73032a89d85437d6be354ef1cfde7dd97a24a [07/10] ASoC: codecs: rt5631: fix spurious kernel-doc start and missing arguments commit: 762a3d4313aa44a2158c95fbc6e95ec19b7add4a [08/10] ASoC: codecs: rt5659: Remove many unused const variables commit: e57f0e4d4a836e37c5af7ddf1a2c3e09c7970239 [09/10] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header commit: c90a67458ee158ba770d656ec66abca81e23f53a [10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' commit: cc3cceedcb7e92ad0a43e5a4a42e653e9d919109 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Both Lee Jones and I submitted separate series, this is the second part of the merged result, for which no feedback was provided. I picked Lee's patches for rt5659 and ak4458 and added the pxa and ux500 that I didn't fix. The rest is largely identical between our respective series, with the exception of the sunxi which I documented and Lee removed. I don't have any specific preference and will go with the flow on this. Lee Jones (4): ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' ASoC: codecs: rt5659: Remove many unused const variables ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Pierre-Louis Bossart (6): ASoC: qcom: q6asm: fix kernel-doc ASoC: sunxi: sun4i-i2s: fix kernel-doc ASoC: sunxi: sun4i-spdif: fix kernel-doc ASoC: sti: uniperif: fix 'defined by not used' warning ASoC: codecs: rt5631: fix kernel-doc ASoC: codecs: tlv320aic26: fix kernel-doc warning sound/soc/codecs/ak4458.c | 6 +++--- sound/soc/codecs/rt5631.c | 8 +++++-- sound/soc/codecs/rt5659.c | 37 --------------------------------- sound/soc/codecs/tlv320aic26.c | 2 +- sound/soc/pxa/pxa-ssp.c | 2 +- sound/soc/qcom/qdsp6/q6asm.c | 2 +- sound/soc/sti/uniperif.h | 2 +- sound/soc/sunxi/sun4i-i2s.c | 10 ++++++++- sound/soc/sunxi/sun4i-spdif.c | 2 +- sound/soc/ux500/ux500_msp_i2s.c | 8 +++---- 10 files changed, 27 insertions(+), 52 deletions(-)