[00/11] ASoC: qdsp6: add gapless compressed audio support

Message

Srinivas Kandagatla July 7, 2020, 4:36 p.m. UTC

This patchset adds gapless compressed audio support on q6asm.
Gapless on q6asm is implemented using 2 streams in a single asm session.

First few patches are enhacements done to q6asm interface to allow
stream id per each command, gapless flags and silence meta data.
Along with this there are few trivial changes which I thought are necessary!
Last patch implements copy callback to allow finer control over buffer offsets,
specially in partial drain cases.

This patchset is tested on RB3 aka DB845c platform.

Thanks,
srini


Srinivas Kandagatla (11):
  ASoC: q6asm: add command opcode to timeout error report
  ASoC: q6asm: rename misleading session id variable
  ASoC: q6asm: make commands specific to streams
  ASoC: q6asm: use flags directly from asm-dai
  ASoC: q6asm: add length to write command token
  ASoC: q6asm: add support to remove intial and trailing silence
  ASoC: q6asm: add support to gapless flag in asm open
  ASoC: q6asm-dai: add next track metadata support
  ASoC: qdsp6: use dev_err instead of pr_err
  ASoC: qdsp6-dai: add gapless support
  ASoC: q6asm-dai: add support to copy callback

 sound/soc/qcom/qdsp6/q6asm-dai.c | 397 +++++++++++++++++++++++--------
 sound/soc/qcom/qdsp6/q6asm.c     | 173 +++++++++-----
 sound/soc/qcom/qdsp6/q6asm.h     |  48 ++--
 3 files changed, 458 insertions(+), 160 deletions(-)

Comments

Mark Brown July 8, 2020, 1:32 p.m. UTC | #1

On Tue, Jul 07, 2020 at 05:36:30PM +0100, Srinivas Kandagatla wrote:

> Along with this there are few trivial changes which I thought are necessary!

It's better to split stuff like this out of the series, or put it near
the start after any fixes if other things depend on it.  That way it can
progress without getting caught up with the rest of the series and the
series gets smaller and more focused.

Srinivas Kandagatla July 8, 2020, 3:24 p.m. UTC | #2

On 08/07/2020 14:32, Mark Brown wrote:
> On Tue, Jul 07, 2020 at 05:36:30PM +0100, Srinivas Kandagatla wrote:
> 
>> Along with this there are few trivial changes which I thought are necessary!
> 
> It's better to split stuff like this out of the series, or put it near
> the start after any fixes if other things depend on it.  That way it can
> progress without getting caught up with the rest of the series and the
> series gets smaller and more focused.
> 
Thanks, I will split the cleanup stuff and send it as separate set!

--srini

Mark Brown July 8, 2020, 4:59 p.m. UTC | #3

On Tue, 7 Jul 2020 17:36:30 +0100, Srinivas Kandagatla wrote:
> This patchset adds gapless compressed audio support on q6asm.
> Gapless on q6asm is implemented using 2 streams in a single asm session.
> 
> First few patches are enhacements done to q6asm interface to allow
> stream id per each command, gapless flags and silence meta data.
> Along with this there are few trivial changes which I thought are necessary!
> Last patch implements copy callback to allow finer control over buffer offsets,
> specially in partial drain cases.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: q6asm: add command opcode to timeout error report
      commit: b6198097b84abcbf9d098ddf5887fe62f9da2e3c
[2/2] ASoC: qdsp6: use dev_err instead of pr_err
      commit: 0579ece8f4de9956ea7087c63f55663ea79283bc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark