| Message ID | 20200626155832.2323789-1-ardb@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64/acpi: restrict AML opregion memory access | expand |
(+ James) On Fri, 26 Jun 2020 at 18:58, Ard Biesheuvel <ardb@kernel.org> wrote: > > v2: > - do a more elaborate check on the region, against the EFI memory map > > v3: > - split into two patches > - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered > by the linear mapping (e.g., when booting a kdump kernel) > > Ard Biesheuvel (2): > arm64/acpi: disallow AML memory opregions to access kernel memory > arm64/acpi: disallow writeable AML opregion mapping for EFI code > regions > With some adult supervision from James (thanks!), I have given this a spin myself with kexec under QEMU/kvm, to boot a crashkernel, and everything works as expected. > arch/arm64/include/asm/acpi.h | 15 +--- > arch/arm64/kernel/acpi.c | 75 ++++++++++++++++++++ > 2 files changed, 76 insertions(+), 14 deletions(-) > > -- > 2.27.0 >
On Fri, Jun 26, 2020 at 05:58:30PM +0200, Ard Biesheuvel wrote: > v2: > - do a more elaborate check on the region, against the EFI memory map > > v3: > - split into two patches > - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered > by the linear mapping (e.g., when booting a kdump kernel) > > Ard Biesheuvel (2): > arm64/acpi: disallow AML memory opregions to access kernel memory > arm64/acpi: disallow writeable AML opregion mapping for EFI code > regions > > arch/arm64/include/asm/acpi.h | 15 +--- > arch/arm64/kernel/acpi.c | 75 ++++++++++++++++++++ > 2 files changed, 76 insertions(+), 14 deletions(-) Thanks Ard for fixing this, for the series: Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
On Fri, 26 Jun 2020 17:58:30 +0200, Ard Biesheuvel wrote: > v2: > - do a more elaborate check on the region, against the EFI memory map > > v3: > - split into two patches > - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered > by the linear mapping (e.g., when booting a kdump kernel) > > [...] Applied to arm64 (for-next/acpi), thanks! [1/2] arm64/acpi: disallow AML memory opregions to access kernel memory https://git.kernel.org/arm64/c/1583052d111f [2/2] arm64/acpi: disallow writeable AML opregion mapping for EFI code regions https://git.kernel.org/arm64/c/325f5585ec36
v2: - do a more elaborate check on the region, against the EFI memory map v3: - split into two patches - fallback to __ioremap() for ACPI reclaim memory, in case it is not covered by the linear mapping (e.g., when booting a kdump kernel) Ard Biesheuvel (2): arm64/acpi: disallow AML memory opregions to access kernel memory arm64/acpi: disallow writeable AML opregion mapping for EFI code regions arch/arm64/include/asm/acpi.h | 15 +--- arch/arm64/kernel/acpi.c | 75 ++++++++++++++++++++ 2 files changed, 76 insertions(+), 14 deletions(-)