| Message ID | 20200707143742.2959960-15-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Clean-up ASoC's W=1 build warnings | expand |
On 7/7/20 16:37, Lee Jones wrote: > Ideally the author or someone 'in the know' should come back and > provide the remainder of the documentation. Until the kerneldoc > checkers have been satisfied, let's just demote the header to a > standard comment block. Thanks for the patch Lee, Pierre-Luis Bossart has already corrected the documentation by adding missing entries in patch: [PATCH v3 03/13] ASoC: samsung: pcm: fix kernel-doc > Fixes the following W=1 kernel build warning(s): > > sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'lock' not described in 's3c_pcm_info' > sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'sclk_per_fs' not described in 's3c_pcm_info' > sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'idleclk' not described in 's3c_pcm_info' > sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'pclk' not described in 's3c_pcm_info' > sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'cclk' not described in 's3c_pcm_info' -- Regards, Sylwester
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index a5b1a12b34966..3116be4239f59 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -102,7 +102,7 @@ #define S3C_PCM_FIFOSTAT_RXFIFOFULL (0x1 << 1) #define S3C_PCM_FIFOSTAT_RXFIFOALMSTFULL (0x1 << 0) -/** +/* * struct s3c_pcm_info - S3C PCM Controller information * @dev: The parent device passed to use from the probe. * @regs: The pointer to the device register block.
Ideally the author or someone 'in the know' should come back and provide the remainder of the documentation. Until the kerneldoc checkers have been satisfied, let's just demote the header to a standard comment block. Fixes the following W=1 kernel build warning(s): sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'lock' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'sclk_per_fs' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'idleclk' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'pclk' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'cclk' not described in 's3c_pcm_info' Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sangbeom Kim <sbkim73@samsung.com> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Jaswinder Singh <jassisinghbrar@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- sound/soc/samsung/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)