| Message ID | 20200709114636.69256-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd06a40201fe8a4db8071b4939fafc5905557b01 |
| Headers | show |
| Series | [-next] scsi: target: Remove unused variable 'tpg' | expand |
On 7/9/20 6:46 AM, Wei Yongjun wrote: > Gcc report warning as follows: > > drivers/target/target_core_pr.c:1162:26: warning: > variable 'tpg' set but not used [-Wunused-but-set-variable] > 1162 | struct se_portal_group *tpg; > | ^~~ > > After commit 63c9ffe473d3 ("scsi: target: Check enforce_pr_isids > during registration"), 'tpg' is never used, so removing it to > avoid build warning. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/target/target_core_pr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c > index 300b03b1b696..8fc88654bff6 100644 > --- a/drivers/target/target_core_pr.c > +++ b/drivers/target/target_core_pr.c > @@ -1159,7 +1159,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( > { > struct t10_reservation *pr_tmpl = &dev->t10_pr; > struct t10_pr_registration *pr_reg, *pr_reg_tmp; > - struct se_portal_group *tpg; > > spin_lock(&pr_tmpl->registration_lock); > list_for_each_entry_safe(pr_reg, pr_reg_tmp, > @@ -1170,7 +1169,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( > if (pr_reg->pr_reg_nacl != nacl) > continue; > > - tpg = pr_reg->pr_reg_nacl->se_tpg; > /* > * If this registration does NOT contain a fabric provided > * ISID, then we have found a match. > Sorry. That was my fault. Thanks. Reviewed-by: Mike Christie <michael.christie@oracle.com>
On 7/9/20 04:36, Wei Yongjun wrote: > Gcc report warning as follows: > > drivers/target/target_core_pr.c:1162:26: warning: > variable 'tpg' set but not used [-Wunused-but-set-variable] > 1162 | struct se_portal_group *tpg; > | ^~~ > > After commit 63c9ffe473d3 ("scsi: target: Check enforce_pr_isids > during registration"), 'tpg' is never used, so removing it to > avoid build warning. > > Reported-by: Hulk Robot<hulkci@huawei.com> > Signed-off-by: Wei Yongjun<weiyongjun1@huawei.com> Looks good to me. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 7/9/20 6:46 AM, Wei Yongjun wrote: > Gcc report warning as follows: > > drivers/target/target_core_pr.c:1162:26: warning: > variable 'tpg' set but not used [-Wunused-but-set-variable] > 1162 | struct se_portal_group *tpg; > | ^~~ > > After commit 63c9ffe473d3 ("scsi: target: Check enforce_pr_isids > during registration"), 'tpg' is never used, so removing it to > avoid build warning. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/target/target_core_pr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c > index 300b03b1b696..8fc88654bff6 100644 > --- a/drivers/target/target_core_pr.c > +++ b/drivers/target/target_core_pr.c > @@ -1159,7 +1159,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( > { > struct t10_reservation *pr_tmpl = &dev->t10_pr; > struct t10_pr_registration *pr_reg, *pr_reg_tmp; > - struct se_portal_group *tpg; > > spin_lock(&pr_tmpl->registration_lock); > list_for_each_entry_safe(pr_reg, pr_reg_tmp, > @@ -1170,7 +1169,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( > if (pr_reg->pr_reg_nacl != nacl) > continue; > > - tpg = pr_reg->pr_reg_nacl->se_tpg; > /* > * If this registration does NOT contain a fabric provided > * ISID, then we have found a match. > Looks Good. Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
On Thu, 9 Jul 2020 19:46:36 +0800, Wei Yongjun wrote: > Gcc report warning as follows: > > drivers/target/target_core_pr.c:1162:26: warning: > variable 'tpg' set but not used [-Wunused-but-set-variable] > 1162 | struct se_portal_group *tpg; > | ^~~ > > [...] Applied to 5.9/scsi-queue, thanks! [1/1] scsi: target: Remove unused variable 'tpg' https://git.kernel.org/mkp/scsi/c/dd06a40201fe
diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 300b03b1b696..8fc88654bff6 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c @@ -1159,7 +1159,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( { struct t10_reservation *pr_tmpl = &dev->t10_pr; struct t10_pr_registration *pr_reg, *pr_reg_tmp; - struct se_portal_group *tpg; spin_lock(&pr_tmpl->registration_lock); list_for_each_entry_safe(pr_reg, pr_reg_tmp, @@ -1170,7 +1169,6 @@ static struct t10_pr_registration *__core_scsi3_locate_pr_reg( if (pr_reg->pr_reg_nacl != nacl) continue; - tpg = pr_reg->pr_reg_nacl->se_tpg; /* * If this registration does NOT contain a fabric provided * ISID, then we have found a match.
Gcc report warning as follows: drivers/target/target_core_pr.c:1162:26: warning: variable 'tpg' set but not used [-Wunused-but-set-variable] 1162 | struct se_portal_group *tpg; | ^~~ After commit 63c9ffe473d3 ("scsi: target: Check enforce_pr_isids during registration"), 'tpg' is never used, so removing it to avoid build warning. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/target/target_core_pr.c | 2 -- 1 file changed, 2 deletions(-)