Message ID | 20200713142551.423649-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [next] drm/i915/selftest: fix an error return path where err is not being set | expand |
Quoting Colin King (2020-07-13 15:25:51) > From: Colin Ian King <colin.king@canonical.com> > > There is an error condition where err is not being set and an uninitialized > garbage value in err is being returned. Fix this by assigning err to an > appropriate error return value before taking the error exit path. > > Addresses-Coverity: ("Uninitialized scalar value") > Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks, pushed. -Chris
diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c index deb6dec1b5ab..7aa73bb03381 100644 --- a/drivers/gpu/drm/i915/selftests/i915_perf.c +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c @@ -329,6 +329,7 @@ static int live_noa_gpr(void *arg) cs = intel_ring_begin(rq, 2 * 32 + 2); if (IS_ERR(cs)) { i915_request_add(rq); + err = PTR_ERR(cs); goto out_rq; }