| Message ID | 20200604203905.31964-1-jcrouse@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a082121b55bac125f7d09d78de00607ea75a6903 |
| Headers | show |
| Series | [v2] iommu/arm-smmu: Mark qcom_smmu_client_of_match as possibly unused | expand |
On Thu, Jun 04, 2020 at 02:39:04PM -0600, Jordan Crouse wrote: > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > keep the compiler from warning in that case. > > Fixes: 0e764a01015d ("iommu/arm-smmu: Allow client devices to select direct mapping") > Reported-by: kbuild test robot <lkp@intel.com> > Acked-by: Will Deacon <will@kernel.org> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > > drivers/iommu/arm-smmu-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > index cf01d0215a39..be4318044f96 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -12,7 +12,7 @@ struct qcom_smmu { > struct arm_smmu_device smmu; > }; > > -static const struct of_device_id qcom_smmu_client_of_match[] = { > +static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = { > { .compatible = "qcom,adreno" }, > { .compatible = "qcom,mdp4" }, > { .compatible = "qcom,mdss" }, Thanks. Joerg -- can you pick this one up, please? I don't have any other SMMU fixes pending at the moment. Cheers, Will
On Mon, Jun 08, 2020 at 04:13:08PM +0100, Will Deacon wrote: > On Thu, Jun 04, 2020 at 02:39:04PM -0600, Jordan Crouse wrote: > > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > > keep the compiler from warning in that case. > > > > Fixes: 0e764a01015d ("iommu/arm-smmu: Allow client devices to select direct mapping") > > Reported-by: kbuild test robot <lkp@intel.com> > > Acked-by: Will Deacon <will@kernel.org> > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > --- > > > > drivers/iommu/arm-smmu-qcom.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > > index cf01d0215a39..be4318044f96 100644 > > --- a/drivers/iommu/arm-smmu-qcom.c > > +++ b/drivers/iommu/arm-smmu-qcom.c > > @@ -12,7 +12,7 @@ struct qcom_smmu { > > struct arm_smmu_device smmu; > > }; > > > > -static const struct of_device_id qcom_smmu_client_of_match[] = { > > +static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = { > > { .compatible = "qcom,adreno" }, > > { .compatible = "qcom,mdp4" }, > > { .compatible = "qcom,mdss" }, > > Thanks. Joerg -- can you pick this one up, please? I don't have any other > SMMU fixes pending at the moment. > > Cheers, > > Will Quick ping to pick this up for 5.8 fixes. Thanks, Jordan
On Mon, Jun 08, 2020 at 04:13:08PM +0100, Will Deacon wrote: > On Thu, Jun 04, 2020 at 02:39:04PM -0600, Jordan Crouse wrote: > > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > > keep the compiler from warning in that case. > > > > Fixes: 0e764a01015d ("iommu/arm-smmu: Allow client devices to select direct mapping") > > Reported-by: kbuild test robot <lkp@intel.com> > > Acked-by: Will Deacon <will@kernel.org> > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > --- > > > > drivers/iommu/arm-smmu-qcom.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c > > index cf01d0215a39..be4318044f96 100644 > > --- a/drivers/iommu/arm-smmu-qcom.c > > +++ b/drivers/iommu/arm-smmu-qcom.c > > @@ -12,7 +12,7 @@ struct qcom_smmu { > > struct arm_smmu_device smmu; > > }; > > > > -static const struct of_device_id qcom_smmu_client_of_match[] = { > > +static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = { > > { .compatible = "qcom,adreno" }, > > { .compatible = "qcom,mdp4" }, > > { .compatible = "qcom,mdss" }, > > Thanks. Joerg -- can you pick this one up, please? I don't have any other > SMMU fixes pending at the moment. I can't see this in Joerg's tree or in linux-next. Joerg: did you pick this one up? (I thought you did, but I can't find it!). Will
On Mon, Jul 13, 2020 at 02:33:26PM +0100, Will Deacon wrote: > I can't see this in Joerg's tree or in linux-next. Joerg: did you pick this > one up? (I thought you did, but I can't find it!). Yes, its in the tree and and will be pushed soon. I'll also send it to Linus today. Joerg
diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers/iommu/arm-smmu-qcom.c index cf01d0215a39..be4318044f96 100644 --- a/drivers/iommu/arm-smmu-qcom.c +++ b/drivers/iommu/arm-smmu-qcom.c @@ -12,7 +12,7 @@ struct qcom_smmu { struct arm_smmu_device smmu; }; -static const struct of_device_id qcom_smmu_client_of_match[] = { +static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = { { .compatible = "qcom,adreno" }, { .compatible = "qcom,mdp4" }, { .compatible = "qcom,mdss" },
When CONFIG_OF=n of_match_device() gets pre-processed out of existence leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to keep the compiler from warning in that case. Fixes: 0e764a01015d ("iommu/arm-smmu: Allow client devices to select direct mapping") Reported-by: kbuild test robot <lkp@intel.com> Acked-by: Will Deacon <will@kernel.org> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- drivers/iommu/arm-smmu-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)