| Message ID | 20200713105100.GA251988@mwanda (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 30f259b4886a0d0121e03516bbff6f057a52a0b2 |
| Headers | show |
| Series | scsi: cxgb4i: clean up a debug printk | expand |
On Mon, Jul 13, 2020 at 10:51:00AM +0000, Dan Carpenter wrote: > The pr_fmt() at the top of the file already includes the __func__ so we > can remove the duplicative "cxgbi_conn_init_pdu:" from the string here. > Now it all fits on one line as well. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/scsi/cxgbi/libcxgbi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index 1fb101c616b7..ba1593be626c 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset, > } > > log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX, > - "cxgbi_conn_init_pdu: tdata->total_count %u, " > - "tdata->total_offset %u\n", > + "data->total_count %u, tdata->total_offset %u\n", > tdata->total_count, tdata->total_offset); > > expected_count = tdata->total_count; Acked-by: Varun Prakash <varun@chelsio.com>
On Mon, 13 Jul 2020 10:51:00 +0000 (UTC), Dan Carpenter wrote: > The pr_fmt() at the top of the file already includes the __func__ so we > can remove the duplicative "cxgbi_conn_init_pdu:" from the string here. > Now it all fits on one line as well. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: cxgb4i: Clean up a debug printk https://git.kernel.org/mkp/scsi/c/30f259b4886a
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c index 1fb101c616b7..ba1593be626c 100644 --- a/drivers/scsi/cxgbi/libcxgbi.c +++ b/drivers/scsi/cxgbi/libcxgbi.c @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset, } log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX, - "cxgbi_conn_init_pdu: tdata->total_count %u, " - "tdata->total_offset %u\n", + "data->total_count %u, tdata->total_offset %u\n", tdata->total_count, tdata->total_offset); expected_count = tdata->total_count;
The pr_fmt() at the top of the file already includes the __func__ so we can remove the duplicative "cxgbi_conn_init_pdu:" from the string here. Now it all fits on one line as well. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/scsi/cxgbi/libcxgbi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)