| Message ID | 20200714142355.29819-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [-next] cpufreq: powernv: Make some symbols static | expand |
On 14-07-20, 22:23, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/cpufreq/powernv-cpufreq.c:88:1: warning: > symbol 'pstate_revmap' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:383:18: warning: > symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: > symbol 'gpstate_timer_handler' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: > symbol 'powernv_cpufreq_work_fn' was not declared. Should it be static? > > Those symbols are not used outside of this file, so mark > them static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/cpufreq/powernv-cpufreq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Lee also sent a fix for this, but yours look complete :) https://lore.kernel.org/lkml/20200714145049.2496163-7-lee.jones@linaro.org/ Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Wed, 15 Jul 2020, Viresh Kumar wrote: > On 14-07-20, 22:23, Wei Yongjun wrote: > > The sparse tool complains as follows: > > > > drivers/cpufreq/powernv-cpufreq.c:88:1: warning: > > symbol 'pstate_revmap' was not declared. Should it be static? > > drivers/cpufreq/powernv-cpufreq.c:383:18: warning: > > symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should it be static? > > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: > > symbol 'gpstate_timer_handler' was not declared. Should it be static? > > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: > > symbol 'powernv_cpufreq_work_fn' was not declared. Should it be static? > > > > Those symbols are not used outside of this file, so mark > > them static. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > --- > > drivers/cpufreq/powernv-cpufreq.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > Lee also sent a fix for this, but yours look complete :) > > https://lore.kernel.org/lkml/20200714145049.2496163-7-lee.jones@linaro.org/ > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Yes, looks good to me. Reviewed-by: Lee Jones <lee.jones@linaro.org>
On Tue, Jul 14, 2020 at 4:14 PM Wei Yongjun <weiyongjun1@huawei.com> wrote: > > The sparse tool complains as follows: > > drivers/cpufreq/powernv-cpufreq.c:88:1: warning: > symbol 'pstate_revmap' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:383:18: warning: > symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: > symbol 'gpstate_timer_handler' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: > symbol 'powernv_cpufreq_work_fn' was not declared. Should it be static? > > Those symbols are not used outside of this file, so mark > them static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/cpufreq/powernv-cpufreq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 8646eb197cd9..cf118263ec65 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -85,7 +85,7 @@ struct global_pstate_info { > > static struct cpufreq_frequency_table powernv_freqs[POWERNV_MAX_PSTATES+1]; > > -DEFINE_HASHTABLE(pstate_revmap, POWERNV_MAX_PSTATES_ORDER); > +static DEFINE_HASHTABLE(pstate_revmap, POWERNV_MAX_PSTATES_ORDER); > /** > * struct pstate_idx_revmap_data: Entry in the hashmap pstate_revmap > * indexed by a function of pstate id. > @@ -380,7 +380,7 @@ static ssize_t cpuinfo_nominal_freq_show(struct cpufreq_policy *policy, > powernv_freqs[powernv_pstate_info.nominal].frequency); > } > > -struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = > +static struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = > __ATTR_RO(cpuinfo_nominal_freq); > > #define SCALING_BOOST_FREQS_ATTR_INDEX 2 > @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) > * according quadratic equation. Queues a new timer if it is still not equal > * to local pstate > */ > -void gpstate_timer_handler(struct timer_list *t) > +static void gpstate_timer_handler(struct timer_list *t) > { > struct global_pstate_info *gpstates = from_timer(gpstates, t, timer); > struct cpufreq_policy *policy = gpstates->policy; > @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { > .notifier_call = powernv_cpufreq_reboot_notifier, > }; > > -void powernv_cpufreq_work_fn(struct work_struct *work) > +static void powernv_cpufreq_work_fn(struct work_struct *work) > { > struct chip *chip = container_of(work, struct chip, throttle); > struct cpufreq_policy *policy; > Applied as 5.9 material, thanks!
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 8646eb197cd9..cf118263ec65 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -85,7 +85,7 @@ struct global_pstate_info { static struct cpufreq_frequency_table powernv_freqs[POWERNV_MAX_PSTATES+1]; -DEFINE_HASHTABLE(pstate_revmap, POWERNV_MAX_PSTATES_ORDER); +static DEFINE_HASHTABLE(pstate_revmap, POWERNV_MAX_PSTATES_ORDER); /** * struct pstate_idx_revmap_data: Entry in the hashmap pstate_revmap * indexed by a function of pstate id. @@ -380,7 +380,7 @@ static ssize_t cpuinfo_nominal_freq_show(struct cpufreq_policy *policy, powernv_freqs[powernv_pstate_info.nominal].frequency); } -struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = +static struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = __ATTR_RO(cpuinfo_nominal_freq); #define SCALING_BOOST_FREQS_ATTR_INDEX 2 @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) * according quadratic equation. Queues a new timer if it is still not equal * to local pstate */ -void gpstate_timer_handler(struct timer_list *t) +static void gpstate_timer_handler(struct timer_list *t) { struct global_pstate_info *gpstates = from_timer(gpstates, t, timer); struct cpufreq_policy *policy = gpstates->policy; @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { .notifier_call = powernv_cpufreq_reboot_notifier, }; -void powernv_cpufreq_work_fn(struct work_struct *work) +static void powernv_cpufreq_work_fn(struct work_struct *work) { struct chip *chip = container_of(work, struct chip, throttle); struct cpufreq_policy *policy;
The sparse tool complains as follows: drivers/cpufreq/powernv-cpufreq.c:88:1: warning: symbol 'pstate_revmap' was not declared. Should it be static? drivers/cpufreq/powernv-cpufreq.c:383:18: warning: symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should it be static? drivers/cpufreq/powernv-cpufreq.c:669:6: warning: symbol 'gpstate_timer_handler' was not declared. Should it be static? drivers/cpufreq/powernv-cpufreq.c:902:6: warning: symbol 'powernv_cpufreq_work_fn' was not declared. Should it be static? Those symbols are not used outside of this file, so mark them static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/cpufreq/powernv-cpufreq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)