diff mbox series

megaraid_sas: remove undefined ENABLE_IRQ_POLL macro

Message ID 20200715120153.20512-1-chandrakanth.patil@broadcom.com (mailing list archive)
State Mainlined
Commit 07d3f04550023395bbf34b99ec7e00fc50d9859f
Headers show
Series megaraid_sas: remove undefined ENABLE_IRQ_POLL macro | expand

Commit Message

Chandrakanth Patil July 15, 2020, 12:01 p.m. UTC
Issue:
As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
macro in ISR will always be false leads to irq polling non-functional.

Fix:
Remove ENABLE_IRQ_POLL check from isr

Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ")
Cc: <stable@vger.kernel.org> # v5.3+
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin K. Petersen July 15, 2020, 9:33 p.m. UTC | #1
On Wed, 15 Jul 2020 17:31:53 +0530, Chandrakanth Patil wrote:

> Issue:
> As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
> macro in ISR will always be false leads to irq polling non-functional.
> 
> Fix:
> Remove ENABLE_IRQ_POLL check from isr

Applied to 5.8/scsi-fixes, thanks!

[1/1] scsi: megaraid_sas: Remove undefined ENABLE_IRQ_POLL macro
      https://git.kernel.org/mkp/scsi/c/07d3f0455002
diff mbox series

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index bb34278..0824410 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3740,10 +3740,8 @@  static irqreturn_t megasas_isr_fusion(int irq, void *devp)
 	if (instance->mask_interrupts)
 		return IRQ_NONE;
 
-#if defined(ENABLE_IRQ_POLL)
 	if (irq_context->irq_poll_scheduled)
 		return IRQ_HANDLED;
-#endif
 
 	if (!instance->msix_vectors) {
 		mfiStatus = instance->instancet->clear_intr(instance);