| Message ID | 20200713083908.1104927-1-anton@ozlabs.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | bc2736e98e02097ec0e1245b7facf7c8ebec550c |
| Headers | show |
| Series | lpfc: Quieten some printks | expand |
On 7/13/2020 1:39 AM, Anton Blanchard wrote: > On a big box the lpfc driver emits a few thousand "Set Affinity" lines > to the console. Reduce the priority of these from KERN_ERR to KERN_INFO, > and also fix a few printks that had no log level. > > Signed-off-by: Anton Blanchard <anton@ozlabs.org> > --- > drivers/scsi/lpfc/lpfc_init.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 6637f84a3d1b..daa41ddaf33d 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -11008,7 +11008,7 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) > /* 1 to 1, the first LPFC_CPU_FIRST_IRQ cpus to a unique hdwq */ > cpup->hdwq = idx; > idx++; > - lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > + lpfc_printf_log(phba, KERN_INFO, LOG_INIT, > "3333 Set Affinity: CPU %d (phys %d core %d): " > "hdwq %d eq %d flg x%x\n", > cpu, cpup->phys_id, cpup->core_id, > @@ -11086,7 +11086,7 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) > start_cpu = first_cpu; > cpup->hdwq = new_cpup->hdwq; > logit: > - lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > + lpfc_printf_log(phba, KERN_INFO, LOG_INIT, > "3335 Set Affinity: CPU %d (phys %d core %d): " > "hdwq %d eq %d flg x%x\n", > cpu, cpup->phys_id, cpup->core_id, > @@ -13974,8 +13974,8 @@ lpfc_init(void) > { > int error = 0; > > - printk(LPFC_MODULE_DESC "\n"); > - printk(LPFC_COPYRIGHT "\n"); > + pr_info(LPFC_MODULE_DESC "\n"); > + pr_info(LPFC_COPYRIGHT "\n"); > > error = misc_register(&lpfc_mgmt_dev); > if (error) Reviewed-by: James Smart <james.smart@broadcom.com> Certainly agree. Thanks -- james
On Mon, 13 Jul 2020 18:39:08 +1000, Anton Blanchard wrote: > On a big box the lpfc driver emits a few thousand "Set Affinity" lines > to the console. Reduce the priority of these from KERN_ERR to KERN_INFO, > and also fix a few printks that had no log level. Applied to 5.9/scsi-queue, thanks! [1/1] scsi: lpfc: Quieten some printks https://git.kernel.org/mkp/scsi/c/bc2736e98e02
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 6637f84a3d1b..daa41ddaf33d 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -11008,7 +11008,7 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) /* 1 to 1, the first LPFC_CPU_FIRST_IRQ cpus to a unique hdwq */ cpup->hdwq = idx; idx++; - lpfc_printf_log(phba, KERN_ERR, LOG_INIT, + lpfc_printf_log(phba, KERN_INFO, LOG_INIT, "3333 Set Affinity: CPU %d (phys %d core %d): " "hdwq %d eq %d flg x%x\n", cpu, cpup->phys_id, cpup->core_id, @@ -11086,7 +11086,7 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) start_cpu = first_cpu; cpup->hdwq = new_cpup->hdwq; logit: - lpfc_printf_log(phba, KERN_ERR, LOG_INIT, + lpfc_printf_log(phba, KERN_INFO, LOG_INIT, "3335 Set Affinity: CPU %d (phys %d core %d): " "hdwq %d eq %d flg x%x\n", cpu, cpup->phys_id, cpup->core_id, @@ -13974,8 +13974,8 @@ lpfc_init(void) { int error = 0; - printk(LPFC_MODULE_DESC "\n"); - printk(LPFC_COPYRIGHT "\n"); + pr_info(LPFC_MODULE_DESC "\n"); + pr_info(LPFC_COPYRIGHT "\n"); error = misc_register(&lpfc_mgmt_dev); if (error)
On a big box the lpfc driver emits a few thousand "Set Affinity" lines to the console. Reduce the priority of these from KERN_ERR to KERN_INFO, and also fix a few printks that had no log level. Signed-off-by: Anton Blanchard <anton@ozlabs.org> --- drivers/scsi/lpfc/lpfc_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)