| Message ID | 1594871563-30088-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap | expand |
Hi Shengjiu > Add missed return for snd_soc_pcm_component_mmap, otherwise it always > return -EINVAL. > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- Oops, indeed. Thank you for the patch. But it seems these functions are also missing "return" snd_soc_pcm_component_new() snd_soc_pcm_component_sync_stop() Can you please care these, too ? Thank you for your help !! Best regards --- Kuninori Morimoto
On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > > Hi Shengjiu > > > Add missed return for snd_soc_pcm_component_mmap, otherwise it always > > return -EINVAL. > > > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > --- > > Oops, indeed. > Thank you for the patch. > > But it seems these functions are also missing "return" > snd_soc_pcm_component_new() > snd_soc_pcm_component_sync_stop() > > Can you please care these, too ? Ok, will send v2 best regards wang shengjiu
diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c index af9909c5492f..cde7b9c609bb 100644 --- a/sound/soc/soc-component.c +++ b/sound/soc/soc-component.c @@ -705,7 +705,7 @@ int snd_soc_pcm_component_mmap(struct snd_pcm_substream *substream, /* FIXME. it returns 1st mmap now */ for_each_rtd_components(rtd, i, component) if (component->driver->mmap) - soc_component_ret( + return soc_component_ret( component, component->driver->mmap(component, substream, vma));
Add missed return for snd_soc_pcm_component_mmap, otherwise it always return -EINVAL. Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- sound/soc/soc-component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)